From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id D5F81A0C49; Thu, 8 Jul 2021 10:27:22 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 468EF4069C; Thu, 8 Jul 2021 10:27:22 +0200 (CEST) Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by mails.dpdk.org (Postfix) with ESMTP id 5259740687 for ; Thu, 8 Jul 2021 10:27:21 +0200 (CEST) X-IronPort-AV: E=McAfee;i="6200,9189,10038"; a="206451657" X-IronPort-AV: E=Sophos;i="5.84,222,1620716400"; d="scan'208,217";a="206451657" Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by fmsmga102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 08 Jul 2021 01:27:20 -0700 X-IronPort-AV: E=Sophos;i="5.84,222,1620716400"; d="scan'208,217";a="498347930" Received: from dhunt5-mobl5.ger.corp.intel.com (HELO [10.252.3.227]) ([10.252.3.227]) by fmsmga002-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 08 Jul 2021 01:27:19 -0700 To: Richael Zhuang , dev@dpdk.org Cc: yux.jiang@intel.com References: <20210625020206.42284-2-richael.zhuang@arm.com> <20210708023447.20495-1-richael.zhuang@arm.com> <20210708023447.20495-2-richael.zhuang@arm.com> From: David Hunt Message-ID: Date: Thu, 8 Jul 2021 09:27:17 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 MIME-Version: 1.0 In-Reply-To: <20210708023447.20495-2-richael.zhuang@arm.com> Content-Language: en-GB Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit X-Content-Filtered-By: Mailman/MimeDel 2.1.29 Subject: Re: [dpdk-dev] [PATCH v6 1/2] power: add support for cppc cpufreq X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 8/7/2021 3:34 AM, Richael Zhuang wrote: > Currently in DPDK only acpi_cpufreq and pstate_cpufreq drivers are > supported, which are both not available on arm64 platforms. Add > support for cppc_cpufreq driver which works on most arm64 platforms. > > Signed-off-by: Richael Zhuang > --- > app/test/test_power.c | 3 +- > app/test/test_power_cpufreq.c | 3 +- > lib/power/meson.build | 1 + > lib/power/power_cppc_cpufreq.c | 681 +++++++++++++++++++++++++++++++++ > lib/power/power_cppc_cpufreq.h | 230 +++++++++++ > lib/power/rte_power.c | 26 ++ > lib/power/rte_power.h | 2 +- > 7 files changed, 943 insertions(+), 3 deletions(-) > create mode 100644 lib/power/power_cppc_cpufreq.c > create mode 100644 lib/power/power_cppc_cpufreq.h > --snip-- Hi Richael, thanks for the quick re-spin. Although this shows a build error in patchwork, as we know, that's because of the depenedent patch set - http://patches.dpdk.org/project/dpdk/list/?series=17453 If I apply that dependency first, it then builds fine, and checkpatch is clean, although I can't give it a run, as I currently don't have access to a suitable machine. LGTM. Acked-by: David Hunt