From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by dpdk.org (Postfix) with ESMTP id 2388B1B1C3 for ; Fri, 8 Dec 2017 22:07:31 +0100 (CET) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by orsmga105.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 08 Dec 2017 13:07:30 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.45,379,1508828400"; d="scan'208";a="10914733" Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.241.225.68]) ([10.241.225.68]) by fmsmga004.fm.intel.com with ESMTP; 08 Dec 2017 13:07:30 -0800 To: Ravi Kumar , dev@dpdk.org References: <1512047472-118050-1-git-send-email-Ravi1.kumar@amd.com> <1512047472-118050-9-git-send-email-Ravi1.kumar@amd.com> From: Ferruh Yigit Cc: Shahaf Shuler Message-ID: Date: Fri, 8 Dec 2017 13:07:30 -0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.5.0 MIME-Version: 1.0 In-Reply-To: <1512047472-118050-9-git-send-email-Ravi1.kumar@amd.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Subject: Re: [dpdk-dev] [PATCH 09/16] net/axgbe: add DMA programming and dev start and stop apis X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 08 Dec 2017 21:07:32 -0000 On 11/30/2017 5:11 AM, Ravi Kumar wrote: > Signed-off-by: Ravi Kumar <...> > +/* > + * Configure device link speed and setup link. > + * It returns 0 on success. > + */ > +static int > +axgbe_dev_configure(struct rte_eth_dev *dev) > +{ > + struct axgbe_port *pdata = dev->data->dev_private; > + /* Checksum offload to hardware */ > + pdata->rx_csum_enable = dev->data->dev_conf.rxmode.hw_ip_checksum; There is a new method to get offload requests from user, since this is new PMD I believe it would be better to implement new method. Shahaf cc'ed for more support if required. <...>