From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <ferruh.yigit@intel.com>
Received: from mga06.intel.com (mga06.intel.com [134.134.136.31])
 by dpdk.org (Postfix) with ESMTP id 0FF195A44;
 Wed, 11 Jan 2017 16:26:53 +0100 (CET)
Received: from orsmga005.jf.intel.com ([10.7.209.41])
 by orsmga104.jf.intel.com with ESMTP; 11 Jan 2017 07:26:52 -0800
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.33,346,1477983600"; d="scan'208";a="51817919"
Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.237.220.38])
 ([10.237.220.38])
 by orsmga005.jf.intel.com with ESMTP; 11 Jan 2017 07:26:51 -0800
To: "Iremonger, Bernard" <bernard.iremonger@intel.com>,
 "Lu, Wenzhuo" <wenzhuo.lu@intel.com>, "dev@dpdk.org" <dev@dpdk.org>
References: <1484102853-53205-1-git-send-email-wenzhuo.lu@intel.com>
 <8CEF83825BEC744B83065625E567D7C224D1CB14@IRSMSX108.ger.corp.intel.com>
 <8CEF83825BEC744B83065625E567D7C224D1CCE7@IRSMSX108.ger.corp.intel.com>
Cc: "Wu, Jingjing" <jingjing.wu@intel.com>, "stable@dpdk.org" <stable@dpdk.org>
From: Ferruh Yigit <ferruh.yigit@intel.com>
Message-ID: <ab79243c-d2f3-0711-dfb3-2e77fcced748@intel.com>
Date: Wed, 11 Jan 2017 15:26:51 +0000
User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:45.0) Gecko/20100101
 Thunderbird/45.6.0
MIME-Version: 1.0
In-Reply-To: <8CEF83825BEC744B83065625E567D7C224D1CCE7@IRSMSX108.ger.corp.intel.com>
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 7bit
Subject: Re: [dpdk-dev] [dpdk-stable] [PATCH] app/testpmd: fix ixgbe private
 API calling
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Wed, 11 Jan 2017 15:26:54 -0000

On 1/11/2017 3:20 PM, Iremonger, Bernard wrote:
> Hi Wenzhuo,
> 
> <snip>
>>> Subject: [dpdk-dev] [PATCH] app/testpmd: fix ixgbe private API calling
>>>
>>> Some ixgbe private APIs are added to expose ixgbe specific functions.
>>> When they're used by testpmd, there's no check for if the NICs are ixgbe.
>>> Other NICs also have chance to  call these APIs.
>>> This patch add the check and the feedback print.
>>
>> I am not sure that testpmd is the right place to do this.
>> The rte_pmd_ixgbe_* functions are public API's which can be called by other
>> applications.
>> The checks should be in the rte_pmd_ixgbe_* API's
> 
> It is useful to handle the return code -ENOTSUP in testpmd.  
>  

Makes sense, and I think it is good idea to add them in your patch,
since it introduces returning -ENOTSUP, would you mind sending a new
version of your patch with this update?
So we can drop this patch completely.

Thanks,
ferruh