From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 03D3BA052A; Tue, 26 Jan 2021 16:32:58 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id E9B93140FB9; Tue, 26 Jan 2021 16:32:57 +0100 (CET) Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by mails.dpdk.org (Postfix) with ESMTP id 00307140FB9 for ; Tue, 26 Jan 2021 16:32:56 +0100 (CET) IronPort-SDR: BPb9hd6ttcOsQ/ZExdls6DLJEgJP/EWiAudq57gQ5lC6J7vq+hSBliAM75jXovnps3yxEMxH9H wYrBft6m+b+A== X-IronPort-AV: E=McAfee;i="6000,8403,9876"; a="179138086" X-IronPort-AV: E=Sophos;i="5.79,375,1602572400"; d="scan'208";a="179138086" Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 26 Jan 2021 07:32:55 -0800 IronPort-SDR: 1vsQKdEjNzeAW8LEJDBVIz8Vg7yH8529GtdgPUAhZ52bdhbgLj6qIjcxtmu+hrN1j6biDPSHfd PiZ9sfsR4KRA== X-IronPort-AV: E=Sophos;i="5.79,375,1602572400"; d="scan'208";a="362022682" Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.213.227.53]) ([10.213.227.53]) by fmsmga008-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 26 Jan 2021 07:32:53 -0800 To: Nalla Pradeep , Radha Mohan Chintakuntla , Veerasenareddy Burru Cc: jerinj@marvell.com, dev@dpdk.org, sburla@marvell.com References: <20210118093602.5449-1-pnalla@marvell.com> <20210118093602.5449-9-pnalla@marvell.com> From: Ferruh Yigit Message-ID: Date: Tue, 26 Jan 2021 15:32:52 +0000 MIME-Version: 1.0 In-Reply-To: <20210118093602.5449-9-pnalla@marvell.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit Subject: Re: [dpdk-dev] [PATCH v2 09/11] net/octeontx_ep: Added dev start and stop X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 1/18/2021 9:36 AM, Nalla Pradeep wrote: > Dev start and stop operations are added. To accomplish this internal > functions to enable or disable io queues are incorporated. > > Signed-off-by: Nalla Pradeep <...> > +static int > +otx_ep_dev_start(struct rte_eth_dev *eth_dev) > +{ > + struct otx_ep_device *otx_epvf; > + unsigned int q; > + int ret; > + > + otx_epvf = (struct otx_ep_device *)OTX_EP_DEV(eth_dev); > + /* Enable IQ/OQ for this device */ > + ret = otx_epvf->fn_list.enable_io_queues(otx_epvf); > + if (ret) { > + otx_ep_err("IOQ enable failed\n"); > + return ret; > + } > + > + for (q = 0; q < otx_epvf->nb_rx_queues; q++) { > + rte_write32(otx_epvf->droq[q]->nb_desc, > + otx_epvf->droq[q]->pkts_credit_reg); > + > + rte_wmb(); > + otx_ep_info("OQ[%d] dbells [%d]\n", q, > + rte_read32(otx_epvf->droq[q]->pkts_credit_reg)); > + } > + > + otx_epvf->started = 1; > + > + rte_wmb(); is this memory barrier required, isn't the one in the loop should be enough? And no ones seems reading the 'started'. > + otx_ep_info("dev started\n"); > + > + return 0; > +} > + <...>