DPDK patches and discussions
 help / color / mirror / Atom feed
From: Ferruh Yigit <ferruh.yigit@intel.com>
To: "Mody, Rasesh" <Rasesh.Mody@cavium.com>,
	"stephen@networkplumber.org" <stephen@networkplumber.org>
Cc: "dev@dpdk.org" <dev@dpdk.org>,
	Dept-Eng DPDK Dev <Dept-EngDPDKDev@cavium.com>,
	"stable@dpdk.org" <stable@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH 1/2] net/bnx2x: cleanup info logs
Date: Fri, 16 Nov 2018 11:26:06 +0000
Message-ID: <ab9d7af1-447a-38a6-dc35-dccb8925e21c@intel.com> (raw)
In-Reply-To: <1542219449-7393-1-git-send-email-rasesh.mody@cavium.com>

On 11/14/2018 6:17 PM, Mody, Rasesh wrote:
> Reduced number of INFO logs in BNX2X PMD by converting some INFO
> logs to DEBUG and few NOTICE logs to INFO, removing extra new lines,
> printing banner bar once for the adapter and device specific info.
> 
> Fixes: ba7eeb035a5f ("net/bnx2x: fix logging to include device name")
> Fixes: 540a211084a7 ("bnx2x: driver core")
> Cc: stable@dpdk.org
> 
> Signed-off-by: Rasesh Mody <rasesh.mody@cavium.com>

<...>

> +	PMD_INIT_FUNC_TRACE(sc);
> +	offset = offsetof(struct shmem_region,
> +			  dev_info.port_hw_config[0].external_phy_config);
> +	if (sc->link_vars.phy_flags & PHY_XGXS_FLAG)
> +		ext_phy_type = ELINK_XGXS_EXT_PHY_TYPE(REG_RD(sc,
> +							      sc->
> +							      devinfo.
> +							      shmem_base
> +							      + offset));
> +	else
> +		ext_phy_type = ELINK_SERDES_EXT_PHY_TYPE(REG_RD(sc,
> +								sc->
> +								devinfo.
> +								shmem_base
> +								+ offset));

This looks ugly and hard to read, to avoid multi line derefernce,
What do you think:

 reg_val = REG_RD(sc, sc->devinfo.shmem_base + offset);
 ext_phy_type = ELINK_SERDES_EXT_PHY_TYPE(reg_val);

  parent reply	other threads:[~2018-11-16 11:26 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-11-14 18:17 Mody, Rasesh
2018-11-14 18:17 ` [dpdk-dev] [PATCH 2/2] net/bnx2x: bump version to 1.0.7.1 Mody, Rasesh
2018-11-16 11:26 ` Ferruh Yigit [this message]
2018-11-17  9:38   ` [dpdk-dev] [PATCH 1/2] net/bnx2x: cleanup info logs Mody, Rasesh
2018-11-17  9:37 ` [dpdk-dev] [PATCH v2 " Mody, Rasesh
2018-11-27 15:30   ` Ferruh Yigit
2018-11-17  9:37 ` [dpdk-dev] [PATCH v2 2/2] net/bnx2x: bump version to 1.0.7.1 Mody, Rasesh
2018-11-19 13:27   ` Ferruh Yigit
2018-11-19 18:48     ` Mody, Rasesh
2018-11-20  9:22   ` Ferruh Yigit

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ab9d7af1-447a-38a6-dc35-dccb8925e21c@intel.com \
    --to=ferruh.yigit@intel.com \
    --cc=Dept-EngDPDKDev@cavium.com \
    --cc=Rasesh.Mody@cavium.com \
    --cc=dev@dpdk.org \
    --cc=stable@dpdk.org \
    --cc=stephen@networkplumber.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

DPDK patches and discussions

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://inbox.dpdk.org/dev/0 dev/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 dev dev/ https://inbox.dpdk.org/dev \
		dev@dpdk.org
	public-inbox-index dev

Example config snippet for mirrors.
Newsgroup available over NNTP:
	nntp://inbox.dpdk.org/inbox.dpdk.dev


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git