From: Olivier Matz <olivier.matz@6wind.com>
To: Weiliang Luo <droidluo@gmail.com>, dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH] mempool: fix sp sc mempool bug
Date: Thu, 8 Sep 2016 10:13:40 +0200 [thread overview]
Message-ID: <abd92a5e-4f1a-a9b1-6fb5-f114bd8aa441@6wind.com> (raw)
In-Reply-To: <1473305760-2420-1-git-send-email-droidluo@gmail.com>
Hi Weiliang,
On 09/08/2016 05:36 AM, Weiliang Luo wrote:
> Signed-off-by: Weiliang Luo <droidluo@gmail.com>
> ---
> lib/librte_mempool/rte_mempool.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/lib/librte_mempool/rte_mempool.c b/lib/librte_mempool/rte_mempool.c
> index 2e28e2e..350d77a 100644
> --- a/lib/librte_mempool/rte_mempool.c
> +++ b/lib/librte_mempool/rte_mempool.c
> @@ -879,7 +879,7 @@ rte_mempool_create(const char *name, unsigned n, unsigned elt_size,
> * Since we have 4 combinations of the SP/SC/MP/MC examine the flags to
> * set the correct index into the table of ops structs.
> */
> - if (flags & (MEMPOOL_F_SP_PUT | MEMPOOL_F_SC_GET))
> + if ((flags & MEMPOOL_F_SP_PUT) && (flags & MEMPOOL_F_SC_GET))
> rte_mempool_set_ops_byname(mp, "ring_sp_sc", NULL);
> else if (flags & MEMPOOL_F_SP_PUT)
> rte_mempool_set_ops_byname(mp, "ring_sp_mc", NULL);
>
I would just change the title and add some explanation in the commit
log. I suggest:
"""
mempool: fix corruption due to invalid handler
When using rte_mempool_create(), the mempool handler is selected
depending on the flags given by the user:
- multi-consumer / multi-producer
- multi-consumer / single-producer
- single-consumer / multi-producer
- single-consumer / single-producer
The flags were not properly tested, resulting in the selection of sc/sp
handler if sc/mp or mc/sp was asked. This can lead to corruption or
crashes because the get/put operations are not atomic.
Fixes: 449c49b93a6b ("mempool: support handler operations")
Signed-off-by: Weiliang Luo <droidluo@gmail.com>
Acked-by: Olivier Matz <olivier.matz@6wind.com>
"""
Thanks!
Olivier
next prev parent reply other threads:[~2016-09-08 8:13 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-08 3:36 Weiliang Luo
2016-09-08 8:13 ` Olivier Matz [this message]
2016-09-08 16:08 ` Weiliang Luo
2016-09-08 3:52 Weiliang Luo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=abd92a5e-4f1a-a9b1-6fb5-f114bd8aa441@6wind.com \
--to=olivier.matz@6wind.com \
--cc=dev@dpdk.org \
--cc=droidluo@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).