From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) by dpdk.org (Postfix) with ESMTP id 1EF326833 for ; Thu, 19 Apr 2018 15:36:20 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga004.jf.intel.com ([10.7.209.38]) by orsmga104.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 19 Apr 2018 06:36:20 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.48,469,1517904000"; d="scan'208";a="192758615" Received: from fyigit-mobl.ger.corp.intel.com (HELO [10.237.221.42]) ([10.237.221.42]) by orsmga004.jf.intel.com with ESMTP; 19 Apr 2018 06:36:17 -0700 To: Zijie Pan , dev@dpdk.org, Beilei Xing , Qi Zhang , Helin Zhang Cc: remy.horton@intel.com, Thomas Monjalon , Wenzhuo Lu , Konstantin Ananyev References: <1521193010-25050-1-git-send-email-zijie.pan@6wind.com> <1521630379-9554-1-git-send-email-zijie.pan@6wind.com> From: Ferruh Yigit Openpgp: preference=signencrypt Autocrypt: addr=ferruh.yigit@intel.com; prefer-encrypt=mutual; keydata= xsFNBFXZCFABEADCujshBOAaqPZpwShdkzkyGpJ15lmxiSr3jVMqOtQS/sB3FYLT0/d3+bvy qbL9YnlbPyRvZfnP3pXiKwkRoR1RJwEo2BOf6hxdzTmLRtGtwWzI9MwrUPj6n/ldiD58VAGQ +iR1I/z9UBUN/ZMksElA2D7Jgg7vZ78iKwNnd+vLBD6I61kVrZ45Vjo3r+pPOByUBXOUlxp9 GWEKKIrJ4eogqkVNSixN16VYK7xR+5OUkBYUO+sE6etSxCr7BahMPKxH+XPlZZjKrxciaWQb +dElz3Ab4Opl+ZT/bK2huX+W+NJBEBVzjTkhjSTjcyRdxvS1gwWRuXqAml/sh+KQjPV1PPHF YK5LcqLkle+OKTCa82OvUb7cr+ALxATIZXQkgmn+zFT8UzSS3aiBBohg3BtbTIWy51jNlYdy ezUZ4UxKSsFuUTPt+JjHQBvF7WKbmNGS3fCid5Iag4tWOfZoqiCNzxApkVugltxoc6rG2TyX CmI2rP0mQ0GOsGXA3+3c1MCdQFzdIn/5tLBZyKy4F54UFo35eOX8/g7OaE+xrgY/4bZjpxC1 1pd66AAtKb3aNXpHvIfkVV6NYloo52H+FUE5ZDPNCGD0/btFGPWmWRmkPybzColTy7fmPaGz cBcEEqHK4T0aY4UJmE7Ylvg255Kz7s6wGZe6IR3N0cKNv++O7QARAQABzSVGZXJydWggWWln aXQgPGZlcnJ1aC55aWdpdEBpbnRlbC5jb20+wsF+BBMBAgAoAhsDBgsJCAcDAgYVCAIJCgsE FgIDAQIeAQIXgAUCWZR3VQUJB33WBQAKCRD5M+tD3xNhH6DWEACVhEb8q1epPwZrUDoxzu7E TS1b8tmabOmnjXZRs6+EXgUVHkp2xxkCfDmL3pa5bC0G/74aJnWjNsdvE05V1cb4YK4kRQ62 FwDQ+hlrFrwFB3PtDZk1tpkzCRHvJgnIil+0MuEh32Y57ig6hy8yO8ql7Lohyrnpfk/nNpm4 jQGEF5qEeHcEFe1AZQlPHN/STno8NZSz2nl0b2cw+cujN1krmvB52Ah/2KugQ6pprVyrGrzB c34ZQO9OsmSjJlETCZk6EZzuhfe16iqBFbOSadi9sPcJRwaUQBid+xdFWl7GQ8qC3zNPibSF HmU43yBZUqJDZlhIcl6/cFpOSjv2sDWdtjEXTDn5y/0FsuY0mFE78ItC4kCTIVk17VZoywcd fmbbnwOSWzDq7hiUYuQGkIudJw5k/A1CMsyLkoUEGN3sLfsw6KASgS4XrrmPO4UVr3mH5bP1 yC7i1OVNpzvOxtahmzm481ID8sk72GC2RktTOHb0cX+qdoiMMfYgo3wRRDYCBt6YoGYUxF1p msjocXyqToKhhnFbXLaZlVfnQ9i2i8jsj9SKig+ewC2p3lkPj6ncye9q95bzhmUeJO6sFhJg Hiz6syOMg8yCcq60j07airybAuHIDNFWk0gaWAmtHZxLObZx2PVn2nv9kLYGohFekw0AOsIW ta++5m48dnCoAc7BTQRX1ky+ARAApzQNvXvE2q1LAS+Z+ni2R13Bb1cDS1ZYq1jgpR13+OKN ipzd8MPngRJilXxBaPTErhgzR0vGcNTYhjGMSyFIHVOoBq1VbP1a0Fi/NqWzJOowo/fDfgVy K4vuitc/gCJs+2se4hdZA4EQJxVlNM51lgYDNpjPGIA43MX15OLAip73+ho6NPBMuc5qse3X pAClNhBKfENRCWN428pi3WVkT+ABRTE0taxjJNP7bb+9TQYNRqGwnGzX5/XISv44asWIQCaq vOkXSUJLd//cdVNTqtL1wreCVVR5pMXj7VIrlk07fmmJVALCmGbFr53BMb8O+8dgK2A5mitM n44d+8KdJWOwziRxcaMk/LclmZS3Iv1TERtiWt98Y9AjeAtcgYPkA3ld0BcUKONogP8pHVz1 Ed3s5rDQ91yr1S0wuAzW91fxGUO4wY+uPmxCtFVuBgd9VT9NAKTUL0qHM7CDgCnZPe0TW6Zj 8OqtdCCyAfvU9cW5xWM7Icxhde6AtPxhDSBwE8fL2ZmrDmaA4jmUKXp3i4JxRPSX84S08b+s DWXHPxy10UFU5A7EK/BEbZAKBwn9ROfm+WK+6X5xOGLoRE++OqNuUudxC1GDyLOPaqCbBCS9 +P6HsTHzxsjyJa27n4jcrcuY3P9TEcFJYSZSeSDh8mVGvugi0exnSJrrBZDyVCcAEQEAAcLB ZQQYAQIADwIbDAUCWZR1ZwUJA59cIQAKCRD5M+tD3xNhH5b+D/9XG44Ci6STdcA5RO/ur05J EE3Ux1DCHZ5V7vNAtX/8Wg4l4GZfweauXwuJ1w7Sp7fklwcNC6wsceI+EmNjGMqfIaukGetG +jBGqsQ7moOZodfXUoCK98gblKgt/BPYMVidzlGC8Q/+lZg1+o29sPnwImW+MXt/Z5az/Z17 Qc265g+p5cqJHzq6bpQdnF7Fu6btKU/kv6wJghENvgMXBuyThqsyFReJWFh2wfaKyuix3Zyj ccq7/blkhzIKmtFWgDcgaSc2UAuJU+x9nuYjihW6WobpKP/nlUDu3BIsbIq09UEke+uE/QK+ FJ8PTJkAsXOf1Bc2C0XbW4Y2hf103+YY6L8weUCBsWC5VH5VtVmeuh26ENURclwfeXhWQ9Og 77yzpTXWr5g1Z0oLpYpWPv745J4bE7pv+dzxOrFdM1xNkzY2pvXph/A8OjxZNQklDkHQ7PIB Lki5L2F4XkEOddUUQchJwzMqTPsggPDmGjgLZrqgO+s4ECZK5+nLD3HEpAbPa3JLDaScy+90 Nu1lAqPUHSnP3vYZVw85ZYm6UCxHE4VLMnnJsN09ZhsOSVR+GyP5Nyw9rT1V3lcsuH7M5Naa 2Xobn9m7l9bRCD/Ji8kG15eV1WTxx1HXVQGjdUYDI7UwegBNbwMLh17XDy+3sn/6SgcqtECA Q6pZKA2mTQxEKMLBZQQYAQIADwIbDAUCWZR3hQUJA59eRwAKCRD5M+tD3xNhH4a/D/4jLAZu UhvU1swWcNEVVCELZ0D3LOV14XcY2MXa3QOpeZ9Bgq7YYJ4S5YXK+SBQS0FkRZdjGNvlGZoG ZdpU+NsQmQFhqHGwX0IT9MeTFM8uvKgxNKGwMVcV9g0IOqwBhGHne+BFboRA9362fgGW5AYQ zT0mzzRKEoOh4r3AQvbM6kLISxo0k1ujdYiI5nj/5WoKDqxTwwfuN1uDUHsWo3tzenRmpMyU NyW3Dc+1ajvXLyo09sRRq7BnM99Rix1EGL8Qhwy+j0YAv+FuspWxUX9FxXYho5PvGLHLsHfK FYQ7x/RRbpMjkJWVfIe/xVnfvn4kz+MTA5yhvsuNi678fLwY9hBP0y4lO8Ob2IhEPdfnTuIs tFVxXuelJ9xAe5TyqP0f+fQjf1ixsBZkqOohsBXDfje0iaUpYa/OQ/BBeej0dUdg2JEu4jAC x41HpVCnP9ipLpD0fYz1d/dX0F/VY2ovW6Eba/y/ngOSAR6C+u881m7oH2l0G47MTwkaQCBA bLGXPj4TCdX3lftqt4bcBPBJ+rFAnJmRHtUuyyaewBnZ81ZU2YAptqFM1kTh+aSvMvGhfVsQ qZL2rk2OPN1hg+KXhErlbTZ6oPtLCFhSHQmuxQ4oc4U147wBTUuOdwNjtnNatUhRCp8POc+3 XphVR5G70mnca1E2vzC77z+XSlTyRA== Message-ID: Date: Thu, 19 Apr 2018 14:36:17 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.7.0 MIME-Version: 1.0 In-Reply-To: <1521630379-9554-1-git-send-email-zijie.pan@6wind.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Subject: Re: [dpdk-dev] [PATCH v3 0/5] get the information and data of EEPROM X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 19 Apr 2018 13:36:21 -0000 On 3/21/2018 11:06 AM, Zijie Pan wrote: > Add APIs to read information from the DPDK applictions. > It can be used to dump the EEPROM of plugin modules (SFP+, QSFP, etc.). > > Two APIs are introduced to access eeprom: > - rte_eth_dev_get_module_info > - rte_eth_dev_get_module_eeprom > > Applications based on DPDK can dump eeprom by calling those two APIs. > > Then, each PMD has to implement these callbacks for e1000, ixgbe, i40e, etc. > > Patch for example/ethtool is used to test this function. It can get the raw > data of eeprom. See below how both DPDK applications (ethtool) and Linux > kernel are dumping the same eeprom of a same NIC. > > - Start example/ethtool: > ./examples/ethtool/ethtool-app/x86_64-native-linuxapp-gcc/ethtool -c 0xf -n 4 --socket-mem 1024,0 -- -i > EthApp> drvinfo > Port 0 driver: net_ixgbe (ver: DPDK 18.05.0-rc0) > firmware-version: 0x18b30001 > bus-info: 0000:04:00.0 > > EthApp> module-eeprom > [UINT16]: module-eeprom > Dump plug-in module EEPROM to file > > EthApp> module-eeprom 0 my-module-eeprom.bin > Total plug-in module EEPROM length: 512 bytes > > EthApp> quit > > - HexDump of this eeprom file: > # xxd my-module-eeprom.bin > 0000000: 0304 0710 0000 0100 0000 0006 6702 0000 ............g... > 0000010: 0803 001e 4f45 4d20 2020 2020 2020 2020 ....OEM > 0000020: 2020 2020 0000 1b21 5346 502d 3130 472d ...!SFP-10G- > 0000030: 5352 2d49 5420 2020 4120 2020 0352 0024 SR-IT A .R.$ > 0000040: 003a 0000 5751 3136 3034 3132 4131 3135 .:..WQ160412A115 > 0000050: 2020 2020 3135 3136 3130 2020 68fa 033b 151610 h..; > 0000060: 0000 0000 0000 0000 0000 0000 0000 0000 ................ > 0000070: 0000 0000 0000 0000 0000 0000 0000 0000 ................ > 0000080: ffff ffff ffff ffff ffff ffff ffff ffff ................ > 0000090: ffff ffff ffff ffff ffff ffff ffff ffff ................ > 00000a0: ffff ffff ffff ffff ffff ffff ffff ffff ................ > 00000b0: ffff ffff ffff ffff ffff ffff ffff ffff ................ > 00000c0: ffff ffff ffff ffff ffff ffff ffff ffff ................ > 00000d0: ffff ffff ffff ffff ffff ffff ffff ffff ................ > 00000e0: ffff ffff ffff ffff ffff ffff ffff ffff ................ > 00000f0: ffff ffff ffff ffff ffff ffff ffff ffff ................ > 0000100: 5000 fb00 4b00 0000 8ca0 7530 88b8 7918 P...K.....u0..y. > 0000110: 1d4c 01f4 1b58 03e8 3de9 03e8 2710 04eb .L...X..=...'... > 0000120: 2710 0064 1f07 007e 0000 0000 0000 0000 '..d...~........ > 0000130: 0000 0000 0000 0000 0000 0000 0000 0000 ................ > 0000140: 0000 0000 3f80 0000 0000 0000 0100 0000 ....?........... > 0000150: 0100 0000 0100 0000 0100 0000 0000 002d ...............- > 0000160: 2c59 810a 13c7 1752 0001 0000 0000 0200 ,Y.....R........ > 0000170: 0040 0000 0040 0000 0000 0000 0000 0000 .@...@.......... > 0000180: ffff ffff ffff ffff ffff ffff ffff ffff ................ > 0000190: ffff ffff ffff ffff ffff ffff ffff ffff ................ > 00001a0: ffff faff ffff ffff ffff ffff ffff ffff ................ > 00001b0: ffff ffff ffff ffff ffff ffff ffff ffff ................ > 00001c0: ffff ffff ffff ffff ffff ffff ffff ffff ................ > 00001d0: ffff ffff ffff ffff ffff ffff ffff ffff ................ > 00001e0: ffff ffff ffff ffff ffff ffff ffff ffff ................ > 00001f0: ffff ffff ffff ffff 0003 0100 0000 0000 ................ > > - Rerun same dump using Linux's kernel ethtool. > > # ./install/sbin/dpdk-devbind --bind=ixgbe 04:00.0 > # ethtool -m p2p1 raw on > meeprom-kernel.bin > > # xxd meeprom-kernel.bin > 0000000: 0304 0710 0000 0100 0000 0006 6702 0000 ............g... > 0000010: 0803 001e 4f45 4d20 2020 2020 2020 2020 ....OEM > 0000020: 2020 2020 0000 1b21 5346 502d 3130 472d ...!SFP-10G- > 0000030: 5352 2d49 5420 2020 4120 2020 0352 0024 SR-IT A .R.$ > 0000040: 003a 0000 5751 3136 3034 3132 4131 3135 .:..WQ160412A115 > 0000050: 2020 2020 3135 3136 3130 2020 68fa 033b 151610 h..; > 0000060: 0000 0000 0000 0000 0000 0000 0000 0000 ................ > 0000070: 0000 0000 0000 0000 0000 0000 0000 0000 ................ > 0000080: ffff ffff ffff ffff ffff ffff ffff ffff ................ > 0000090: ffff ffff ffff ffff ffff ffff ffff ffff ................ > 00000a0: ffff ffff ffff ffff ffff ffff ffff ffff ................ > 00000b0: ffff ffff ffff ffff ffff ffff ffff ffff ................ > 00000c0: ffff ffff ffff ffff ffff ffff ffff ffff ................ > 00000d0: ffff ffff ffff ffff ffff ffff ffff ffff ................ > 00000e0: ffff ffff ffff ffff ffff ffff ffff ffff ................ > 00000f0: ffff ffff ffff ffff ffff ffff ffff ffff ................ > 0000100: 5000 fb00 4b00 0000 8ca0 7530 88b8 7918 P...K.....u0..y. > 0000110: 1d4c 01f4 1b58 03e8 3de9 03e8 2710 04eb .L...X..=...'... > 0000120: 2710 0064 1f07 007e 0000 0000 0000 0000 '..d...~........ > 0000130: 0000 0000 0000 0000 0000 0000 0000 0000 ................ > 0000140: 0000 0000 3f80 0000 0000 0000 0100 0000 ....?........... > 0000150: 0100 0000 0100 0000 0100 0000 0000 002d ...............- > 0000160: 2899 8146 0058 0001 0001 0000 0000 8200 (..F.X.......... > 0000170: 0540 0000 0540 0000 0000 0000 0000 0000 .@...@.......... > 0000180: ffff ffff ffff ffff ffff ffff ffff ffff ................ > 0000190: ffff ffff ffff ffff ffff ffff ffff ffff ................ > 00001a0: ffff faff ffff ffff ffff ffff ffff ffff ................ > 00001b0: ffff ffff ffff ffff ffff ffff ffff ffff ................ > 00001c0: ffff ffff ffff ffff ffff ffff ffff ffff ................ > 00001d0: ffff ffff ffff ffff ffff ffff ffff ffff ................ > 00001e0: ffff ffff ffff ffff ffff ffff ffff ffff ................ > 00001f0: ffff ffff ffff ffff 0003 0100 0000 0000 ................ > > Both DPDK's my-module-eeprom.bin and Kernel's meeprom-kernel.bin > are the same. > > v2 changes: > - Fix typo in features.rst. > - Fix checkpatch warnings regarding long lines. > - Update function pcmd_module_eeprom_callback(). > > v3 changes: > - fix compilation when dpdk is compiled with shared libs. > > Zijie Pan (5): > ethdev: add access to eeprom > examples/ethtool: add a new command module-eeprom > net/ixgbe: add module EEPROM callbacks for ixgbe > net/e1000: add module EEPROM callbacks for e1000 > net/i40e: add module EEPROM callbacks for i40e This patch is waiting for a while without comment, please share if there is any concern about patch. Thanks, ferruh