From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by dpdk.org (Postfix) with ESMTP id 2CD58282 for ; Tue, 31 Jan 2017 14:06:14 +0100 (CET) Received: from orsmga004.jf.intel.com ([10.7.209.38]) by fmsmga102.fm.intel.com with ESMTP; 31 Jan 2017 05:06:07 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.33,315,1477983600"; d="scan'208";a="54052069" Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.237.220.38]) ([10.237.220.38]) by orsmga004.jf.intel.com with ESMTP; 31 Jan 2017 05:06:06 -0800 To: Pascal Mazon , keith.wiles@intel.com References: <1485855778-15496-1-git-send-email-pascal.mazon@6wind.com> Cc: dev@dpdk.org From: Ferruh Yigit Message-ID: Date: Tue, 31 Jan 2017 13:06:06 +0000 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.7.0 MIME-Version: 1.0 In-Reply-To: <1485855778-15496-1-git-send-email-pascal.mazon@6wind.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 8bit Subject: Re: [dpdk-dev] [PATCH 1/6] net/tap: use correct tap name X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 31 Jan 2017 13:06:15 -0000 On 1/31/2017 9:42 AM, Pascal Mazon wrote: > dev->data->name contains "net_tap", the device driver name. I see what patch does, just as a note to commit log: AFAIK, "dev->data->name" is device name, and for this case it is "net_tap#", like "net_tap0", "net_tap1" ... "dev->data_drv_name" is the driver name which is "net_tap" > dev->data->dev_private->name contains the actual iface name, > e.g. "dtap0". Right, I agree this is correct comparing "dev->data->name" But the problem is pmd->name is per eth_dev. If I read code correct, for multiple queue support, each queue pair will create a tap device, so each needs a different name. So can't just use pmd->name. Need to create a name per queue pair, it can be combination of pmd->name + "_" + queue_id? Or can keep a name per queue pair, instead of eth_dev. What do you think? > > In tun_alloc() especially, we want to use the latter. Otherwise the > netdevice would be wrongly named "net_tap". Furthermore, creating > several tap vdev would point to the same netdevice. > > In any case, it must to be consistent with the tun_alloc() call in > eth_dev_tap_create(). > > Signed-off-by: Pascal Mazon <...>