From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 568BDA00C2; Wed, 2 Nov 2022 07:32:15 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id F26F340693; Wed, 2 Nov 2022 07:32:14 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mails.dpdk.org (Postfix) with ESMTP id B421540223 for ; Wed, 2 Nov 2022 07:32:13 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1667370732; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Py4T9WQWCLpXWPNRzW5aFCg8YH0Nw63ZT03lhk1rP5w=; b=Xy/Lh2mveRfcEIQdTAPtM0bziIGCO4nK39uLGWuk0LP4d+HN8ZGe4dLTDML/JOuU/Zwb3+ Rh01D/JDss6s7xEbr5rW4NtxlsU3YMniPEgqv8lkWHckiCh4zZ4Rqevqm9chdI7IMMQJ7q OEb0Ia13SPr8xdzjXRsnG7iMjF5vwQg= Received: from mimecast-mx02.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-649-ieT0DTfTPIChscQ0ufcwiA-1; Wed, 02 Nov 2022 02:32:08 -0400 X-MC-Unique: ieT0DTfTPIChscQ0ufcwiA-1 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.rdu2.redhat.com [10.11.54.4]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 4EF4B38012E1; Wed, 2 Nov 2022 06:32:08 +0000 (UTC) Received: from [10.39.208.11] (unknown [10.39.208.11]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 701E72028CE4; Wed, 2 Nov 2022 06:32:04 +0000 (UTC) Message-ID: Date: Wed, 2 Nov 2022 07:32:01 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.4.0 Subject: Re: [PATCH v1 1/6] baseband/acc: fix LTE half iteration flag To: Nicolas Chautru , dev@dpdk.org, gakhil@marvell.com, hernan.vargas@intel.com References: <20221101230459.50891-1-nicolas.chautru@intel.com> <20221101230459.50891-2-nicolas.chautru@intel.com> From: Maxime Coquelin In-Reply-To: <20221101230459.50891-2-nicolas.chautru@intel.com> X-Scanned-By: MIMEDefang 3.1 on 10.11.54.4 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 11/2/22 00:04, Nicolas Chautru wrote: > The logic for that flag was inverted. > Specific to ACC200. > When starting with even iteration it actually runs > for an additional half iteration. > > Fixes: bec597b78a0 ("baseband/acc200: add LTE processing") > > Signed-off-by: Nicolas Chautru > --- > drivers/baseband/acc/rte_acc200_pmd.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/drivers/baseband/acc/rte_acc200_pmd.c b/drivers/baseband/acc/rte_acc200_pmd.c > index 8ee9023451..0cbb9a946b 100644 > --- a/drivers/baseband/acc/rte_acc200_pmd.c > +++ b/drivers/baseband/acc/rte_acc200_pmd.c > @@ -1238,8 +1238,7 @@ acc200_fcw_td_fill(const struct rte_bbdev_dec_op *op, struct acc_fcw_td *fcw) > fcw->raw_decoder_input_on = 0; > fcw->max_iter = RTE_MAX((uint8_t) op->turbo_dec.iter_max, 2); > fcw->min_iter = 2; > - fcw->half_iter_on = !check_bit(op->turbo_dec.op_flags, > - RTE_BBDEV_TURBO_HALF_ITERATION_EVEN); > + fcw->half_iter_on = check_bit(op->turbo_dec.op_flags, RTE_BBDEV_TURBO_HALF_ITERATION_EVEN); > > fcw->early_stop_en = check_bit(op->turbo_dec.op_flags, > RTE_BBDEV_TURBO_EARLY_TERMINATION) & !fcw->soft_output_en; Reviewed-by: Maxime Coquelin Thanks, Maxime