From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
	by inbox.dpdk.org (Postfix) with ESMTP id 119594414A;
	Mon,  3 Jun 2024 18:30:30 +0200 (CEST)
Received: from mails.dpdk.org (localhost [127.0.0.1])
	by mails.dpdk.org (Postfix) with ESMTP id DDAEC42E6F;
	Mon,  3 Jun 2024 18:30:29 +0200 (CEST)
Received: from foss.arm.com (foss.arm.com [217.140.110.172])
 by mails.dpdk.org (Postfix) with ESMTP id 48B6A42E4A
 for <dev@dpdk.org>; Mon,  3 Jun 2024 18:30:28 +0200 (CEST)
Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14])
 by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 1665C1042
 for <dev@dpdk.org>; Mon,  3 Jun 2024 09:30:52 -0700 (PDT)
Received: from [10.1.36.170] (e132843.arm.com [10.1.36.170])
 by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 7074F3F64C
 for <dev@dpdk.org>; Mon,  3 Jun 2024 09:30:27 -0700 (PDT)
Message-ID: <ac22d048-9df6-407d-93e7-2c0616846ab5@foss.arm.com>
Date: Mon, 3 Jun 2024 17:30:25 +0100
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH 4/5] crypto/openssl: per-qp auth context clones
To: dev@dpdk.org
References: <20240603160119.1279476-1-jack.bond-preston@foss.arm.com>
 <20240603160119.1279476-5-jack.bond-preston@foss.arm.com>
Content-Language: en-GB
From: Jack Bond-Preston <jack.bond-preston@foss.arm.com>
In-Reply-To: <20240603160119.1279476-5-jack.bond-preston@foss.arm.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org

On 03/06/2024 17:01, Jack Bond-Preston wrote:
> diff --git a/drivers/crypto/openssl/openssl_pmd_private.h b/drivers/crypto/openssl/openssl_pmd_private.h
> index bad7dcf2f5..c3740ccc62 100644
> --- a/drivers/crypto/openssl/openssl_pmd_private.h
> +++ b/drivers/crypto/openssl/openssl_pmd_private.h
> @@ -80,6 +80,20 @@ struct __rte_cache_aligned openssl_qp {
>   	 */
>   };
>   
> +struct evp_ctx_pair {
> +	EVP_CIPHER_CTX *cipher;
> +	union {
> +		EVP_MD_CTX *auth;
> +#if OPENSSL_VERSION_NUMBER >= 0x30000000L
> +		EVP_MAC_CTX *hmac;
> +		EVP_MAC_CTX *cmac;
> +#else
> +		HMAC_CTX hmac;
> +		CMAC_CTX cmac;
> +#endif
> +	};
> +};
> +

HMAC_CTX and CMAC_CTX should be pointers, this is causing CI failures 
for older OpenSSL versions.