From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 65EB0A0559; Mon, 16 Mar 2020 14:38:57 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id EE0DA1C030; Mon, 16 Mar 2020 14:38:42 +0100 (CET) Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by dpdk.org (Postfix) with ESMTP id AA9771C02A for ; Mon, 16 Mar 2020 14:38:40 +0100 (CET) IronPort-SDR: xPOwFOBpZdaQK9lHeYKbt0XCJG+ZdsMk3CYgu9WNBScYxXZKfC9+3esgakwkkpmg+CHHtj2MWx 0Om6YGivSHmw== X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga007.jf.intel.com ([10.7.209.58]) by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 16 Mar 2020 06:38:40 -0700 IronPort-SDR: 3o7BzoUgrCFif/QEFxb2VCTUaiZ4RgL5JKk3FFOAJ6U7jFc+prDfHsOc9BMLs7/irJYCgOy6Dm PfPW9H/n4/iw== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.70,560,1574150400"; d="scan'208";a="233166928" Received: from silpixa00400072.ir.intel.com ([10.237.222.213]) by orsmga007.jf.intel.com with ESMTP; 16 Mar 2020 06:38:38 -0700 From: Vladimir Medvedkin To: dev@dpdk.org Cc: konstantin.ananyev@intel.com, yipeng1.wang@intel.com, sameh.gobriel@intel.com, bruce.richardson@intel.com Date: Mon, 16 Mar 2020 13:38:28 +0000 Message-Id: X-Mailer: git-send-email 2.7.4 In-Reply-To: References: In-Reply-To: References: Subject: [dpdk-dev] [PATCH 2/3] test: add dwk hash autotests X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Add autotests for rte_dwk_hash library Signed-off-by: Vladimir Medvedkin --- app/test/Makefile | 1 + app/test/meson.build | 1 + app/test/test_dwk_hash.c | 229 +++++++++++++++++++++++++++++++++++++++++++++++ 3 files changed, 231 insertions(+) create mode 100644 app/test/test_dwk_hash.c diff --git a/app/test/Makefile b/app/test/Makefile index 1f080d1..6f3a461 100644 --- a/app/test/Makefile +++ b/app/test/Makefile @@ -73,6 +73,7 @@ SRCS-y += test_bitmap.c SRCS-y += test_reciprocal_division.c SRCS-y += test_reciprocal_division_perf.c SRCS-y += test_fbarray.c +SRCS-y += test_dwk_hash.c SRCS-y += test_external_mem.c SRCS-y += test_rand_perf.c diff --git a/app/test/meson.build b/app/test/meson.build index 0a2ce71..2433be3 100644 --- a/app/test/meson.build +++ b/app/test/meson.build @@ -45,6 +45,7 @@ test_sources = files('commands.c', 'test_eventdev.c', 'test_external_mem.c', 'test_fbarray.c', + 'test_dwk_hash.c', 'test_fib.c', 'test_fib_perf.c', 'test_fib6.c', diff --git a/app/test/test_dwk_hash.c b/app/test/test_dwk_hash.c new file mode 100644 index 0000000..bf47331 --- /dev/null +++ b/app/test/test_dwk_hash.c @@ -0,0 +1,229 @@ +/* SPDX-License-Identifier: BSD-3-Clause + * Copyright(c) 2020 Intel Corporation + */ + +#include +#include +#include + +#include +#include +#include + +#include "test.h" + +typedef int32_t (*rte_dwk_hash_test)(void); + +static int32_t test_create_invalid(void); +static int32_t test_multiple_create(void); +static int32_t test_free_null(void); +static int32_t test_add_del_invalid(void); +static int32_t test_basic(void); + +#define MAX_ENT (1 << 22) + +/* + * Check that rte_dwk_hash_create fails gracefully for incorrect user input + * arguments + */ +int32_t +test_create_invalid(void) +{ + struct rte_dwk_hash_table *dwk_hash = NULL; + struct rte_dwk_hash_params config; + + /* rte_dwk_hash_create: dwk_hash name == NULL */ + config.name = NULL; + dwk_hash = rte_dwk_hash_create(&config); + RTE_TEST_ASSERT(dwk_hash == NULL, + "Call succeeded with invalid parameters\n"); + config.name = "test_dwk_hash"; + + /* rte_dwk_hash_create: config == NULL */ + dwk_hash = rte_dwk_hash_create(NULL); + RTE_TEST_ASSERT(dwk_hash == NULL, + "Call succeeded with invalid parameters\n"); + + /* socket_id < -1 is invalid */ + config.socket_id = -2; + dwk_hash = rte_dwk_hash_create(&config); + RTE_TEST_ASSERT(dwk_hash == NULL, + "Call succeeded with invalid parameters\n"); + config.socket_id = rte_socket_id(); + + /* rte_dwk_hash_create: entries = 0 */ + config.entries = 0; + dwk_hash = rte_dwk_hash_create(&config); + RTE_TEST_ASSERT(dwk_hash == NULL, + "Call succeeded with invalid parameters\n"); + config.entries = MAX_ENT; + + return TEST_SUCCESS; +} + +/* + * Create dwk_hash table then delete dwk_hash table 10 times + * Use a slightly different rules size each time + */ +#include +int32_t +test_multiple_create(void) +{ + struct rte_dwk_hash_table *dwk_hash = NULL; + struct rte_dwk_hash_params config; + int32_t i; + + + for (i = 0; i < 100; i++) { + config.name = "test_dwk_hash"; + config.socket_id = -1; + config.entries = MAX_ENT - i; + + dwk_hash = rte_dwk_hash_create(&config); + RTE_TEST_ASSERT(dwk_hash != NULL, + "Failed to create dwk hash\n"); + rte_dwk_hash_free(dwk_hash); + } + + return TEST_SUCCESS; +} + +/* + * Call rte_dwk_hash_free for NULL pointer user input. + * Note: free has no return and therefore it is impossible + * to check for failure but this test is added to + * increase function coverage metrics and to validate that + * freeing null does not crash. + */ +int32_t +test_free_null(void) +{ + struct rte_dwk_hash_table *dwk_hash = NULL; + struct rte_dwk_hash_params config; + + config.name = "test_dwk"; + config.socket_id = -1; + config.entries = MAX_ENT; + + dwk_hash = rte_dwk_hash_create(&config); + RTE_TEST_ASSERT(dwk_hash != NULL, "Failed to create dwk hash\n"); + + rte_dwk_hash_free(dwk_hash); + rte_dwk_hash_free(NULL); + return TEST_SUCCESS; +} + +/* + * Check that rte_dwk_hash_add fails gracefully for + * incorrect user input arguments + */ +int32_t +test_add_del_invalid(void) +{ + uint32_t key = 10; + uint64_t val = 20; + int ret; + + /* rte_dwk_hash_add: dwk_hash == NULL */ + ret = rte_dwk_hash_add(NULL, key, rte_hash_crc_4byte(key, 0), val); + RTE_TEST_ASSERT(ret == -EINVAL, + "Call succeeded with invalid parameters\n"); + + /* rte_dwk_hash_delete: dwk_hash == NULL */ + ret = rte_dwk_hash_delete(NULL, key, rte_hash_crc_4byte(key, 0)); + RTE_TEST_ASSERT(ret == -EINVAL, + "Call succeeded with invalid parameters\n"); + + return TEST_SUCCESS; +} + +/* + * Call add, lookup and delete for a single rule + */ +int32_t +test_basic(void) +{ + struct rte_dwk_hash_table *dwk_hash = NULL; + struct rte_dwk_hash_params config; + uint32_t key = 10; + uint64_t value = 20; + uint64_t ret_val = 0; + int ret; + + config.name = "test_dwk"; + config.socket_id = -1; + config.entries = MAX_ENT; + + dwk_hash = rte_dwk_hash_create(&config); + RTE_TEST_ASSERT(dwk_hash != NULL, "Failed to create dwk hash\n"); + + ret = rte_dwk_hash_lookup(dwk_hash, key, + rte_hash_crc_4byte(key, 0), &ret_val); + RTE_TEST_ASSERT(ret == -ENOENT, "Lookup return incorrect result\n"); + + ret = rte_dwk_hash_delete(dwk_hash, key, + rte_hash_crc_4byte(key, 0)); + RTE_TEST_ASSERT(ret == -ENOENT, "Delete return incorrect result\n"); + + ret = rte_dwk_hash_add(dwk_hash, key, + rte_hash_crc_4byte(key, 0), value); + RTE_TEST_ASSERT(ret == 0, "Can not add key into the table\n"); + + ret = rte_dwk_hash_lookup(dwk_hash, key, + rte_hash_crc_4byte(key, 0), &ret_val); + RTE_TEST_ASSERT(((ret == 0) && (value == ret_val)), + "Lookup return incorrect result\n"); + + ret = rte_dwk_hash_delete(dwk_hash, key, + rte_hash_crc_4byte(key, 0)); + RTE_TEST_ASSERT(ret == 0, "Can not delete key from table\n"); + + ret = rte_dwk_hash_lookup(dwk_hash, key, + rte_hash_crc_4byte(key, 0), &ret_val); + RTE_TEST_ASSERT(ret == -ENOENT, "Lookup return incorrect result\n"); + + rte_dwk_hash_free(dwk_hash); + + return TEST_SUCCESS; +} + +static struct unit_test_suite dwk_hash_tests = { + .suite_name = "dwk_hash autotest", + .setup = NULL, + .teardown = NULL, + .unit_test_cases = { + TEST_CASE(test_create_invalid), + TEST_CASE(test_free_null), + TEST_CASE(test_add_del_invalid), + TEST_CASE(test_basic), + TEST_CASES_END() + } +}; + +static struct unit_test_suite dwk_hash_slow_tests = { + .suite_name = "dwk_hash slow autotest", + .setup = NULL, + .teardown = NULL, + .unit_test_cases = { + TEST_CASE(test_multiple_create), + TEST_CASES_END() + } +}; + +/* + * Do all unit tests. + */ +static int +test_dwk_hash(void) +{ + return unit_test_suite_runner(&dwk_hash_tests); +} + +static int +test_slow_dwk_hash(void) +{ + return unit_test_suite_runner(&dwk_hash_slow_tests); +} + +REGISTER_TEST_COMMAND(dwk_hash_autotest, test_dwk_hash); +REGISTER_TEST_COMMAND(dwk_hash_slow_autotest, test_slow_dwk_hash); -- 2.7.4