Re: [RFC PATCH 00/29] cover letter for net/qdma PMD

[aman.kumar@vvdntech.in]

On 07/07/22 7:49 pm, Hemant Agrawal <hemant.agrawal@oss.nxp.com> wrote:
> 
> On 7/7/2022 7:45 PM, Thomas Monjalon wrote:
> > 07/07/2022 15:55, Aman Kumar:
> >> On 07/07/22 12:27 pm, Thomas Monjalon wrote:
> >>> 06/07/2022 09:51, Aman Kumar:
> >>>> This patch series provides net PMD for VVDN's NR(5G) Hi-PHY 
> >>>> solution over
> >>>> T1 telco card. These telco accelerator NIC cards are targeted for 
> >>>> ORAN DU
> >>>> systems to offload inline NR Hi-PHY (split 7.2) operations. For the 
> >>>> DU host,
> >>>> the cards typically appears as a basic NIC device. The device is 
> >>>> based on
> >>>> AMD/Xilinx's Ultrasale MPSoC and RFSoC FPGA for which the inline 
> >>>> Hi-PHY IP
> >>>> is developed by VVDN Technologies Private Limited.
> >>>> PCI_VENDOR: 0x1f44, Supported Devices: 0x0201, 0x0281
> >>>>
> >>>> Hardware-specs:
> >>>> https://www.xilinx.com/publications/product-briefs/xilinx-t1-product-brief.pdf 
> >>>>
> >>>>
> >>>> - This series is an RFC and target for DPDK v22.11.
> >>>> - Currently, the PMD is supported only for x86_64 host.
> >>>> - Build machine used: Fedora 36 with gcc 12.1.1
> >>>> - The device communicates to host over AMD/Xilinx's QDMA subsystem for
> >>>>     PCIe interface. Link: https://docs.xilinx.com/r/en-US/pg302-qdma
> >>> That's unfortunate, there is something else called QDMA in NXP 
> >>> solution:
> >>> https://git.dpdk.org/dpdk/tree/drivers/dma/dpaa2
> >> Is this going to create a conflict against this submission? I guess 
> >> both are publicly available/known for long time.
> > If it's the marketing name, go for it,
> > but it is unfortunate.
> 
> QDMA is a very generic name and many vendors have IP for it.
> 
> My suggestions is the qualify the specific driver with vendor name i.e. 
> amd_qdma or xilinx_qdma or something similar.
> 
> NXP also did the same dpaa2_qdma
> 
> 
@Thomas, @Hemant,
Thank you for highlights and suggestions regarding conflicting names.
We've discussed this internally and came up with below plan.

For v22.11 DPDK, we would like to submit patches with below renames:
 drivers/net/qdma -> drivers/net/t1
 drivers/net/qdma/qdma_*.c/h -> drivers/net/t1/t1_*.c/h
 driver/net/qdma/qdma_access -> driver/net/t1/base

We've plan to split Xilinx QDMA library to drivers/dma/xilinx_dma/* or into drivers/common/* around v23.02 as it require a big rework currently.
Also, currently no other devices are dependent on Xilinx QDMA, we would like to submit with "renamed" items as mentioned above under drivers/net/*.
We've a plan to submit a bbdev device too early next year and rework is planned before submitting that(post v22.11).
I'll update this in v2 patch. I hope this is OK.