From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 424D6A04B5; Wed, 30 Sep 2020 11:02:15 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 193051D5A9; Wed, 30 Sep 2020 11:02:14 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by dpdk.org (Postfix) with ESMTP id 2898A1D592 for ; Wed, 30 Sep 2020 11:02:12 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1601456530; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=wAsUWY6RBlrSCAZ3wFIiIHEMnKmdLbgIjPfPGLJqOJk=; b=K5HV4FEHn0COpraCeV8PTQ43I1nub7IiefAKiF9ADl48givJADgiCisar/NsDBNBIHB0ND A4GOSMPdT6Y82kZJv7eC+XGk0O+is38CbLKeH/3DB3u4JBIRg/7V5tNPHNR73k5V+QrU1e F5eqR4KCk5HUx/BzTbRlWXH19TVf758= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-25-HmTe-QRoPlyVSZn53tHQ4w-1; Wed, 30 Sep 2020 05:02:09 -0400 X-MC-Unique: HmTe-QRoPlyVSZn53tHQ4w-1 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 3B43F100A245; Wed, 30 Sep 2020 09:02:07 +0000 (UTC) Received: from [10.33.36.225] (unknown [10.33.36.225]) by smtp.corp.redhat.com (Postfix) with ESMTP id E0D7F5D9D2; Wed, 30 Sep 2020 09:02:00 +0000 (UTC) To: Thomas Monjalon , dev@dpdk.org, techboard@dpdk.org Cc: david.marchand@redhat.com, bruce.richardson@intel.com, Ray Kinsella , Neil Horman References: <20200624093627.2603992-1-thomas@monjalon.net> <20200928000049.3245920-1-thomas@monjalon.net> From: Kevin Traynor Autocrypt: addr=ktraynor@redhat.com; keydata= mQINBF2J2awBEADUEPNhgNI+nJNgiTAUcw4YIgVXEoHlsNPyyzG1BEXkWXALy0Y3fNTiw6+r ltWDkF9jzL9kfkecgQ67itGfk1OaBXgSGKuw1PUpxAwX2Bi76LAR6M5OsyGM9TSVVQwARalz hMwRBIZPzPc7or6Pw7jAOJ8SQGJ1Zlp1YJCjrvpe87V1tH/LY8Wnxn/EuoseFmWILAQZAtYS tGjcrAgYn3SPMLR1B0BP5bTBY06vWQjiufH8drenfDnMJAzuBdG1mqjnTqCjULZ3Hunv4xqZ aMnkvL/K5Tj1c12Oe4930EE53LrXIBUltRg5mBudSWHnC7twjH0082HH9f963Z/2UI63SFIT iUvRvAzJYytgy7XnWLQ0+goZBADKYfolOuC0H8VgCaux8u8KFF28Dy+N6TV2KI58jTlyg1Zu l7QwykZpnOkJFiy37Gfbu3YEOzO72cP/S7/A+zvuqkxi63jyEkd+FY99vLt/HN2MUZwRmKDw UPbLkmrs8WU01/POVsqDcfvz7vu2St8hqqTiSIdQGS2zyTKB2/DvPSM3jws3udkIYSuhn+X4 QBiV6lkVZ7DSE6a065gnAauAql+b32Eymy+xnG5jCt1tR+0Cp2VZYCR9OU2gmomUKBDoX/He pSgED01CqYPNjN+TddirwmQX7ep4DtXc8FWvv2g/pq9WZFQk2QARAQABtCNLZXZpbiBUcmF5 bm9yIDxrdHJheW5vckByZWRoYXQuY29tPokCTgQTAQgAOBYhBAoiOaH51tHF7VYtEI9CINER a+yJBQJdidmsAhsDBQsJCAcCBhUKCQgLAgQWAgMBAh4BAheAAAoJEI9CINERa+yJoxIP/3VF 2TIgW4ckxhRFCvFu/606bnvCPie88ake4uWVWMAWwcMc4fKEltRWRCpkSVOwgqoMHnyHxK5r kOKzx2CLJMX5TgTMfKzPuaBDHngHLUzl2DStpBzrod0cVg5TShdmmfjY61uxRJKz+DlSkwgJ riADdVF5PPosQXTkKSGf2ombpTGpx/pue9ocjnr3x4SDpRLlnooM6Jf/3Y3Ib4jX6HPEyWuY b+owIIk9y2nRRGPQ6jbqAhsrXd9V+77UL0QuGWloMuKMZFbNg8hbu7X5aFijAbfxj4YUgojS ba7gfGZQan8h32A9KGQWrmsCBc3j2GqEPsX0r05X7cn7WL6IOPgQJ5EiQ7PlazQYVLrvZg9B n0GKK0k6895mLG0ZZ5v/qajOPF52etSmvFD1WUPb4OqaHqGA9ZtMpaKFRt7Y6rpXqKNU1xzW F5KjbTPtTb9WF3An8dciVv+AYUI7totkZYkWvQtgss8lfaX3NKUvXLVxqK0z3dQyr7rF/tYz PneTKypSksjCgaEBLSrsRmM5zKfe7tSNF/fDntfIq/029Jtcw29TcWEP57peNu6TtejewQD9 sTI+oqiXvW2D5l7LNUDYG8eMJp2oT7I0ZSBRvwcbmjH0DtN/bXCCFfCvk8Yic68F3tV1ctix wQARVKDBhT30uCxycRWojCYqTgNJJS71uQINBF2J2awBEADP57PR2IpSYBeNSrsAjeIcsahE N4SQP2C4s50S8QEWAUhqMRI7WNv5cfeef0nDvcl1IUA6oz5SokbcsbMa+mRgaNF4N5KikWTO LPYxq2YVJoXwJ+tKmNzyOLFUIfFJ4NBJZple5dTfWzD00Dbb19Mri1hy1mWMqNTPGBee1+hw Qcp6n3mmGECvajs8G5A7NyXbwL8ihN7HX9D01ucD62b4G03yKe2g/hvKgcdUVmhCldJlF27I 2fSR9tDxH9pZqRODY4rjbFZEey/vWKXqjE+DQ8AtMSEaDfFe5D+i4Aw6erWQ3Wr+DwZt1/7G dIAElGA/q90T1ENVwJX9y7fsQssawKYYdDqURHCl5JuDXI+VXUypExipUUT5SPycMmbLsx0D iKEqPPDQWKxkIDVKqj2+EhamSuJznZUwBLJKn0h4zrIWiXWUy07lRwtVuhaDXhF3GfW+5W/x wAg7Qg3w00ASsb/XTHBIhMnenKDfS7ihtQA8SacwX8ySdxb+15XPyiplM979qBQ0mhnilulm MIJzEf/JxoYR5huuj4f1PFqqrsP06Dl+YGB7dQZp3IKggS5c3/TAynARRg9N89UsDXNtp7X0 tgIPFF5k6fnHE0J5O64GYHeTqN/1aE6dAEOV9WrGzQAJxU9ipikb8jKAWXzLewRIKGmoPcRZ WdB0NmIjmQARAQABiQI2BBgBCAAgFiEECiI5ofnW0cXtVi0Qj0Ig0RFr7IkFAl2J2awCGwwA CgkQj0Ig0RFr7IkkORAAl/NbX93WK5MEoRw7/DaPTo/Lo6Pj1XMeSqGyACigHK/452UDvlEH NjNJMzYYrNIjMtEmN9VVCfjT38CSca7mpGQVwchc0mC7QSPAETLCS+UacVf/Kwxz5FfkEUUw UT7A+uyVOIgW3d9ldlRzkHA2czonSSgTQU+i2g6DM4ha+BuQb4byAXH6HQHt/Zh1J64z0ohH v6iGsCzCY/sMWF8+LEGSnzMGRCLiiwSF0vJBHbzWK68fANaF4gBV0Z/+6tQRFN7YMhj/INmk qgvHj1ZzHFNtirjMGPRxoZs51YoLQM/aBPxKrnmXThx1ufH+0L6sGmFTugiDt0XSEkC5reH7 a+VhQ1VTFFQrClA8NmDSPzFeuhru4ryaaDHO+uEB16cNHxHrQtlP/2hts2JM5lwkZRWJ5A57 h8eDEIK5be47T85NVHfuTaboNRmgg1HygVejhGUtt69u/0MVRg/roUTa0FyEbNsvz4qAecyW yWzMcVrcGJDQLC9JLKEpoyUF6gdTKaiDL2Vao4+XRIA3Y57b6MO35a3HuzAv7+i5Z0mnDEJO XxXqTOmKYpMIGexzM/PtuA0712sT1abG9tAJ17ao/B7cqMW5IkKkalemFbWfI2unns4Papvo tk9igVqyp6EJDU98z5TJioCVojwK2laDaoIjTJk9YYv3iwCsqPd5feU= Message-ID: Date: Wed, 30 Sep 2020 10:01:59 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.11.0 MIME-Version: 1.0 In-Reply-To: <20200928000049.3245920-1-thomas@monjalon.net> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=ktraynor@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Subject: Re: [dpdk-dev] [dpdk-techboard] [PATCH v2] eal: simplify exit functions X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 28/09/2020 01:00, Thomas Monjalon wrote: > The option RTE_EAL_ALWAYS_PANIC_ON_ERROR was off by default, > and not customizable with meson. It is completely removed. > > The function rte_dump_registers is a trace of the bare metal support > era, and was not supported in userland. It is completely removed. > > Signed-off-by: Thomas Monjalon > Acked-by: Ray Kinsella > --- > The deprecation notice for this removal has been missed. > I assume it would not hurt anybody to remove this useless function > from DPDK 20.11. Asking the Technical Board for confirmation. > --- Acked-by: Kevin Traynor > app/test/test_debug.c | 3 --- > doc/guides/howto/debug_troubleshoot.rst | 2 +- > doc/guides/rel_notes/release_20_11.rst | 2 ++ > lib/librte_eal/common/eal_common_debug.c | 17 +---------------- > lib/librte_eal/include/rte_debug.h | 7 ------- > lib/librte_eal/rte_eal_version.map | 1 - > 6 files changed, 4 insertions(+), 28 deletions(-) > > diff --git a/app/test/test_debug.c b/app/test/test_debug.c > index 25eab97e2a..834a7386f5 100644 > --- a/app/test/test_debug.c > +++ b/app/test/test_debug.c > @@ -66,13 +66,11 @@ test_exit_val(int exit_val) > } > wait(&status); > printf("Child process status: %d\n", status); > -#ifndef RTE_EAL_ALWAYS_PANIC_ON_ERROR > if(!WIFEXITED(status) || WEXITSTATUS(status) != (uint8_t)exit_val){ > printf("Child process terminated with incorrect status (expected = %d)!\n", > exit_val); > return -1; > } > -#endif > return 0; > } > > @@ -113,7 +111,6 @@ static int > test_debug(void) > { > rte_dump_stack(); > - rte_dump_registers(); > if (test_panic() < 0) > return -1; > if (test_exit() < 0) > diff --git a/doc/guides/howto/debug_troubleshoot.rst b/doc/guides/howto/debug_troubleshoot.rst > index 5a46f5fba3..50bd32a8ef 100644 > --- a/doc/guides/howto/debug_troubleshoot.rst > +++ b/doc/guides/howto/debug_troubleshoot.rst > @@ -314,7 +314,7 @@ Custom worker function :numref:`dtg_distributor_worker`. > * For high-performance execution logic ensure running it on correct NUMA > and non-master core. > > - * Analyze run logic with ``rte_dump_stack``, ``rte_dump_registers`` and > + * Analyze run logic with ``rte_dump_stack`` and > ``rte_memdump`` for more insights. > > * Make use of objdump to ensure opcode is matching to the desired state. > diff --git a/doc/guides/rel_notes/release_20_11.rst b/doc/guides/rel_notes/release_20_11.rst > index f377ab8e87..c0b83e9554 100644 > --- a/doc/guides/rel_notes/release_20_11.rst > +++ b/doc/guides/rel_notes/release_20_11.rst > @@ -184,6 +184,8 @@ ABI Changes > Also, make sure to start the actual text at the margin. > ======================================================= > > +* eal: Removed the not implemented function ``rte_dump_registers()``. > + > * ``ethdev`` changes > > * Following device operation function pointers moved > diff --git a/lib/librte_eal/common/eal_common_debug.c b/lib/librte_eal/common/eal_common_debug.c > index 722468754d..15418e957f 100644 > --- a/lib/librte_eal/common/eal_common_debug.c > +++ b/lib/librte_eal/common/eal_common_debug.c > @@ -7,14 +7,6 @@ > #include > #include > > -/* not implemented */ > -void > -rte_dump_registers(void) > -{ > - return; > -} > - > -/* call abort(), it will generate a coredump if enabled */ > void > __rte_panic(const char *funcname, const char *format, ...) > { > @@ -25,8 +17,7 @@ __rte_panic(const char *funcname, const char *format, ...) > rte_vlog(RTE_LOG_CRIT, RTE_LOGTYPE_EAL, format, ap); > va_end(ap); > rte_dump_stack(); > - rte_dump_registers(); > - abort(); > + abort(); /* generate a coredump if enabled */ > } > > /* > @@ -46,14 +37,8 @@ rte_exit(int exit_code, const char *format, ...) > rte_vlog(RTE_LOG_CRIT, RTE_LOGTYPE_EAL, format, ap); > va_end(ap); > > -#ifndef RTE_EAL_ALWAYS_PANIC_ON_ERROR > if (rte_eal_cleanup() != 0) > RTE_LOG(CRIT, EAL, > "EAL could not release all resources\n"); > exit(exit_code); > -#else > - rte_dump_stack(); > - rte_dump_registers(); > - abort(); > -#endif > } > diff --git a/lib/librte_eal/include/rte_debug.h b/lib/librte_eal/include/rte_debug.h > index 50052c5a90..c4bc71ce28 100644 > --- a/lib/librte_eal/include/rte_debug.h > +++ b/lib/librte_eal/include/rte_debug.h > @@ -26,13 +26,6 @@ extern "C" { > */ > void rte_dump_stack(void); > > -/** > - * Dump the registers of the calling core to the console. > - * > - * Note: Not implemented in a userapp environment; use gdb instead. > - */ > -void rte_dump_registers(void); > - > /** > * Provide notification of a critical non-recoverable error and terminate > * execution abnormally. > diff --git a/lib/librte_eal/rte_eal_version.map b/lib/librte_eal/rte_eal_version.map > index c32461c663..cd1a90b95f 100644 > --- a/lib/librte_eal/rte_eal_version.map > +++ b/lib/librte_eal/rte_eal_version.map > @@ -38,7 +38,6 @@ DPDK_21 { > rte_devargs_remove; > rte_devargs_type_count; > rte_dump_physmem_layout; > - rte_dump_registers; > rte_dump_stack; > rte_dump_tailq; > rte_eal_alarm_cancel; >