From: Ferruh Yigit <ferruh.yigit@intel.com>
To: Shahed Shaikh <shshaikh@marvell.com>, dev@dpdk.org
Cc: stable@dpdk.org, Rasesh Mody <rmody@marvell.com>,
Thomas Monjalon <thomas@monjalon.net>
Subject: Re: [dpdk-dev] [PATCH 1/2] net/qede: fix performance bottleneck in Rx path
Date: Fri, 18 Jan 2019 14:41:29 +0000 [thread overview]
Message-ID: <ac3907ec-ebdc-ff85-f1a1-6bf595686556@intel.com> (raw)
In-Reply-To: <16a3812b-8a4d-ba41-d5f4-0f80dd932a4d@intel.com>
On 1/18/2019 2:41 PM, Ferruh Yigit wrote:
> On 1/18/2019 10:29 AM, Shahed Shaikh wrote:
>> Allocating replacement buffer per received packet is expensive.
>> Instead, process received packets first and allocate
>> replacement buffers in bulk later.
>>
>> This improves performance by ~25% in terms of PPS on AMD
>> platforms.
>>
>> Fixes: 2ea6f76aff40 ("qede: add core driver")
>> Cc: stable@dpdk.org
>>
>> Signed-off-by: Shahed Shaikh <shshaikh@marvell.com>
>
> Hi Shahed,
>
> This patch has been sent same day of the RC3, very close to the actual release,
> and updating data path of the driver, so not a trivial patch.
>
> Although I tend to accept driver patches late in process this one was too late,
> you won't have proper time to fix if any errors detected, but also I can see it
> has a good amount performance effect.
>
> I would like to explicitly ask if you are willing to take the risk. If answer is
> yes, please also be sure to get Rasesh's ack.
cc'ed Thomas.
next prev parent reply other threads:[~2019-01-18 14:41 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-18 10:29 Shahed Shaikh
2019-01-18 10:29 ` [dpdk-dev] [PATCH 2/2] net/qede: fix prefetch from incorrect place in Tx path Shahed Shaikh
2019-01-18 16:58 ` Rasesh Mody
2019-01-18 14:41 ` [dpdk-dev] [PATCH 1/2] net/qede: fix performance bottleneck in Rx path Ferruh Yigit
2019-01-18 14:41 ` Ferruh Yigit [this message]
2019-01-18 16:57 ` Rasesh Mody
2019-01-18 23:39 ` Thomas Monjalon
2019-01-18 16:13 Shahed Shaikh
2019-01-18 17:15 ` Rasesh Mody
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ac3907ec-ebdc-ff85-f1a1-6bf595686556@intel.com \
--to=ferruh.yigit@intel.com \
--cc=dev@dpdk.org \
--cc=rmody@marvell.com \
--cc=shshaikh@marvell.com \
--cc=stable@dpdk.org \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).