From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from rcdn-iport-8.cisco.com (rcdn-iport-8.cisco.com [173.37.86.79]) by dpdk.org (Postfix) with ESMTP id 35CEC6CD4 for ; Tue, 11 Oct 2016 11:25:47 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=cisco.com; i=@cisco.com; l=2307; q=dns/txt; s=iport; t=1476177947; x=1477387547; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=zxrtbxK2W+eWJpYEC4+f//sxW/IJc7/4XfxF5uIcTaY=; b=UDCgmhHC4MK/YiTMH/ZCDDu1plh+QqxeibS7k6mfM0CvhYU9DTyu69oR nLjBGi1/OKQsHm3WjXp/oAZyYidABfr3spKncSMsjH7CPVWmqAbTUpFJZ Dw74vIOq6MGTyZmj2NKd9A1Ez5eDvKWs6+rVdT5KRVgNoLmSiE2D+tT5s o=; X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: =?us-ascii?q?A0AdAQDbrvxX/4QNJK1cGQEBAQEBAQEBA?= =?us-ascii?q?QEBBwEBAQEBgzwBAQEBAR2BUweNLJcDkiWCD4ILhiACgXk4FAECAQEBAQEBAV4?= =?us-ascii?q?nhGEBAQEEJxM/DAQCAQgRBAEBAR4JBzIUCQgCBAENBQiISMJSAQEBAQEBAQEBA?= =?us-ascii?q?QEBAQEBAQEBAQEBHYY9hFWKJgEEmgIBj3WBdY4HhxCFaYN+AR42TYJxHBmBOnK?= =?us-ascii?q?HIoEAAQEB?= X-IronPort-AV: E=Sophos;i="5.31,476,1473120000"; d="scan'208";a="156623208" Received: from alln-core-10.cisco.com ([173.36.13.132]) by rcdn-iport-8.cisco.com with ESMTP/TLS/DHE-RSA-AES256-SHA; 11 Oct 2016 09:25:46 +0000 Received: from XCH-RCD-009.cisco.com (xch-rcd-009.cisco.com [173.37.102.19]) by alln-core-10.cisco.com (8.14.5/8.14.5) with ESMTP id u9B9Pkrl007946 (version=TLSv1/SSLv3 cipher=AES256-SHA bits=256 verify=FAIL); Tue, 11 Oct 2016 09:25:46 GMT Received: from xch-rcd-007.cisco.com (173.37.102.17) by XCH-RCD-009.cisco.com (173.37.102.19) with Microsoft SMTP Server (TLS) id 15.0.1210.3; Tue, 11 Oct 2016 04:25:45 -0500 Received: from xch-rcd-007.cisco.com ([173.37.102.17]) by XCH-RCD-007.cisco.com ([173.37.102.17]) with mapi id 15.00.1210.000; Tue, 11 Oct 2016 04:25:45 -0500 From: "John Daley (johndale)" To: Ferruh Yigit , "bruce.richardson@intel.com" CC: "dev@dpdk.org" Thread-Topic: [dpdk-dev] [PATCH 4/4] net/enic: extend fdir support for 1300 series adapters Thread-Index: AQHSGpQFAdzKa2aRl0SyrCLFoXPi4qCjYJKA//+swFA= Date: Tue, 11 Oct 2016 09:25:45 +0000 Message-ID: References: <20160929205639.1175-1-johndale@cisco.com> <20160929205639.1175-4-johndale@cisco.com> <2f02ca98-8250-0c27-7ae4-5e23839521d6@intel.com> In-Reply-To: <2f02ca98-8250-0c27-7ae4-5e23839521d6@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-exchange-transport-fromentityheader: Hosted x-originating-ip: [10.19.145.149] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH 4/4] net/enic: extend fdir support for 1300 series adapters X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 11 Oct 2016 09:25:47 -0000 > -----Original Message----- > From: Ferruh Yigit [mailto:ferruh.yigit@intel.com] > Sent: Tuesday, October 11, 2016 2:22 AM > To: John Daley (johndale) ; > bruce.richardson@intel.com > Cc: dev@dpdk.org > Subject: Re: [dpdk-dev] [PATCH 4/4] net/enic: extend fdir support for 130= 0 > series adapters >=20 > Hi John, >=20 > On 9/29/2016 9:56 PM, John Daley wrote: > > 1300 series Cisco adapter firmware version 2.0(13) for UCS C-series > > servers and 3.1(2) for blade servers supports more filtering > > capabilities. The feature can be enabled via Cisco CIMC or USCM with > > the 'advanced filters' radio button. When enabled, the these > > additional flow director modes are available: > > RTE_ETH_FLOW_NONFRAG_IPV4_OTHER > > RTE_ETH_FLOW_NONFRAG_IPV4_SCTP > > RTE_ETH_FLOW_NONFRAG_IPV6_UDP > > RTE_ETH_FLOW_NONFRAG_IPV6_TCP > > RTE_ETH_FLOW_NONFRAG_IPV6_SCTP > > RTE_ETH_FLOW_NONFRAG_IPV6_OTHER > > > > Changes: > > - Detect and set an 'advanced filters' flag dependent on the adapter > > capability. > > - Implement RTE_ETH_FILTER_INFO filter op to return the flow types > > available dependent on whether advanced filters are enabled. > > - Use a function pointer to select how filters are added to the adapter= : > > copy_fltr_v1() for older firmware/adapters or copy_fltr_v2() for > > adapters which support advanced filters. > > - Apply fdir global masks to filters when in advanced filter mode. > > - Update documentation. > > > > Signed-off-by: John Daley > > Reviewed-by: Nelson Escobar > > --- >=20 > <...> >=20 > > > > +void enic_fdir_info_get(struct enic *enic, struct rte_eth_fdir_info > > +*info) { > > + info->mode =3D enic->fdir.modes; >=20 > This cause a icc build error: > .../drivers/net/enic/enic_clsf.c(77): > error #188: enumerated type mixed with another type > info->mode =3D enic->fdir.modes; > ^ >=20 > Just casting to the enum fixes it: > + info->mode =3D (enum rte_fdir_mode)enic->fdir.modes; >=20 > Since the modification is trivial, if you agree with the change, we can a= pply it > without needing a new version of the patch? >=20 Looks good, thank you and sorry for the trouble. -john > <...>