DPDK patches and discussions
 help / color / mirror / Atom feed
From: Ferruh Yigit <ferruh.yigit@amd.com>
To: Stephen Hemminger <stephen@networkplumber.org>,
	Kaijun Zeng <corezeng@gmail.com>
Cc: dev@dpdk.org, stable@dpdk.org,
	Jochen Behrens <jbehrens@vmware.com>,
	Bruce Richardson <bruce.richardson@intel.com>
Subject: Re: [PATCH v2] net/vmxnet3: fix return code in initializing
Date: Wed, 7 Jun 2023 16:49:48 +0100	[thread overview]
Message-ID: <ac6fa6c7-c645-ae76-18f8-eae7f4d452b0@amd.com> (raw)
In-Reply-To: <20230606083612.6ee181d4@hermes.local>

On 6/6/2023 4:36 PM, Stephen Hemminger wrote:
> On Fri,  2 Jun 2023 12:44:38 -0400
> Kaijun Zeng <corezeng@gmail.com> wrote:
> 
>> +				PMD_INIT_LOG(ERR,
>> +					"ERROR: Zero descriptor requirement in Rx queue: %d,"
>> +					"buffers ring: %d\n",
>> +					i, j);
> 
> Please don't split messages across source lines, it makes harder for developers
> to use tools to scan source for message.
> 
> Often, when message is long, it means that there is redundant information or poor wording.
> For example, in your message "ERROR:" is redundant.
>

Agree that 'ERROR:' is redundant, and +1 to not split log message.

Kaijun,

Would you mind sending a new version with above changes?

Thanks,
ferruh


  reply	other threads:[~2023-06-07 15:49 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-05-28 14:37 [PATCH] drivers: fix vmxnet3 return wrong error " root
2023-06-01 15:12 ` Ferruh Yigit
2023-06-02 16:44 ` [PATCH v2] net/vmxnet3: fix return " Kaijun Zeng
2023-06-06  9:08   ` Ferruh Yigit
2023-06-06 15:36   ` Stephen Hemminger
2023-06-07 15:49     ` Ferruh Yigit [this message]
2023-06-07 17:57   ` [PATCH v3] " Kaijun Zeng
2023-06-09 18:08     ` Ferruh Yigit
2023-06-07 16:54 ` [PATCH] " Kaijun Zeng

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ac6fa6c7-c645-ae76-18f8-eae7f4d452b0@amd.com \
    --to=ferruh.yigit@amd.com \
    --cc=bruce.richardson@intel.com \
    --cc=corezeng@gmail.com \
    --cc=dev@dpdk.org \
    --cc=jbehrens@vmware.com \
    --cc=stable@dpdk.org \
    --cc=stephen@networkplumber.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).