From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <dev-bounces@dpdk.org> Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 1706F42C51; Wed, 7 Jun 2023 17:49:58 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 8D7DF410F6; Wed, 7 Jun 2023 17:49:57 +0200 (CEST) Received: from NAM02-DM3-obe.outbound.protection.outlook.com (mail-dm3nam02on2061.outbound.protection.outlook.com [40.107.95.61]) by mails.dpdk.org (Postfix) with ESMTP id C8C01410DD; Wed, 7 Jun 2023 17:49:55 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Ood611RAeRJyxpzcCYGShWDrN49p7hX3cx/ClRrVogJlZg7ngorlDRjuxUNwd/DugOexEWz9t7FbzULBlSanVjoXYJ4X71o3eaYr2Ihx+Yg/3N1zo5j12zCnsWe7po/wOcNJ2rm3LNt8RGTiFGeuMerV8g/FHeQZ14iX8ByVrcyfivx5kDCAtmzr9tVCUXba/5iWj5kZ6kYV0DkdWT7h2CEWPWYquYdwRYpeC9f1RQIEhR/unJFnuYECPB4jl9SxaqL3Ng65KphT3EsDdloRBtOhGfGO6YDEl1PnAd4AT/2lkJ+3F37grPx/Kn0lftYwulP+Wq8J671IFHy8D2M43Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=qTuN/8pWnJ7n1KQAgeYp/XVG63b0WoW8qwP3zROCvj8=; b=mo7XgPwj7tu4OSQFlOY4ZsTGf/LQbR0Kd8TDYUCQCYVukw4laY6vULzIEbl3/2gFLw4e43Sw5/ZjXJRmv97KfzJhCZmtAeTyTVYqcruM9pOP/azP982uIyctbMi5miskYcsNRkUoJYXZwq1FIRo+xeyq4K4PXDaIcInvLniB5lvVLaDvwWzQzZzJwmD0YodbUznur60DaxWxhkpDvsVDy182p05S060JJZH/ElGGGyomvTtiVcAI0thmF2gVdb259nDmYHyXTClrnSa+PuysH/iGEpO3tWMu8iZxI7GYPizw+vXekWKcQNKk4a/e+0WEd4Jzfuzee0fblJTLp6qhRQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=qTuN/8pWnJ7n1KQAgeYp/XVG63b0WoW8qwP3zROCvj8=; b=SgkkDio+Jd2CcprouTUuQ9PMYnrLUQ0oJk460lSj1TVwy8Ef9ae/yIO4sO3jmkOD2CoCB0+KtsK3jDzycrXviF6d5wion0eZwYszEO8gsRj7HYyT8fkHHqyIZ1P9G5Vzmv0ACtHFeuq/ix3wTrvO6/4k0MEomz+Uy5mXoKbdmy8= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; Received: from CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) by CH3PR12MB9147.namprd12.prod.outlook.com (2603:10b6:610:19a::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6455.33; Wed, 7 Jun 2023 15:49:53 +0000 Received: from CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::16e3:326c:5c2a:be42]) by CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::16e3:326c:5c2a:be42%3]) with mapi id 15.20.6455.037; Wed, 7 Jun 2023 15:49:53 +0000 Message-ID: <ac6fa6c7-c645-ae76-18f8-eae7f4d452b0@amd.com> Date: Wed, 7 Jun 2023 16:49:48 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.11.2 Subject: Re: [PATCH v2] net/vmxnet3: fix return code in initializing Content-Language: en-US To: Stephen Hemminger <stephen@networkplumber.org>, Kaijun Zeng <corezeng@gmail.com> Cc: dev@dpdk.org, stable@dpdk.org, Jochen Behrens <jbehrens@vmware.com>, Bruce Richardson <bruce.richardson@intel.com> References: <20230528143734.145326-1-user@sklga> <20230602164438.45939-1-corezeng@gmail.com> <20230606083612.6ee181d4@hermes.local> From: Ferruh Yigit <ferruh.yigit@amd.com> In-Reply-To: <20230606083612.6ee181d4@hermes.local> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: LO6P265CA0014.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:339::12) To CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CH2PR12MB4294:EE_|CH3PR12MB9147:EE_ X-MS-Office365-Filtering-Correlation-Id: 154b99af-caee-434e-cc73-08db676ed5a6 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: JRU2KkwGWfo4M8HQYTTxIfc2jxFMfcVx22eeUCZ2baVYQC2aD8/suAfOycdBOWCsvrnxmHELcQxdXzJKNxE+D7U/+AFQxEY7OKP9rjXnyMuuzxjTNwDQBY9UJ9y2JItXkJpZLX1CljCQbognUUbNgbJnsV3A8Nc/PsgL5ycf0qqfow9pxzmq3d97K/EHzsrlxFeKNug1t87BwMeuwE5wYrwUvWcwU5mGrW3NYykCGdsNL+jctMT48605xOQml92JXeR5xglqrfvJQu4iarVUp1je69IjEyfqrjU49rfxYi4A2IDDTneOLxXkkJ1ymc+kxiPe3IjR+7qZKkCPQrhxp35ZjUIa6N8Bxn/2VgIW9//KTRLvBOBTzbOCiZMnJXZ46ybMPpIS2slM53TpFEYimmrHoSpnLAGClImtVADQCrA6k61kzrzZ74WGlXjhNBTmUY1+AorDtvCkXcJT+LjQBPqnujKaFfTij8Q0P9reTXkfKwVFqJRA884o7h3WmL69FySAR3WHOh+7+rn7njFBL5A2p4FC/3PLc+t3HfVlZtfaTdYEbg99YAhZrcA4oQ7UQ/ksbWVLNJnEe52/WZhYmPV5pzxp7Li93auXCcuLYoClDUylpRj2eQBV/ceRIsWkExXVGOYJL9Kda9qaIEfN9g== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CH2PR12MB4294.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230028)(4636009)(366004)(346002)(376002)(136003)(39860400002)(396003)(451199021)(54906003)(110136005)(478600001)(316002)(8676002)(8936002)(41300700001)(38100700002)(66946007)(4326008)(66476007)(66556008)(2616005)(186003)(6486002)(6666004)(83380400001)(26005)(6512007)(6506007)(53546011)(31696002)(86362001)(44832011)(5660300002)(2906002)(4744005)(36756003)(31686004)(45980500001)(43740500002); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?MEZyZ0F5Q2pBOFpoeFJTRnJ0Yjc1NFJSRkVBdGY5bkZGejJxZUhBcFFJTHZG?= =?utf-8?B?UW1hMDJoZEUyOWpFTXJ1dll2aUJON0tKQjBUK2JRZjFRaUJtWDc1MjJTZW9I?= =?utf-8?B?SnduaFpLZnNZUTlHODR3bzNuL2l0ZW1JVDdyOS9YeFFoTFdkMnM5SUFXQ2Zi?= =?utf-8?B?OEJ3WHdNOW1sS0FybG5OVHE1NzdSZFM3bVVvVUZuelRWTzB0V21tLy9pTjVY?= =?utf-8?B?UUVjTW5oMGxFNzQ5KzhaN0QvempKeFFGOUt5SGZYdTluUUtxUFNxc1NYNFA4?= =?utf-8?B?OFU0aC83dXh4MzFjdFQ2eCtZWVk1c0lRU3F2SDlFYU41TVhRU0pldHVBVk9v?= =?utf-8?B?bmYwb0Y5dHo5eEUreUFuZ0FMVHhmQlo0V3VkamRCZnMzMHlUS1g4Snl3a21Y?= =?utf-8?B?SXRWUTJMUEE5QUdxbURDak5NMVI4ZUtGOGlCbjBsRlYrRHJaWWdER3RWOHJa?= =?utf-8?B?NkZSVlpTK0RUNFZlVnVUN3lSOC96QkQ3Tmd0ZmwwdHNieWxUaHR3cTFUdS96?= =?utf-8?B?emp2TEQrcmpTbWZ4UW54MHl4VTg4SFk0N0hUZXRFWHE3bENBNlZCYkNnTEhW?= =?utf-8?B?Z2dESjhuS3FwQWZISENWeWpUSkJHcHJVdXJlUTRLRFk4bW9sKzloMXNqRHI4?= =?utf-8?B?QmtjcXZuaTJmQVcveFBDVWxlb3F3QVlDQVhRcWZmTk00a2RGKzdKRHF4cnJX?= =?utf-8?B?aGlCNjBBMmp4R0pRMm8zdmZva28vNkVHd2tWWlNJWVgxdHEvaUU3QjJGS3Y5?= =?utf-8?B?c3dZR1d5d2JKWmhvd05PaXFWVWx0S3hXdjJ3KzJLWURtd0hETTcxdU9hZmRv?= =?utf-8?B?dmhaY1VqSWY2NnFyUnpKVE5hSkFUV3JkUFFoVk1ld01pdVprVXB1Z2hTaExy?= =?utf-8?B?Qkd3K0lEekVDZU44TzF2b0FwcG8rb3NoeDdIRjhyQTdoalZiM3FRaEN2VHV5?= =?utf-8?B?Zk94V1piZ04zL2xFRXhsaWd3MnZoS0djcExZLzZOMGNSZ2pqdGlmcHRWdWJw?= =?utf-8?B?dWxkWkR2aVpYbGlwc1FZT3FYMTVJNmFvS29SbFpmZFRwUXBmS1R4Mm1kUm5l?= =?utf-8?B?aXE0ZW4wdE1DbXdoWFpWYlhlNlFlNFZVK3h6djlxN0ZWcDhBckFla2UxTklQ?= =?utf-8?B?M0YrVWtrT1diM0RLenhLUmkwcG9POU5CVnZHRXZtYlpHSWFxRTNOejFSKzdW?= =?utf-8?B?T3BDeGxJVlBxeCtGa0FEL0xQRUFlMUJnNHdTczlmUHRheGtqZUo4NmFYUllB?= =?utf-8?B?RmgvOHRMdUZFeE16b0Q3SG9xRXVlQThQM1IxS3VnSTdESzlFaW52NnJGRHdx?= =?utf-8?B?UnhJUlNjcm5pZ0FUNlNRVTJHdlpiUTNSTU9MaE1TK1pHUlNwVUNLK3ZXVUl0?= =?utf-8?B?cGtpaUtVYnZQUWVJbkN6a21CalRMYlpZbi9UaHpXaHBnSmVMUzJtbU9kKzZi?= =?utf-8?B?VkVRL2wyTStsRDB4U2F2RWo5TTFpK1k1eE1XdVpTUjBMWFd1UUxKNWRoNnZo?= =?utf-8?B?SGJGemJBZ3F4MVA0QUhjaUs4dDlNb0ZSNmlhTFNMZkJzK2M5OElwUml3clVJ?= =?utf-8?B?Y0lKZjN6WXhPWlZlSEIwWEl3SFMvQ2FYL2dGV0RuZDN1V3poSFppZjhoOTdS?= =?utf-8?B?RVhyNHQ3c0Q2RWpBTVcvdVNPczVTQnh0TW51d1ViQUFrVHZPZldtdldoUjgz?= =?utf-8?B?b3BlcHRVZWtPWElCT2VXcHVFV25XZ0gybWRIR1U3VmYwYzl4QmhqNDZkSFp2?= =?utf-8?B?UzJGU2d2K2xTMUlDTHdyWWhEQXMxNDU3aWVPVjdGS2cwMFh0amtzR0pSTEpF?= =?utf-8?B?TUFUbXN4QW1zYmFob3R2WVdXQy8yRm13Z0hLTDREL3lheTN0M3VRVEY1dEti?= =?utf-8?B?Q0kzODVTalQyUHFuTEtzYVA2MGVHRVU0ZVJhcGNSVlQ1b0wwc2N5ZllubTRL?= =?utf-8?B?bVJwaDlna09OeXdQWjVKN09qZGp3UjlPNk5rSlZoeVAxUlBZOWhjd2dqTWdw?= =?utf-8?B?NGh4cjFQY3lGZXp0OFMxRGJOcFFNL3pRWDArYnZLZ045UStSVm9tb1JlcTFF?= =?utf-8?B?ZXFTQm9WbFlRMW8xa2U2Szd2YmhwOTlLVGg3dmR6aGpucHlJN2dsZWlPQTBn?= =?utf-8?Q?cN5d+DfXW/MY4ZhzxKLs7Ws4j?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: 154b99af-caee-434e-cc73-08db676ed5a6 X-MS-Exchange-CrossTenant-AuthSource: CH2PR12MB4294.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Jun 2023 15:49:53.5048 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: fXz7TytWLsDTcutmf9bs1jjJjnCn6voJSt0ZUDojc9zxtffvXL4ihD3OqGwCNBCR X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH3PR12MB9147 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://mails.dpdk.org/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://mails.dpdk.org/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://mails.dpdk.org/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> Errors-To: dev-bounces@dpdk.org On 6/6/2023 4:36 PM, Stephen Hemminger wrote: > On Fri, 2 Jun 2023 12:44:38 -0400 > Kaijun Zeng <corezeng@gmail.com> wrote: > >> + PMD_INIT_LOG(ERR, >> + "ERROR: Zero descriptor requirement in Rx queue: %d," >> + "buffers ring: %d\n", >> + i, j); > > Please don't split messages across source lines, it makes harder for developers > to use tools to scan source for message. > > Often, when message is long, it means that there is redundant information or poor wording. > For example, in your message "ERROR:" is redundant. > Agree that 'ERROR:' is redundant, and +1 to not split log message. Kaijun, Would you mind sending a new version with above changes? Thanks, ferruh