From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dispatch1-us1.ppe-hosted.com (dispatch1-us1.ppe-hosted.com [148.163.129.52]) by dpdk.org (Postfix) with ESMTP id 3FC101BC3E for ; Fri, 11 May 2018 10:11:29 +0200 (CEST) X-Virus-Scanned: Proofpoint Essentials engine Received: from webmail.solarflare.com (uk.solarflare.com [193.34.186.16]) (using TLSv1 with cipher ECDHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1-us1.ppe-hosted.com (Proofpoint Essentials ESMTP Server) with ESMTPS id C0B56940060; Fri, 11 May 2018 08:11:27 +0000 (UTC) Received: from [192.168.38.17] (84.52.114.114) by ukex01.SolarFlarecom.com (10.17.10.4) with Microsoft SMTP Server (TLS) id 15.0.1044.25; Fri, 11 May 2018 09:11:22 +0100 To: Andy Green , References: <152600304856.53146.9681482138854493833.stgit@localhost.localdomain> <152600317109.53146.6555330710274289069.stgit@localhost.localdomain> From: Andrew Rybchenko Message-ID: Date: Fri, 11 May 2018 11:11:19 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.7.0 MIME-Version: 1.0 In-Reply-To: <152600317109.53146.6555330710274289069.stgit@localhost.localdomain> Content-Language: en-GB X-Originating-IP: [84.52.114.114] X-ClientProxiedBy: ocex03.SolarFlarecom.com (10.20.40.36) To ukex01.SolarFlarecom.com (10.17.10.4) X-TM-AS-Product-Ver: SMEX-11.0.0.1191-8.100.1062-23836.003 X-TM-AS-Result: No--9.230300-0.000000-31 X-TM-AS-User-Approved-Sender: Yes X-TM-AS-User-Blocked-Sender: No X-MDID: 1526026288-P6zfsMNzne5D Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: 7bit X-Content-Filtered-By: Mailman/MimeDel 2.1.15 Subject: Re: [dpdk-dev] [PATCH v4 11/18] net/sfc: correct strncpy length X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 11 May 2018 08:11:29 -0000 On 05/11/2018 04:46 AM, Andy Green wrote: > Signed-off-by: Andy Green > --- > drivers/net/sfc/sfc_ethdev.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/net/sfc/sfc_ethdev.c b/drivers/net/sfc/sfc_ethdev.c > index e42d55350..ef5e9ecb2 100644 > --- a/drivers/net/sfc/sfc_ethdev.c > +++ b/drivers/net/sfc/sfc_ethdev.c > @@ -13,6 +13,7 @@ > #include > #include > #include > +#include > > #include "efx.h" > > @@ -741,9 +742,8 @@ sfc_xstats_get_names_by_id(struct rte_eth_dev *dev, > if ((ids == NULL) || (ids[nb_written] == nb_supported)) { > char *name = xstats_names[nb_written++].name; > > - strncpy(name, efx_mac_stat_name(sa->nic, i), > + strlcpy(name, efx_mac_stat_name(sa->nic, i), > sizeof(xstats_names[0].name)); > - name[sizeof(xstats_names[0].name) - 1] = '\0'; > } > > ++nb_supported; > Acked-by: Andrew Rybchenko