From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id F3EE245500; Wed, 26 Jun 2024 13:58:57 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id C45B4433A8; Wed, 26 Jun 2024 13:55:42 +0200 (CEST) Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.9]) by mails.dpdk.org (Postfix) with ESMTP id 1609C42E95 for ; Wed, 26 Jun 2024 13:43:59 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1719402240; x=1750938240; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=ODdtBF0ea+904JNBoq0QmRqvhnVDFHxqAPfmMVAA9y8=; b=Doajb+dyo5Q8g97eXr9+xYE7eayP2ajvhzqV+cOoOf3hklVhxxCB0/1Q urhO05H4Z3bIZYAkG3Ymli7HY829qv/o9UV9ZKxKBv2GeeN0Acbl35gHD YvS54KYxHAwDTUyKgFKgKWMxuWpJTxMMRt8VptJwkduPSzaQL2Cu5bTec +ZD6hiRuA21RrG6AHejAsfNUoII/rFqWX0qURIO6J8Vz8H2rCEngEhdFa QgWIBltbOLbkACFxmYBqn78qA21gDB/wPDRwhBQh1C+gSJ00Q+rlOcbNN qTtNUXxoWqJC6fHO89iesyWrU0aRHFO+qLiyXITEgghTXpVf6DV2+FmSL w==; X-CSE-ConnectionGUID: KpI2RjH0RO+eGZve5Wx7Wg== X-CSE-MsgGUID: Gw+YNG9dRDWlcXVzCcwRCw== X-IronPort-AV: E=McAfee;i="6700,10204,11114"; a="38979389" X-IronPort-AV: E=Sophos;i="6.08,266,1712646000"; d="scan'208";a="38979389" Received: from orviesa010.jf.intel.com ([10.64.159.150]) by orvoesa101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 26 Jun 2024 04:43:59 -0700 X-CSE-ConnectionGUID: e6YdtSz/RTSU+hd9lORw+g== X-CSE-MsgGUID: 3HQkprkdSXOAbUQpkfVxsA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.08,266,1712646000"; d="scan'208";a="43873720" Received: from unknown (HELO silpixa00401119.ir.intel.com) ([10.55.129.167]) by orviesa010.jf.intel.com with ESMTP; 26 Jun 2024 04:43:58 -0700 From: Anatoly Burakov To: dev@dpdk.org Cc: Jacob Keller , ian.stokes@intel.com, bruce.richardson@intel.com Subject: [PATCH v4 035/103] net/ice/base: be more verbose when preparing timer sync Date: Wed, 26 Jun 2024 12:41:23 +0100 Message-ID: X-Mailer: git-send-email 2.43.0 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org From: Jacob Keller Add an informative error message when preparing external PHYs for a timer sync fails. Signed-off-by: Jacob Keller Signed-off-by: Anatoly Burakov --- drivers/net/ice/base/ice_ptp_hw.c | 11 +++++++++-- 1 file changed, 9 insertions(+), 2 deletions(-) diff --git a/drivers/net/ice/base/ice_ptp_hw.c b/drivers/net/ice/base/ice_ptp_hw.c index fa9be98444..5037feee18 100644 --- a/drivers/net/ice/base/ice_ptp_hw.c +++ b/drivers/net/ice/base/ice_ptp_hw.c @@ -4834,9 +4834,16 @@ int ice_ptp_port_cmd_e810(struct ice_hw *hw, enum ice_ptp_tmr_cmd cmd, bool lock_sbq) { u32 val = ice_ptp_tmr_cmd_to_port_reg(hw, cmd); + int err; - return ice_write_phy_reg_e810_lp(hw, E810_ETH_GLTSYN_CMD, val, - lock_sbq); + err = ice_write_phy_reg_e810_lp(hw, E810_ETH_GLTSYN_CMD, val, + lock_sbq); + if (err) { + ice_debug(hw, ICE_DBG_PTP, "Failed to write back GLTSYN_CMD, err %d\n", err); + return err; + } + + return 0; } /* E810T SMA functions -- 2.43.0