From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from alln-iport-6.cisco.com (alln-iport-6.cisco.com [173.37.142.93]) by dpdk.org (Postfix) with ESMTP id DFA6DFAB6; Thu, 9 Feb 2017 18:44:01 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=cisco.com; i=@cisco.com; l=1115; q=dns/txt; s=iport; t=1486662242; x=1487871842; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=hCpub1+oiw8PumCuvEkI+uLzfxYqWaSg3Wyhx7gaza4=; b=eop2PazjzGqrGA7PHTvHyu+FfgdDyZc8mTgNtSqVGUNqYvOMGwnozS/0 N/GzwBq7h3nCXm+jlxUJBOtWO8BWXvPpgObkErA/RdBXBWneMZrbC0Ybq 6lfU/xCFIGPse/+ATiy3swm/fqLGqBPQ8yAovmgR1n8Sksd2K9neHjHvU Q=; X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: =?us-ascii?q?A0ATAQALqpxY/4ENJK1dGQEBAQEBAQEBA?= =?us-ascii?q?QEBBwEBAQEBg1FhgQkHjVqSCZMngg+CDCqFeAKCaz8YAQIBAQEBAQEBYiiEaQE?= =?us-ascii?q?BAQQnEz8MBAIBCBEEAQEBHgkHMhQJCAIEDgUIAYlrDrF7OotSAQEBAQEBAQEBA?= =?us-ascii?q?QEBAQEBAQEBAQEBHYZMhG+KOQWbcAGGbIscgleON5MSAR84fk8Vhn51h3KBDAE?= =?us-ascii?q?BAQ?= X-IronPort-AV: E=Sophos;i="5.35,137,1484006400"; d="scan'208";a="383618782" Received: from alln-core-9.cisco.com ([173.36.13.129]) by alln-iport-6.cisco.com with ESMTP/TLS/DHE-RSA-AES256-SHA; 09 Feb 2017 17:44:00 +0000 Received: from XCH-RCD-008.cisco.com (xch-rcd-008.cisco.com [173.37.102.18]) by alln-core-9.cisco.com (8.14.5/8.14.5) with ESMTP id v19Hi0jE022353 (version=TLSv1/SSLv3 cipher=AES256-SHA bits=256 verify=FAIL); Thu, 9 Feb 2017 17:44:00 GMT Received: from xch-rcd-007.cisco.com (173.37.102.17) by XCH-RCD-008.cisco.com (173.37.102.18) with Microsoft SMTP Server (TLS) id 15.0.1210.3; Thu, 9 Feb 2017 11:43:59 -0600 Received: from xch-rcd-007.cisco.com ([173.37.102.17]) by XCH-RCD-007.cisco.com ([173.37.102.17]) with mapi id 15.00.1210.000; Thu, 9 Feb 2017 11:43:59 -0600 From: "John Daley (johndale)" To: Ferruh Yigit CC: "dev@dpdk.org" , "stable@dpdk.org" Thread-Topic: [PATCH v2] net/enic: fix hardcoding of some flow director masks Thread-Index: AQHSgm0Vl6Mo6Fhp+ka3pPyVpLogb6Fg2tSAgAAU6YA= Date: Thu, 9 Feb 2017 17:43:59 +0000 Message-ID: References: <20170203095446.4614-1-johndale@cisco.com> <20170209004009.26242-1-johndale@cisco.com> <20170209004009.26242-2-johndale@cisco.com> <9bb15b91-a7a1-1bb7-478b-6b225b64b84d@intel.com> In-Reply-To: <9bb15b91-a7a1-1bb7-478b-6b225b64b84d@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-exchange-transport-fromentityheader: Hosted x-originating-ip: [10.155.166.71] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v2] net/enic: fix hardcoding of some flow director masks X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 09 Feb 2017 17:44:02 -0000 > -----Original Message----- > From: Ferruh Yigit [mailto:ferruh.yigit@intel.com] > Sent: Thursday, February 09, 2017 2:16 AM > To: John Daley (johndale) > Cc: dev@dpdk.org; stable@dpdk.org > Subject: Re: [PATCH v2] net/enic: fix hardcoding of some flow director ma= sks >=20 > On 2/9/2017 12:40 AM, John Daley wrote: > > Hard coded mask values were being used for several of the IPv4 and > > IPv6 fields. Use the values in the rte_eth_fdir_masks structure > > provided by the caller. > > > > Fixes: dfbd6a9cb504 ("net/enic: extend flow director support for 1300 > > series") > > > > Cc: stable@dpdk.org > > Signed-off-by: John Daley > > --- > > > > v2: fix compile error >=20 > I wasn't getting an error for this. >=20 > V2 adds: >=20 > - ipv6_val.vtc_flow =3D input->flow.ipv6_flow.tc << 16; > + ipv6_val.vtc_flow =3D input->flow.ipv6_flow.tc << 12; >=20 > What is the compile error this fixes? This patch had the compile error: http://www.dpdk.org/dev/patchwork/patch/20147/ + ipv6_mask.vtc_flow =3D masks->ipv6_mask.tc << 16);