From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from nbfkord-smmo01.seg.att.com (nbfkord-smmo01.seg.att.com [209.65.160.76]) by dpdk.org (Postfix) with ESMTP id 9CBE05424 for ; Wed, 29 Mar 2017 18:38:15 +0200 (CEST) Received: from unknown [193.34.186.16] (EHLO webmail.solarflare.com) by nbfkord-smmo01.seg.att.com(mxl_mta-7.2.4-7) with ESMTP id 7f2ebd85.2ad2a48ac940.62909.00-2484.151207.nbfkord-smmo01.seg.att.com (envelope-from ); Wed, 29 Mar 2017 16:38:15 +0000 (UTC) X-MXL-Hash: 58dbe2f76c3376f6-04ea30600eca09a06655ba8de648c5f0ad51cfc9 Received: from unknown [193.34.186.16] (EHLO webmail.solarflare.com) by nbfkord-smmo01.seg.att.com(mxl_mta-7.2.4-7) over TLS secured channel with ESMTP id ee2ebd85.0.62905.00-2383.151193.nbfkord-smmo01.seg.att.com (envelope-from ); Wed, 29 Mar 2017 16:38:07 +0000 (UTC) X-MXL-Hash: 58dbe2ef0117fe22-93266c18d86d6a2bcc707ba0156e17dde7248828 Received: from [192.168.38.17] (84.52.89.52) by ukex01.SolarFlarecom.com (10.17.10.4) with Microsoft SMTP Server (TLS) id 15.0.1044.25; Wed, 29 Mar 2017 17:38:02 +0100 To: Ferruh Yigit , References: <1490800132-1833-1-git-send-email-arybchenko@solarflare.com> <4a22c344-fc76-e3de-f1c2-4f96e51c86b4@intel.com> From: Andrew Rybchenko Message-ID: Date: Wed, 29 Mar 2017 19:37:48 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.8.0 MIME-Version: 1.0 In-Reply-To: <4a22c344-fc76-e3de-f1c2-4f96e51c86b4@intel.com> X-Originating-IP: [84.52.89.52] X-ClientProxiedBy: ocex03.SolarFlarecom.com (10.20.40.36) To ukex01.SolarFlarecom.com (10.17.10.4) X-TM-AS-Product-Ver: SMEX-11.0.0.1191-8.100.1062-22970.003 X-TM-AS-Result: No--15.174000-0.000000-31 X-TM-AS-User-Approved-Sender: Yes X-TM-AS-User-Blocked-Sender: No X-AnalysisOut: [v=2.1 cv=LtyUvypc c=1 sm=1 tr=0 a=8P+NB+fYZDP74ap4g4d9Kw==] X-AnalysisOut: [:17 a=RB3BGLmKESwA:10 a=6Iz7jQTuP9IA:10 a=zRKbQ67AAAAA:8 a] X-AnalysisOut: [=D3J6YT9-KE2BeTeCCL0A:9 a=pILNOxqGKmIA:10 a=QyXUC8HyAAAA:8] X-AnalysisOut: [ a=KBCoSkm5bQb-KUretCgA:9 a=bRD4d-oEcMFL-6qh:21 a=_W_S_7Ve] X-AnalysisOut: [coQA:10 a=PA03WX8tBzeizutn5_OT:22 a=avl4LiGQNoF5OB0DmCJ7:2] X-AnalysisOut: [2] X-Spam: [F=0.2000000000; CM=0.500; S=0.200(2015072901)] X-MAIL-FROM: X-SOURCE-IP: [193.34.186.16] Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 7bit X-Content-Filtered-By: Mailman/MimeDel 2.1.15 Subject: Re: [dpdk-dev] [PATCH] net/sfc: fix crash on Tx queue release X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 29 Mar 2017 16:38:16 -0000 On 03/29/2017 07:25 PM, Ferruh Yigit wrote: > On 3/29/2017 4:08 PM, Andrew Rybchenko wrote: >> Datapath TxQ handle is passed to release function, not control path. >> >> Fixes: 5808dbaf751f ("net/sfc: factor out libefx-based Tx datapath") >> >> Signed-off-by: Andrew Rybchenko >> --- >> Please, squash the patch into 5808dbaf751f. > Hi Andrew, Hi Ferruh, > To clarify, for the commits in next-net tree that are not merged yet, we > can benefit from sub-tree re-writable option and squash some fixes, > -without over using it. Yes, it is perfectly clear. > But for this patch, as far as I can see, original code added with > commit: b1b7ad933b39 ("net/sfc: set up and release Tx queues") > which is part of v17.02 release. If we take a look a lines, yes, these lines belong to b1b7ad933b39 ("net/sfc: set up and release Tx queues") however the breakage is introduced by 19f92f3ec37c ("net/sfc: factor out libefx-based Tx datapath") since it registers pointer to the so-called datapath Tx queue in the device data instead of previous used control path Tx queue pointer. > So, please send a patch with correct fixes line and it won't be squashed. Correct fixes line for the patch with current dpdk-next-net is: Fixes: 19f92f3ec37c ("net/sfc: factor out libefx-based Tx datapath") which is in dpdk-next-net tree only. Should I resend it? Thanks, Andrew.