From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by dpdk.org (Postfix) with ESMTP id 95999F11 for ; Wed, 29 Aug 2018 10:56:31 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by fmsmga104.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 29 Aug 2018 01:56:29 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.53,301,1531810800"; d="scan'208";a="76434227" Received: from dhunt5-mobl2.ger.corp.intel.com (HELO [10.237.221.37]) ([10.237.221.37]) by FMSMGA003.fm.intel.com with ESMTP; 29 Aug 2018 01:56:13 -0700 To: Stephen Hemminger , dev@dpdk.org References: <20180813154755.6313-1-stephen@networkplumber.org> From: "Hunt, David" Message-ID: Date: Wed, 29 Aug 2018 09:56:12 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <20180813154755.6313-1-stephen@networkplumber.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-US Subject: Re: [dpdk-dev] [PATCH] checkpatches: don't assume bash syntax X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 29 Aug 2018 08:56:32 -0000 Hi Stephen, On 13/8/2018 4:47 PM, Stephen Hemminger wrote: > The read -d option is a bash extension and not avaiable in other > shells. On Debian, /bin/sh is dash and checktpatches would > fail with: > ./devtools/checkpatches.sh: 52: read: Illegal option -d > > Fix by using awk -e and adding necessary double backslash. > > Fixes: 7413e7f2aeb3 ("devtools: alert on new calls to exit from libs") > Signed-off-by: Stephen Hemminger --snip-- The flavour of awk that's installed by default on Ubuntu is 'mawk' which does not seem to have a '-e' option. However, for anyone tryung to run checkpatch on Ubuntu with this patch, the quickest workaround is to install 'gawk', which does have the -e option, then this patch works great. Rgds, Dave.