From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by dpdk.org (Postfix) with ESMTP id 6B1D41BA47 for ; Wed, 25 Oct 2017 20:15:18 +0200 (CEST) Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by fmsmga103.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 25 Oct 2017 11:15:17 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.43,432,1503385200"; d="scan'208";a="167549336" Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.241.225.45]) ([10.241.225.45]) by fmsmga006.fm.intel.com with ESMTP; 25 Oct 2017 11:15:17 -0700 From: Ferruh Yigit To: Olivier Matz , dev@dpdk.org Cc: thomas@monjalon.net References: <20171023121623.27466-1-olivier.matz@6wind.com> <20171025151257.16459-1-olivier.matz@6wind.com> <4ae4cbe7-1ba9-90a2-c072-51f9ecb66e2d@intel.com> Message-ID: Date: Wed, 25 Oct 2017 11:15:17 -0700 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.4.0 MIME-Version: 1.0 In-Reply-To: <4ae4cbe7-1ba9-90a2-c072-51f9ecb66e2d@intel.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH v2] mbuf: rename deprecated VLAN flags X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 25 Oct 2017 18:15:18 -0000 On 10/25/2017 10:42 AM, Ferruh Yigit wrote: > On 10/25/2017 8:12 AM, Olivier Matz wrote: >> PKT_RX_VLAN_PKT and PKT_RX_QINQ_PKT are deprecated for a while. >> As explained in [1], these flags were kept to let the applications and >> PMDs move to the new flag. There is also a need to support Rx vlan >> offload without vlan strip (at least for the ixgbe driver). >> >> This patch renames the old flags for this feature, knowing that some >> PMDs were using PKT_RX_VLAN_PKT and PKT_RX_QINQ_PKT to indicate that >> the vlan tci has been saved in the mbuf structure. >> >> It is likely that some PMDs do not set the proper flags when doing vlan >> offload, and it would be worth making a pass on all of them. >> >> Link: [1] http://dpdk.org/ml/archives/dev/2017-June/067712.html >> Signed-off-by: Olivier Matz > > Reviewed-by: Ferruh Yigit Applied to dpdk-next-net/master, thanks. It may be good to stress this change in -rc2 announcement and ask for testing.