* [dpdk-dev] [PATCH v2] examples/qos_sched: fix copy-paste error
@ 2016-04-21 11:48 Michal Jastrzebski
0 siblings, 0 replies; 2+ messages in thread
From: Michal Jastrzebski @ 2016-04-21 11:48 UTC (permalink / raw)
To: cristian.dumitrescu, roy.fan.zhang, jasvinder.singh
Cc: dev, Slawomir Mrozowicz
Fix issue reported by Coverity.
Date: Thu, 21 Apr 2016 13:47:34 +0200
Message-Id: <1461239256-8104-3-git-send-email-michalx.k.jastrzebski@intel.com>
X-Mailer: git-send-email 2.7.0
In-Reply-To: <1461239256-8104-1-git-send-email-michalx.k.jastrzebski@intel.com>
References: <1461239256-8104-1-git-send-email-michalx.k.jastrzebski@intel.com>
From: Slawomir Mrozowicz <slawomirx.mrozowicz@intel.com>
Coverity ID 30699: Copy-paste error;
rx_port in pconf->rx_port looks like a copy-paste error.
Fixes: de3cfa2c9823 ("sched: initial import")
Signed-off-by: Slawomir Mrozowicz <slawomirx.mrozowicz@intel.com>
---
examples/qos_sched/args.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/examples/qos_sched/args.c b/examples/qos_sched/args.c
index 3e7fd08..1916790 100644
--- a/examples/qos_sched/args.c
+++ b/examples/qos_sched/args.c
@@ -270,7 +270,7 @@ app_parse_flow_conf(const char *conf_str)
}
if (pconf->tx_port >= RTE_MAX_ETHPORTS) {
RTE_LOG(ERR, APP, "pfc %u: invalid tx port %"PRIu8" index\n",
- nb_pfc, pconf->rx_port);
+ nb_pfc, pconf->tx_port);
return -1;
}
--
1.9.1
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [dpdk-dev] [PATCH v2] examples/qos_sched: fix copy-paste error
[not found] ` <1461239256-8104-3-git-send-email-michalx.k.jastrzebski@intel.com>
@ 2016-04-28 10:58 ` Dumitrescu, Cristian
0 siblings, 0 replies; 2+ messages in thread
From: Dumitrescu, Cristian @ 2016-04-28 10:58 UTC (permalink / raw)
To: Jastrzebski, MichalX K, Zhang, Roy Fan, Singh, Jasvinder
Cc: dev, Mrozowicz, SlawomirX
> -----Original Message-----
> From: Jastrzebski, MichalX K
> Sent: Thursday, April 21, 2016 12:48 PM
> To: Dumitrescu, Cristian <cristian.dumitrescu@intel.com>; Zhang, Roy Fan
> <roy.fan.zhang@intel.com>; Singh, Jasvinder <jasvinder.singh@intel.com>
> Cc: dev@dpdk.org; Mrozowicz, SlawomirX
> <slawomirx.mrozowicz@intel.com>
> Subject: [PATCH v2] examples/qos_sched: fix copy-paste error
>
> From: Slawomir Mrozowicz <slawomirx.mrozowicz@intel.com>
>
> Coverity ID 30699: Copy-paste error;
> rx_port in pconf->rx_port looks like a copy-paste error.
>
> Fixes: de3cfa2c9823 ("sched: initial import")
>
> Signed-off-by: Slawomir Mrozowicz <slawomirx.mrozowicz@intel.com>
> ---
> examples/qos_sched/args.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/examples/qos_sched/args.c b/examples/qos_sched/args.c
> index 3e7fd08..1916790 100644
> --- a/examples/qos_sched/args.c
> +++ b/examples/qos_sched/args.c
> @@ -270,7 +270,7 @@ app_parse_flow_conf(const char *conf_str)
> }
> if (pconf->tx_port >= RTE_MAX_ETHPORTS) {
> RTE_LOG(ERR, APP, "pfc %u: invalid tx port %"PRIu8"
> index\n",
> - nb_pfc, pconf->rx_port);
> + nb_pfc, pconf->tx_port);
> return -1;
> }
>
> --
> 1.9.1
Acked-by: Cristian Dumitrescu <cristian.dumitrescu@intel.com>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2016-04-28 10:58 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-04-21 11:48 [dpdk-dev] [PATCH v2] examples/qos_sched: fix copy-paste error Michal Jastrzebski
-- strict thread matches above, loose matches on Subject: below --
2016-04-21 11:47 [dpdk-dev] [PATCH v2] examples/qos_meter: fix unchecked return value Michal Jastrzebski
[not found] ` <1461239256-8104-3-git-send-email-michalx.k.jastrzebski@intel.com>
2016-04-28 10:58 ` [dpdk-dev] [PATCH v2] examples/qos_sched: fix copy-paste error Dumitrescu, Cristian
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).