From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 1969DA0C4C; Tue, 12 Oct 2021 21:48:36 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 064EC410EA; Tue, 12 Oct 2021 21:48:36 +0200 (CEST) Received: from shelob.oktetlabs.ru (shelob.oktetlabs.ru [91.220.146.113]) by mails.dpdk.org (Postfix) with ESMTP id CC02A410E7 for ; Tue, 12 Oct 2021 21:48:34 +0200 (CEST) Received: from [100.65.5.102] (unknown [5.144.123.2]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by shelob.oktetlabs.ru (Postfix) with ESMTPSA id 5F9127F530; Tue, 12 Oct 2021 22:48:34 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 shelob.oktetlabs.ru 5F9127F530 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=oktetlabs.ru; s=default; t=1634068114; bh=BXVIJtnHhoMegL0o1AcPyAu5lrZ0UAU/Hbj0UTh4w44=; h=Subject:To:Cc:References:From:Date:In-Reply-To; b=wYaBp3F75vRn04xejCY/NE2WMVQwRXzQtSmbgolAX2KDIlf/h2bcxQsqobyQRE5L9 bSYUm5ztPnlcT9mfHSTkucJfFnETK78L0SYHGbXiKbAi/iYyNGwsZn9DE3k1sv5m4P bRLFVhrFEKMC1YUWj6COECF4Vp6vQArf0vE3spNU= To: Ferruh Yigit , dev@dpdk.org Cc: Ray Kinsella , Jerin Jacob , Thomas Monjalon , Ori Kam , Ajit Khaparde , Andrew Rybchenko , Andy Moreton References: <20210923112012.14595-1-ivan.malov@oktetlabs.ru> <20211005155639.12277-1-ivan.malov@oktetlabs.ru> <20211005155639.12277-6-ivan.malov@oktetlabs.ru> From: Ivan Malov Message-ID: Date: Tue, 12 Oct 2021 22:48:27 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.14.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit Subject: Re: [dpdk-dev] [PATCH v5 5/5] net/sfc: report user flag on EF100 native datapath X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi Ferruh, I apologise: there was a defect in v6. I re-submitted the series (v7): https://patches.dpdk.org/project/dpdk/list/?series=19571 Thank you. On 12/10/2021 21:08, Ferruh Yigit wrote: > On 10/5/2021 4:56 PM, Ivan Malov wrote: >> Detect the flag in Rx prefix and pass it to users. >> >> Signed-off-by: Ivan Malov >> Reviewed-by: Andrew Rybchenko >> Reviewed-by: Andy Moreton > > <...> > >> @@ -407,6 +409,15 @@ sfc_ef100_rx_prefix_to_offloads(const struct >> sfc_ef100_rxq *rxq, >>                             ESF_GZ_RX_PREFIX_RSS_HASH); >>       } >> +    if (rxq->flags & SFC_EF100_RXQ_USER_FLAG) { >> +        uint32_t user_flag; >> + >> +        user_flag = EFX_OWORD_FIELD(rx_prefix[0], >> +                        ESF_GZ_RX_PREFIX_USER_FLAG); >> +        if (user_flag != 0) >> +            ol_flags |= PKT_RX_FDIR; >> +    } >> + > > Hi Ivan, > > This cause a build error after another sfc patch merged into next-net [1]. > Following change [2] seems fixing the issue, but to be sure nothing is > missed > can you please send a new version rebasing on top of latest next-net? > > > [1] > Commit d86c6ced8732 ("net/sfc: use xword type for EF100 Rx prefix") > > [2] > diff --git a/drivers/net/sfc/sfc_ef100_rx.c > b/drivers/net/sfc/sfc_ef100_rx.c > index 704c62c0ac90..8237b772f151 100644 > --- a/drivers/net/sfc/sfc_ef100_rx.c > +++ b/drivers/net/sfc/sfc_ef100_rx.c > @@ -415,7 +415,7 @@ sfc_ef100_rx_prefix_to_offloads(const struct > sfc_ef100_rxq *rxq, >         if (rxq->flags & SFC_EF100_RXQ_USER_FLAG) { >                 uint32_t user_flag; > > -               user_flag = EFX_OWORD_FIELD(rx_prefix[0], > +               user_flag = EFX_XWORD_FIELD(rx_prefix[0], >                                             ESF_GZ_RX_PREFIX_USER_FLAG); >                 if (user_flag != 0) >                         ol_flags |= PKT_RX_FDIR; -- Ivan M