Re: [PATCH] bbdev: enable to be compiled with MSVC

[Maxime Coquelin <maxime.coquelin@redhat.com>]

On 3/12/25 3:56 PM, Maxime Coquelin wrote:
> 
> 
> On 3/11/25 8:17 PM, Andre Muezerie wrote:
>> The errors below popped up when compiling with MSVC:
>>
>> ../lib/bbdev/rte_bbdev.c(79): error C2061:
>>      syntax error: identifier 'TAILQ_ENTRY'
>> ../lib/bbdev/rte_bbdev.c(85): error C2059:
>>      syntax error: '}'
>>
>> This was caused by a missing include.
>>
>> Signed-off-by: Andre Muezerie <andremue@linux.microsoft.com>
>> ---
>>   lib/bbdev/meson.build | 6 ------
>>   lib/bbdev/rte_bbdev.c | 1 +
>>   2 files changed, 1 insertion(+), 6 deletions(-)
>>
>> diff --git a/lib/bbdev/meson.build b/lib/bbdev/meson.build
>> index d8b95a400e..2e48d5f3da 100644
>> --- a/lib/bbdev/meson.build
>> +++ b/lib/bbdev/meson.build
>> @@ -1,12 +1,6 @@
>>   # SPDX-License-Identifier: BSD-3-Clause
>>   # Copyright(c) 2017 Intel Corporation
>> -if is_windows
>> -    build = false
>> -    reason = 'not supported on Windows'
>> -    subdir_done()
>> -endif
>> -
>>   sources = files('rte_bbdev.c',
>>           'bbdev_trace_points.c')
>>   headers = files('rte_bbdev.h',
>> diff --git a/lib/bbdev/rte_bbdev.c b/lib/bbdev/rte_bbdev.c
>> index d7901cd29d..2c626806f3 100644
>> --- a/lib/bbdev/rte_bbdev.c
>> +++ b/lib/bbdev/rte_bbdev.c
>> @@ -16,6 +16,7 @@
>>   #include <rte_lcore.h>
>>   #include <rte_spinlock.h>
>>   #include <rte_interrupts.h>
>> +#include <sys/queue.h>
> 
> It should be included with other general includes, not with RTE ones.
> I can fix it while applying.
> 
> With this fixed:
> Reviewed-by: Maxime Coquelin <maxime.coquelin@redhat.com>
> 
> Thanks,
> Maxime
> 
>>   #include "rte_bbdev_op.h"
>>   #include "rte_bbdev.h"
> 

Applied to next-baseband.

Thanks,
Maxime