From: Ferruh Yigit <ferruh.yigit@intel.com>
To: Alejandro Lucero <alejandro.lucero@netronome.com>, dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH] nfp: avoid modulo operations for handling ring wrapping
Date: Fri, 23 Dec 2016 16:25:56 +0000 [thread overview]
Message-ID: <acf6835d-4df9-5912-9ab9-c474c5dc76af@intel.com> (raw)
In-Reply-To: <1482163983-19775-1-git-send-email-alejandro.lucero@netronome.com>
On 12/19/2016 4:13 PM, Alejandro Lucero wrote:
> Having those modulo operations implies costly instructions execution,
> what can be avoided with conditionals and unlikely clauses.
>
> This change makes the software ring read and write indexes to be now
> always within the ring size which has to be handled properly. The main
> problem is when write pointer wraps and being less than the read pointer.
> This happened before, but just with indexes type size (uint32_t) wrapping,
> and in that case the processor does the right thing no requiring special
> hanling by software.
>
> This work has also led to discovering redundant pointers in the driver,
> which have been removed.
>
> Signed-off-by: Alejandro Lucero <alejandro.lucero@netronome.com>
Applied to dpdk-next-net/master, thanks.
prev parent reply other threads:[~2016-12-23 16:26 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-19 16:13 Alejandro Lucero
2016-12-23 16:25 ` Ferruh Yigit [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=acf6835d-4df9-5912-9ab9-c474c5dc76af@intel.com \
--to=ferruh.yigit@intel.com \
--cc=alejandro.lucero@netronome.com \
--cc=dev@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).