Re: [dpdk-dev] [dpdk-stable] [PATCH v3] net/tap: fix isolation mode toggling

[Ferruh Yigit <ferruh.yigit@intel.com>]

On 5/14/2018 11:46 PM, Wiles, Keith wrote:
> 
> 
>> On May 14, 2018, at 5:26 PM, Ophir Munk <ophirmu@mellanox.com> wrote:
>>
>> Running testpmd command "flow isolae <port> 0" (i.e. disabling flow
>> isolation) followed by command "flow isolate <port> 1" (i.e. enabling
>> flow isolation) may result in a TAP error:
>> PMD: Kernel refused TC filter rule creation (17): File exists
>>
>> Root cause analysis: when disabling flow isolation we keep the local
>> rule to redirect packets on TX (TAP_REMOTE_TX index) while we add it
>> again when enabling flow isolation. As a result this rule is added
>> two times in a row which results in "File exists" error.
>> The fix is to identify the "File exists" error and silently ignore it.
>>
>> Another issue occurs when enabling isolation mode several times in a
>> row in which case the same tc rules are added consecutively and
>> rte_flow structs are added to a linked list before removing the
>> previous rte_flow structs.
>> The fix is to act upon isolation mode command only when there is a
>> change from "0" to "1" (or vice versa).
>>
>> Fixes: f503d2694825 ("net/tap: support flow API isolated mode")
>> Cc: stable@dpdk.org
>>
>> Reviewed-by: Raslan Darawsheh <rasland@mellanox.com>
>> Signed-off-by: Ophir Munk <ophirmu@mellanox.com>
>> —
> 
> Acked by: Keith Wiles<keith.wile@intel.com>

Applied to dpdk-next-net/master, thanks.