From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 1052EA0093; Fri, 22 Apr 2022 17:46:26 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id A8E2D410D5; Fri, 22 Apr 2022 17:46:25 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mails.dpdk.org (Postfix) with ESMTP id BE44540042 for ; Fri, 22 Apr 2022 17:46:23 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1650642383; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=xS1a83NB+KQwKds1QRL2aSYhAGVeoeuya+hUdGdaN44=; b=Pmy4RYNjAXYF21yjChTgkqC/8MwLgqjHnnKnplNfVj2t6HqeM/HCFsiByTw4yFtnE0mYWI VDdokJBSdEHqQFnfv7kgzXyOppNv8bpk5Jevzk8N1YLlrStjlpoLBWT9RJ5DHR0xJPdDf/ QzxsQzdiaz6wD+yNDIQwFLCJl4Wp+cQ= Received: from mimecast-mx02.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-163-U8q4wl2_Oe-uCRrLTNHBiQ-1; Fri, 22 Apr 2022 11:46:19 -0400 X-MC-Unique: U8q4wl2_Oe-uCRrLTNHBiQ-1 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.rdu2.redhat.com [10.11.54.3]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 739E529AA2EE; Fri, 22 Apr 2022 15:46:19 +0000 (UTC) Received: from [10.39.208.18] (unknown [10.39.208.18]) by smtp.corp.redhat.com (Postfix) with ESMTPS id A13A2111E3FD; Fri, 22 Apr 2022 15:46:11 +0000 (UTC) Message-ID: Date: Fri, 22 Apr 2022 17:46:10 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.7.0 Subject: Re: [PATCH v3 3/5] vhost: merge sync and async descriptor to mbuf filling To: David Marchand , Xuan Ding Cc: "Xia, Chenbo" , dev , Jiayu Hu , Cheng Jiang , Sunil Pai G , liangma@liangbit.com References: <20220407152546.38167-1-xuan.ding@intel.com> <20220419034323.92820-1-xuan.ding@intel.com> <20220419034323.92820-4-xuan.ding@intel.com> From: Maxime Coquelin In-Reply-To: X-Scanned-By: MIMEDefang 2.78 on 10.11.54.3 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=maxime.coquelin@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 4/22/22 13:06, David Marchand wrote: > We (at RH) have some issues with our email infrastructure, so I can't > reply inline of the patch. > > Copy/pasting the code: > > +static __rte_always_inline uint16_t > +async_poll_dequeue_completed_split(struct virtio_net *dev, uint16_t queue_id, > + struct rte_mbuf **pkts, uint16_t count, uint16_t dma_id, > + uint16_t vchan_id, bool legacy_ol_flags) > +{ > + uint16_t start_idx, from, i; > + uint16_t nr_cpl_pkts = 0; > + struct async_inflight_info *pkts_info; > + struct vhost_virtqueue *vq = dev->virtqueue[queue_id]; > + > > Please, don't pass queue_id as an input parameter for > async_poll_dequeue_completed_split(). > The caller of this helper already dereferenced the vq. > You can pass vq. > > I think David's comment was intended to be a reply to patch 4, but I agree with him. Could you please fix this and also fix the build issues reported by the CI? I'll continue the review on V4. Thanks, Maxime