From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 0A75CA0547; Thu, 29 Apr 2021 15:36:57 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id E9E72410DD; Thu, 29 Apr 2021 15:36:56 +0200 (CEST) Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by mails.dpdk.org (Postfix) with ESMTP id 6771B406FF for ; Thu, 29 Apr 2021 15:36:55 +0200 (CEST) IronPort-SDR: DZNylZ+TS3Ptfl1KizAvXeTd6w9/jV6STP8EXfvA8Oww2gvvxyArRsPf68DKtl/2hV9wLTEeps RqgTFHXsyI5A== X-IronPort-AV: E=McAfee;i="6200,9189,9969"; a="184480103" X-IronPort-AV: E=Sophos;i="5.82,259,1613462400"; d="scan'208";a="184480103" Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by orsmga106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 29 Apr 2021 06:36:53 -0700 IronPort-SDR: s0DOS3xKHlsmQ2gX1XPjkVLWeM6fuQM8hbU8N1V4P2yIKiwfZaP6k4VoPIkNc+NKa0YWjdwo1N Q4AIVGTAIFCQ== X-IronPort-AV: E=Sophos;i="5.82,259,1613462400"; d="scan'208";a="526944102" Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.213.208.65]) ([10.213.208.65]) by fmsmga001-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 29 Apr 2021 06:36:52 -0700 To: "Min Hu (Connor)" , dev@dpdk.org References: <1619090834-14643-2-git-send-email-humin29@huawei.com> <1619484862-48907-1-git-send-email-humin29@huawei.com> From: Ferruh Yigit X-User: ferruhy Message-ID: Date: Thu, 29 Apr 2021 14:36:51 +0100 MIME-Version: 1.0 In-Reply-To: <1619484862-48907-1-git-send-email-humin29@huawei.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH v2] net/tap: fix log loss when state fails to be restored X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 4/27/2021 1:54 AM, Min Hu (Connor) wrote: > From: Chengchang Tang > > After restoring the remote states, the return value of ioctl() is not > checked. Therefore, users cannot know whether the remote state is > restored successfully. > > This patch add log for restoring failure. > > Fixes: 4810d3af8343 ("net/tap: restore state of remote device when closing") > Cc: stable@dpdk.org > > Signed-off-by: Chengchang Tang > Signed-off-by: Min Hu (Connor) Reviewed-by: Ferruh Yigit Applied to dpdk-next-net/main, thanks.