From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 9EA18A0C42; Tue, 11 May 2021 23:41:57 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 22C844003F; Tue, 11 May 2021 23:41:57 +0200 (CEST) Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by mails.dpdk.org (Postfix) with ESMTP id F14FC4003E for ; Tue, 11 May 2021 23:41:55 +0200 (CEST) IronPort-SDR: qzxZmnmS5VRhyIyHAinVR9rwl66FuESbUj8NEJjvRLEw6QXIvTaywGj5O2PvwRq/amzJCLE1Xq 43XbqzcDBEkQ== X-IronPort-AV: E=McAfee;i="6200,9189,9981"; a="186691336" X-IronPort-AV: E=Sophos;i="5.82,291,1613462400"; d="scan'208";a="186691336" Received: from orsmga008.jf.intel.com ([10.7.209.65]) by orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 11 May 2021 14:41:54 -0700 IronPort-SDR: hDMYi7QEOb0J3qPzgYdriif1RgsaG0zLa5CQ59i2MPxe88HdN4ld+MdSL8cqCO+elupb0nVUaH oYjv9y2G3POg== X-IronPort-AV: E=Sophos;i="5.82,291,1613462400"; d="scan'208";a="436852574" Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.213.224.45]) ([10.213.224.45]) by orsmga008-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 11 May 2021 14:41:52 -0700 To: David Marchand , dev@dpdk.org Cc: timothy.mcdaniel@intel.com, maxime.coquelin@redhat.com, chenbo.xia@intel.com References: <20210506094452.1689-1-david.marchand@redhat.com> <20210511113358.2485-1-david.marchand@redhat.com> From: Ferruh Yigit X-User: ferruhy Message-ID: Date: Tue, 11 May 2021 22:41:48 +0100 MIME-Version: 1.0 In-Reply-To: <20210511113358.2485-1-david.marchand@redhat.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH v2 0/2] Thread termination leak fixes X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 5/11/2021 12:33 PM, David Marchand wrote: > After looking at the control thread API use in recent changes, I noticed > that some thread resources are not properly released. > This series fixes two net drivers. > Series applied to dpdk-next-net/main, thanks. > Additional notes: > - I noticed that event/dlb2 never kills/terminates its service thread. > It means unplug of this device (if supported) would leak the associated > thread resources. I leave it to this driver maintainer to comment/fix. > > - The vhost library also lets a service thread in the background but since > there is no way to unitialize this library, there is no leak to fix from > my pov. >