From: "Burakov, Anatoly" <anatoly.burakov@intel.com>
To: Stephen Hemminger <stephen@networkplumber.org>
Cc: <dev@dpdk.org>, Bruce Richardson <bruce.richardson@intel.com>,
"Vitaly Lifshits" <vitaly.lifshits@intel.com>
Subject: Re: [PATCH v1 1/2] net/e1000: better clock synchronization workaround
Date: Thu, 12 Jun 2025 13:16:26 +0200 [thread overview]
Message-ID: <ad35e64a-3b2c-4e38-b48e-85dbe354c304@intel.com> (raw)
In-Reply-To: <20250609092310.0d19c68c@hermes.local>
On 6/9/2025 6:23 PM, Stephen Hemminger wrote:
> On Mon, 9 Jun 2025 11:16:41 +0100
> Anatoly Burakov <anatoly.burakov@intel.com> wrote:
>
>> + ret_val = hw->phy.ops.write_reg_locked(hw, E1000_PHY_TIMEOUTS_REG,
>> + phy_timeout);
>> +
>> + return ret_val;
>
> Why use temporary value (ret_val) and not just a return statement?
>
> return hw->phy.ops.write_reg_locked(hw, E1000_PHY_TIMEOUTS_REG, phy_timeout);
I agree with you, but this is not our code, so we can't modify it too
much to avoid maintaining huge deltas with the base code.
--
Thanks,
Anatoly
next prev parent reply other threads:[~2025-06-12 11:16 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-09 10:16 [PATCH v1 0/2] e1000 base code update Anatoly Burakov
2025-06-09 10:16 ` [PATCH v1 1/2] net/e1000: better clock synchronization workaround Anatoly Burakov
2025-06-09 16:23 ` Stephen Hemminger
2025-06-12 11:16 ` Burakov, Anatoly [this message]
2025-06-09 10:16 ` [PATCH v1 2/2] net/e1000: update README Anatoly Burakov
2025-06-09 15:53 ` [PATCH v1 0/2] e1000 base code update Bruce Richardson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ad35e64a-3b2c-4e38-b48e-85dbe354c304@intel.com \
--to=anatoly.burakov@intel.com \
--cc=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
--cc=stephen@networkplumber.org \
--cc=vitaly.lifshits@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).