From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by dpdk.org (Postfix) with ESMTP id 7F3EE1BBDA for ; Fri, 14 Dec 2018 14:33:22 +0100 (CET) Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id C92DA3083394; Fri, 14 Dec 2018 13:33:21 +0000 (UTC) Received: from [10.36.112.58] (ovpn-112-58.ams2.redhat.com [10.36.112.58]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 96AD565F7D; Fri, 14 Dec 2018 13:33:19 +0000 (UTC) To: Xiao Wang , alejandro.lucero@netronome.com, tiwei.bie@intel.com Cc: dev@dpdk.org, zhihong.wang@intel.com, xiaolong.ye@intel.com References: <20181213011014.110089-3-xiao.w.wang@intel.com> <20181213100910.13087-1-xiao.w.wang@intel.com> <20181213100910.13087-2-xiao.w.wang@intel.com> From: Maxime Coquelin Message-ID: Date: Fri, 14 Dec 2018 14:33:17 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.2.1 MIME-Version: 1.0 In-Reply-To: <20181213100910.13087-2-xiao.w.wang@intel.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.44]); Fri, 14 Dec 2018 13:33:21 +0000 (UTC) Subject: Re: [dpdk-dev] [PATCH v3 1/9] vhost: provide helper for host notifier ctrl X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 14 Dec 2018 13:33:23 -0000 On 12/13/18 11:09 AM, Xiao Wang wrote: > VDPA driver can decide if it needs to enable/disable the host notifier > mapping, so exposing a API can allow flexibility. A later patch will > base on this. > > Signed-off-by: Xiao Wang > --- > v2: > * Reword the vdpa host notifier control API comment. > --- > drivers/net/ifc/ifcvf_vdpa.c | 3 +++ > lib/librte_vhost/rte_vdpa.h | 18 ++++++++++++++++++ > lib/librte_vhost/rte_vhost_version.map | 1 + > lib/librte_vhost/vhost.c | 3 +-- > lib/librte_vhost/vhost_user.c | 7 +------ > 5 files changed, 24 insertions(+), 8 deletions(-) > > diff --git a/drivers/net/ifc/ifcvf_vdpa.c b/drivers/net/ifc/ifcvf_vdpa.c > index 97a57f182..e844109f3 100644 > --- a/drivers/net/ifc/ifcvf_vdpa.c > +++ b/drivers/net/ifc/ifcvf_vdpa.c > @@ -556,6 +556,9 @@ ifcvf_dev_config(int vid) > rte_atomic32_set(&internal->dev_attached, 1); > update_datapath(internal); > > + if (rte_vhost_host_notifier_ctrl(vid, true) != 0) > + DRV_LOG(NOTICE, "vDPA (%d): software relay is used.", did); > + > return 0; > } > > diff --git a/lib/librte_vhost/rte_vdpa.h b/lib/librte_vhost/rte_vdpa.h > index a418da47c..fff657391 100644 > --- a/lib/librte_vhost/rte_vdpa.h > +++ b/lib/librte_vhost/rte_vdpa.h > @@ -11,6 +11,8 @@ > * Device specific vhost lib > */ > > +#include > + > #include > #include "rte_vhost.h" > > @@ -155,4 +157,20 @@ rte_vdpa_get_device(int did); > */ > int __rte_experimental > rte_vdpa_get_device_num(void); > + > +/** > + * @warning > + * @b EXPERIMENTAL: this API may change without prior notice > + * > + * Enable/Disable host notifier mapping for a vdpa port. > + * > + * @param vid > + * vhost device id > + * @enable > + * true for host notifier map, false for host notifier unmap > + * @return > + * 0 on success, -1 on failure > + */ > +int __rte_experimental > +rte_vhost_host_notifier_ctrl(int vid, bool enable); > #endif /* _RTE_VDPA_H_ */ > diff --git a/lib/librte_vhost/rte_vhost_version.map b/lib/librte_vhost/rte_vhost_version.map > index ae39b6e21..22302e972 100644 > --- a/lib/librte_vhost/rte_vhost_version.map > +++ b/lib/librte_vhost/rte_vhost_version.map > @@ -83,4 +83,5 @@ EXPERIMENTAL { > rte_vhost_crypto_finalize_requests; > rte_vhost_crypto_set_zero_copy; > rte_vhost_va_from_guest_pa; > + rte_vhost_host_notifier_ctrl; > }; > diff --git a/lib/librte_vhost/vhost.c b/lib/librte_vhost/vhost.c > index 70ac6bc9c..e7a60e0b4 100644 > --- a/lib/librte_vhost/vhost.c > +++ b/lib/librte_vhost/vhost.c > @@ -408,8 +408,7 @@ vhost_detach_vdpa_device(int vid) > if (dev == NULL) > return; > > - vhost_user_host_notifier_ctrl(vid, false); > - > + vhost_destroy_device_notify(dev); It seems that is addition is not mentioned in the commit message. Why is it needed now? > dev->vdpa_dev_id = -1; > } > > diff --git a/lib/librte_vhost/vhost_user.c b/lib/librte_vhost/vhost_user.c > index 3ea64eba6..5e0da0589 100644 > --- a/lib/librte_vhost/vhost_user.c > +++ b/lib/librte_vhost/vhost_user.c > @@ -2045,11 +2045,6 @@ vhost_user_msg_handler(int vid, int fd) > if (vdpa_dev->ops->dev_conf) > vdpa_dev->ops->dev_conf(dev->vid); > dev->flags |= VIRTIO_DEV_VDPA_CONFIGURED; > - if (vhost_user_host_notifier_ctrl(dev->vid, true) != 0) { > - RTE_LOG(INFO, VHOST_CONFIG, > - "(%d) software relay is used for vDPA, performance may be low.\n", > - dev->vid); > - } > } > > return 0; > @@ -2144,7 +2139,7 @@ static int vhost_user_slave_set_vring_host_notifier(struct virtio_net *dev, > return process_slave_message_reply(dev, &msg); > } > > -int vhost_user_host_notifier_ctrl(int vid, bool enable) > +int rte_vhost_host_notifier_ctrl(int vid, bool enable) > { > struct virtio_net *dev; > struct rte_vdpa_device *vdpa_dev; >