From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx1.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) by dpdk.org (Postfix) with ESMTP id 218E71559 for ; Thu, 7 Jun 2018 09:22:17 +0200 (CEST) Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.rdu2.redhat.com [10.11.54.3]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 86462BB43A; Thu, 7 Jun 2018 07:22:16 +0000 (UTC) Received: from [10.36.112.46] (ovpn-112-46.ams2.redhat.com [10.36.112.46]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 6249A10F1BF4; Thu, 7 Jun 2018 07:22:15 +0000 (UTC) To: Tiwei Bie Cc: zhihong.wang@intel.com, dev@dpdk.org References: <20180606123128.7868-1-maxime.coquelin@redhat.com> <20180606123128.7868-6-maxime.coquelin@redhat.com> <20180607045140.GA32696@debian> From: Maxime Coquelin Message-ID: Date: Thu, 7 Jun 2018 09:22:13 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.7.0 MIME-Version: 1.0 In-Reply-To: <20180607045140.GA32696@debian> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Scanned-By: MIMEDefang 2.78 on 10.11.54.3 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.11.55.1]); Thu, 07 Jun 2018 07:22:16 +0000 (UTC) X-Greylist: inspected by milter-greylist-4.5.16 (mx1.redhat.com [10.11.55.1]); Thu, 07 Jun 2018 07:22:16 +0000 (UTC) for IP:'10.11.54.3' DOMAIN:'int-mx03.intmail.prod.int.rdu2.redhat.com' HELO:'smtp.corp.redhat.com' FROM:'maxime.coquelin@redhat.com' RCPT:'' Subject: Re: [dpdk-dev] [PATCH v2 5/5] net/virtio: improve offload check performance X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 07 Jun 2018 07:22:17 -0000 On 06/07/2018 06:51 AM, Tiwei Bie wrote: > On Wed, Jun 06, 2018 at 02:31:28PM +0200, Maxime Coquelin wrote: >> Instead of checking the multiple Virtio features bits for >> every packet, let's do the check once at configure time and >> store it in virtio_hw struct. >> >> Signed-off-by: Maxime Coquelin >> --- > [...] >> @@ -270,8 +261,7 @@ virtqueue_enqueue_xmit(struct virtnet_tx *txvq, struct rte_mbuf *cookie, >> * which is wrong. Below subtract restores correct pkt size. >> */ >> cookie->pkt_len -= head_size; >> - /* if offload disabled, it is not zeroed below, do it now */ > > I think there is no need to remove this comment. Oh right, that was not intentional. Will add it again. > Apart from that, > > Reviewed-by: Tiwei Bie Thanks, Maxime >> - if (offload == 0) { >> + if (!vq->hw->has_tx_offload) { >> ASSIGN_UNLESS_EQUAL(hdr->csum_start, 0); >> ASSIGN_UNLESS_EQUAL(hdr->csum_offset, 0); >> ASSIGN_UNLESS_EQUAL(hdr->flags, 0); > [...] >