From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by dpdk.org (Postfix) with ESMTP id 80AB0532C for ; Tue, 6 Jun 2017 14:53:04 +0200 (CEST) Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by fmsmga101.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 06 Jun 2017 05:53:03 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.39,306,1493708400"; d="scan'208";a="270783547" Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.237.220.91]) ([10.237.220.91]) by fmsmga004.fm.intel.com with ESMTP; 06 Jun 2017 05:53:02 -0700 To: Ajit Khaparde , dev@dpdk.org Cc: Steeven Li References: <20170601030232.38677-1-ajit.khaparde@broadcom.com> <20170601170723.48709-1-ajit.khaparde@broadcom.com> <20170601170723.48709-20-ajit.khaparde@broadcom.com> From: Ferruh Yigit Message-ID: Date: Tue, 6 Jun 2017 13:53:02 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.1.1 MIME-Version: 1.0 In-Reply-To: <20170601170723.48709-20-ajit.khaparde@broadcom.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH v4 19/26] net/bnxt: add support for tx loopback, set vf mac and queues drop X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 06 Jun 2017 12:53:05 -0000 On 6/1/2017 6:07 PM, Ajit Khaparde wrote: > Add functions rte_pmd_bnxt_set_tx_loopback, > rte_pmd_bnxt_set_all_queues_drop_en and > rte_pmd_bnxt_set_vf_mac_addr to configure tx_loopback, > queue_drop and VF MAC address setting in the hardware. > It also adds the necessary functions to send the HWRM commands > to the firmware. >>From the patch title it is clear that this patch add three different functionality. For this patchset, since it already went for a few releases I wouldn't mind, but for future, please send separate patches for each individual feature. Thanks, ferruh > > Signed-off-by: Steeven Li > Signed-off-by: Ajit Khaparde <...>