From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dispatch1-us1.ppe-hosted.com (dispatch1-us1.ppe-hosted.com [67.231.154.164]) by dpdk.org (Postfix) with ESMTP id 0EE561DB8 for ; Mon, 8 Oct 2018 11:23:13 +0200 (CEST) X-Virus-Scanned: Proofpoint Essentials engine Received: from webmail.solarflare.com (uk.solarflare.com [193.34.186.16]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by mx1-us3.ppe-hosted.com (Proofpoint Essentials ESMTP Server) with ESMTPS id E4580B8005D; Mon, 8 Oct 2018 09:23:11 +0000 (UTC) Received: from [192.168.38.17] (91.220.146.112) by ukex01.SolarFlarecom.com (10.17.10.4) with Microsoft SMTP Server (TLS) id 15.0.1395.4; Mon, 8 Oct 2018 10:23:07 +0100 To: Rahul Lakkireddy , CC: , References: <1538840520-10369-1-git-send-email-rahul.lakkireddy@chelsio.com> <1538840520-10369-2-git-send-email-rahul.lakkireddy@chelsio.com> From: Andrew Rybchenko Message-ID: Date: Mon, 8 Oct 2018 12:22:14 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.0 MIME-Version: 1.0 In-Reply-To: <1538840520-10369-2-git-send-email-rahul.lakkireddy@chelsio.com> Content-Language: en-GB X-Originating-IP: [91.220.146.112] X-ClientProxiedBy: ocex03.SolarFlarecom.com (10.20.40.36) To ukex01.SolarFlarecom.com (10.17.10.4) X-TM-AS-Product-Ver: SMEX-12.5.0.1300-8.5.1010-24142.003 X-TM-AS-Result: No-12.996500-8.000000-10 X-TMASE-MatchedRID: QfHZjzml1E8OwH4pD14DsPHkpkyUphL9MZm0+sEE9mtnnK6mXN72myaq HK7pZ0bRznbXUHYMLjtiSVnIdboij63HdLR9eiXxCU+6z8xKoLtZT2gl0gqGyo1OuwjPrj0EEGJ Ca/oTwllFEd0eQlHg+OGEuhchvL8oNuVzoZ6LieUiPTMUjkOgkl4KsHfYo5LQowtRP8whCK8K8T ry7xT2TxHh35S+GXSq/VWmtOMs6xHDeKeENmQ9GWY0Io4Kxb86x22bBvE+WY47LF3pX3rdVLjxa 5EVBV1q4vM1YF6AJbZFi+KwZZttL7ew1twePJJBsjvNV98mpPPfK64t4mSlNZ+Ge0hhzxbIuN6s bhgsN5f7bdne/NDfEjhSNl1+ItWzvsLn8yCGs/+f+d/D8B+GHyk3eVcL7ecGzJjIz6/1HiY= X-TM-AS-User-Approved-Sender: Yes X-TM-AS-User-Blocked-Sender: No X-TMASE-Result: 10--12.996500-8.000000 X-TMASE-Version: SMEX-12.5.0.1300-8.5.1010-24142.003 X-MDID: 1538990592-1CFR3Qt4xcwm Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: 7bit X-Content-Filtered-By: Mailman/MimeDel 2.1.15 Subject: Re: [dpdk-dev] [PATCH v2 1/3] ethdev: add flow api actions to modify IP addresses X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 08 Oct 2018 09:23:13 -0000 On 10/6/18 6:41 PM, Rahul Lakkireddy wrote: > Add actions: > - SET_IPV4_SRC - set a new IPv4 source address. > - SET_IPV4_DST - set a new IPv4 destination address. > - SET_IPV6_SRC - set a new IPv6 source address. > - SET_IPV6_DST - set a new IPv6 destination address. > > Original work by Shagun Agrawal > > Signed-off-by: Rahul Lakkireddy > Acked-by: Xiaoyu Min One nit below, otherwise, Acked-by: Andrew Rybchenko <...> > @@ -1869,6 +1909,36 @@ struct rte_flow_action_nvgre_encap { > struct rte_flow_item *definition; > }; > > +/** > + * @warning > + * @b EXPERIMENTAL: this structure may change without prior notice > + * > + * RTE_FLOW_ACTION_TYPE_SET_IPV4_SRC > + * RTE_FLOW_ACTION_TYPE_SET_IPV4_DST > + * > + * Allows modification of IPv4 source (RTE_FLOW_ACTION_TYPE_SET_IPV4_SRC) > + * and destination address (RTE_FLOW_ACTION_TYPE_SET_IPV4_DST) in the > + * specified outermost IPv4 header. > + */ > +struct rte_flow_action_set_ipv4 { > + uint32_t ipv4_addr; I think rte_be32_t should be used. here to highlight byte order.