From: "Etelson, Gregory" <getelson@nvidia.com>
To: Bruce Richardson <bruce.richardson@intel.com>
Cc: dev@dpdk.org, dsosnowski@nvidia.com, harry.van.haaren@intel.com,
igootorov@gmail.com, mkashani@nvidia.com,
stephen@networkplumber.org, thomas@monjalon.net
Subject: Re: [PATCH v4] rust: support raw DPDK API
Date: Fri, 28 Mar 2025 21:30:25 +0300 (IDT) [thread overview]
Message-ID: <adf06aa-e6f4-4721-329b-b9d023254b3@nvidia.com> (raw)
In-Reply-To: <Z-V7UmCfYEbkWOeY@bricha3-mobl1.ger.corp.intel.com>
Hello Bruce,
>
> When using bindgen, are we better to take the approach (as in this patch)
> of running it on everything in the headers and just excluding some things,
> or taking the opposite conservative approach of just listing the functions
> and defines we actually do want exposed (with wildcarding as necessary)?
> When playing with rust apps on top of DPDK myself, I've tended toward the
> latter scheme, but maybe for this effort we may want the former.
The current library produced a lot of warnings during compilation.
Many of these warnings were result of symbol duplication.
It looks like removing unnecessery duplicated symbols is the right way.
However, I could not activate regex symbol match in bindgen-0.71.1 cli utility.
At this stage I translate files from a shell script. This way I can translate
a single file on demand.
>
> I'm not convinced by having this done as a post-install script. Instead I'd
> tend towards having a rust crate hosted somewhere that does the bindgen as
> part of the rust build.
I'm already implementing that approach.
>
> <snip>
>
>> +
>> + match pkgconfig.args(["--libs", "libdpdk"]).output() {
>
> This work of using pkgconfig should not be necessary in the application
> build.rs file. If we switch to actually producing a proper crate, the
> pkgconfig handling and linking should be covered there (I would hope,
> anyway).
>
I need pkgconfig for dynamic linker.
Regards,
Gregory
next prev parent reply other threads:[~2025-03-28 18:30 UTC|newest]
Thread overview: 42+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-06 13:37 [PATCH] rust: support " Gregory Etelson
2025-03-06 19:26 ` Van Haaren, Harry
2025-03-07 16:56 ` Etelson, Gregory
2025-03-07 15:54 ` Van Haaren, Harry
2025-03-07 16:20 ` Bruce Richardson
2025-03-07 18:15 ` Etelson, Gregory
2025-03-07 18:00 ` Etelson, Gregory
2025-03-08 14:28 ` Igor Gutorov
2025-03-08 19:14 ` Etelson, Gregory
2025-03-10 15:31 ` Stephen Hemminger
2025-03-12 5:21 ` Etelson, Gregory
2025-03-08 18:50 ` [PATCH v2] rust: support raw " Gregory Etelson
2025-03-10 16:13 ` Van Haaren, Harry
2025-03-10 16:25 ` Bruce Richardson
2025-03-12 17:19 ` Thomas Monjalon
2025-03-14 19:12 ` Etelson, Gregory
2025-03-10 15:00 ` [PATCH] rust: support " Stephen Hemminger
2025-03-12 5:12 ` Etelson, Gregory
2025-03-10 16:18 ` Stephen Hemminger
2025-03-10 16:30 ` Bruce Richardson
2025-03-12 14:30 ` Etelson, Gregory
2025-03-13 7:56 ` Igor Gutorov
2025-03-12 15:29 ` Igor Gutorov
2025-03-12 17:24 ` Thomas Monjalon
2025-03-14 18:38 ` [PATCH v3] rust: support raw " Gregory Etelson
2025-03-18 8:51 ` Dariusz Sosnowski
2025-03-18 9:12 ` Dariusz Sosnowski
2025-03-22 10:59 ` [PATCH v4] " Gregory Etelson
2025-03-22 17:39 ` Bruce Richardson
2025-03-27 5:51 ` Etelson, Gregory
2025-03-27 16:22 ` Bruce Richardson
2025-03-28 18:30 ` Etelson, Gregory [this message]
2025-03-27 8:23 ` DPDK for rust Morten Brørup
2025-03-27 9:00 ` Etelson, Gregory
2025-03-27 16:17 ` Bruce Richardson
2025-03-28 18:09 ` Etelson, Gregory
2025-03-28 19:25 ` Stephen Hemminger
2025-03-31 9:11 ` Bruce Richardson
2025-03-31 10:26 ` Luca Boccassi
2025-04-01 13:08 ` Etelson, Gregory
2025-03-31 9:03 ` Thomas Monjalon
2025-03-31 9:10 ` Bruce Richardson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=adf06aa-e6f4-4721-329b-b9d023254b3@nvidia.com \
--to=getelson@nvidia.com \
--cc=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
--cc=dsosnowski@nvidia.com \
--cc=harry.van.haaren@intel.com \
--cc=igootorov@gmail.com \
--cc=mkashani@nvidia.com \
--cc=stephen@networkplumber.org \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).