From: Ferruh Yigit <ferruh.yigit@intel.com>
To: Thomas Monjalon <thomas@monjalon.net>, dev@dpdk.org
Cc: david.marchand@redhat.com, bruce.richardson@intel.com,
stable@dpdk.org, Luca Boccassi <bluca@debian.org>
Subject: Re: [dpdk-dev] [PATCH 1/1] devtools: fix build test config inheritance from env
Date: Tue, 10 Nov 2020 17:18:52 +0000 [thread overview]
Message-ID: <ae0bedfd-06d9-10d3-54f9-df288dc6807a@intel.com> (raw)
In-Reply-To: <20201109210009.919129-1-thomas@monjalon.net>
On 11/9/2020 9:00 PM, Thomas Monjalon wrote:
> PKG_CONFIG_PATH is specific to each target, so it must be empty
> before configuring each build from the file according to DPDK_TARGET.
> Inheriting a default PKG_CONFIG_PATH for all targets does not make sense
> and is prone to confusion.
>
> DPDK_MESON_OPTIONS might take a global initial value from environment
> to customize a build test from the shell. Example:
> DPDK_MESON_OPTIONS="b_lto=true"
> Some target-specific options can be added in the configuration file:
> DPDK_MESON_OPTIONS="$DPDK_MESON_OPTIONS kernel_dir=$MYKERNEL"
>
> Fixes: 272236741258 ("devtools: load target-specific compilation environment")
> Cc: stable@dpdk.org
>
> Signed-off-by: Thomas Monjalon <thomas@monjalon.net>
> ---
> devtools/test-meson-builds.sh | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/devtools/test-meson-builds.sh b/devtools/test-meson-builds.sh
> index 0c95d1cc98..6d265f6ab3 100755
> --- a/devtools/test-meson-builds.sh
> +++ b/devtools/test-meson-builds.sh
> @@ -38,10 +38,10 @@ else
> fi
>
> default_path=$PATH
> -default_pkgpath=$PKG_CONFIG_PATH
> default_cppflags=$CPPFLAGS
> default_cflags=$CFLAGS
> default_ldflags=$LDFLAGS
> +default_meson_options=$DPDK_MESON_OPTIONS
>
> check_cc_flags () # <flag to check> <flag2> ...
> {
> @@ -53,11 +53,11 @@ load_env () # <target compiler>
> {
> targetcc=$1
> export PATH=$default_path
> - export PKG_CONFIG_PATH=$default_pkgpath
> + export PKG_CONFIG_PATH= # global default makes no sense
> export CPPFLAGS=$default_cppflags
> export CFLAGS=$default_cflags
> export LDFLAGS=$default_ldflags
> - unset DPDK_MESON_OPTIONS
> + export DPDK_MESON_OPTIONS=$default_meson_options
> if [ -n "$target_override" ] ; then
> DPDK_TARGET=$target_override
> elif command -v $targetcc >/dev/null 2>&1 ; then
>
In same run both 64bit and 32bit builds are done,
At least for my environment,
for 64bit, PKG_CONFIG_PATH should be '/usr/local/lib64/pkgconfig/'
for 32bit, PKG_CONFIG_PATH should be '/usr/lib/pkgconfig/'
What should I set in the config file to support both?
next prev parent reply other threads:[~2020-11-10 17:19 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-09 21:00 Thomas Monjalon
2020-11-10 10:14 ` Bruce Richardson
2020-11-10 10:45 ` Thomas Monjalon
2020-11-10 11:20 ` Bruce Richardson
2020-11-10 14:08 ` Jerin Jacob
2020-11-10 17:18 ` Ferruh Yigit [this message]
2020-11-10 17:55 ` Thomas Monjalon
2020-11-10 18:09 ` Ferruh Yigit
2020-11-11 9:18 ` Bruce Richardson
2020-11-11 10:37 ` Thomas Monjalon
2020-11-11 11:00 ` Bruce Richardson
2020-11-11 11:13 ` Ferruh Yigit
2020-11-11 11:18 ` Thomas Monjalon
2020-11-12 14:22 ` [dpdk-dev] [PATCH v2 " Thomas Monjalon
2020-11-12 14:36 ` David Marchand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ae0bedfd-06d9-10d3-54f9-df288dc6807a@intel.com \
--to=ferruh.yigit@intel.com \
--cc=bluca@debian.org \
--cc=bruce.richardson@intel.com \
--cc=david.marchand@redhat.com \
--cc=dev@dpdk.org \
--cc=stable@dpdk.org \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).