From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from dpdk.org (dpdk.org [92.243.14.124])
by inbox.dpdk.org (Postfix) with ESMTP id D6E64A04DD;
Tue, 10 Nov 2020 18:19:19 +0100 (CET)
Received: from [92.243.14.124] (localhost [127.0.0.1])
by dpdk.org (Postfix) with ESMTP id D9785323C;
Tue, 10 Nov 2020 18:19:06 +0100 (CET)
Received: from mga01.intel.com (mga01.intel.com [192.55.52.88])
by dpdk.org (Postfix) with ESMTP id 5CB62DED;
Tue, 10 Nov 2020 18:19:03 +0100 (CET)
IronPort-SDR: ZbTf8rem+DCuNjkHtjMkXspkAEgF6VO3bE/YDuVaXLWXtSIaMMeJIVrqi8Rcosgj8/OKDfcnfC
kZrCPCv2wqeA==
X-IronPort-AV: E=McAfee;i="6000,8403,9801"; a="187981252"
X-IronPort-AV: E=Sophos;i="5.77,466,1596524400"; d="scan'208";a="187981252"
X-Amp-Result: SKIPPED(no attachment in message)
X-Amp-File-Uploaded: False
Received: from orsmga005.jf.intel.com ([10.7.209.41])
by fmsmga101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;
10 Nov 2020 09:18:58 -0800
IronPort-SDR: Y5IEhaDTLaMGJdSNBBpl2iIyVdX6AxOE7f2R7ZZFAQ08WVHTeQFSCBaqhaeqLd8QEdncuiDWrW
xHfk36XoORng==
X-IronPort-AV: E=Sophos;i="5.77,466,1596524400"; d="scan'208";a="541412861"
Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.252.0.179])
([10.252.0.179])
by orsmga005-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;
10 Nov 2020 09:18:56 -0800
To: Thomas Monjalon <thomas@monjalon.net>, dev@dpdk.org
Cc: david.marchand@redhat.com, bruce.richardson@intel.com, stable@dpdk.org,
Luca Boccassi <bluca@debian.org>
References: <20201109210009.919129-1-thomas@monjalon.net>
From: Ferruh Yigit <ferruh.yigit@intel.com>
Message-ID: <ae0bedfd-06d9-10d3-54f9-df288dc6807a@intel.com>
Date: Tue, 10 Nov 2020 17:18:52 +0000
MIME-Version: 1.0
In-Reply-To: <20201109210009.919129-1-thomas@monjalon.net>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 8bit
Subject: Re: [dpdk-dev] [PATCH 1/1] devtools: fix build test config
inheritance from env
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
<mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
<mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>
On 11/9/2020 9:00 PM, Thomas Monjalon wrote:
> PKG_CONFIG_PATH is specific to each target, so it must be empty
> before configuring each build from the file according to DPDK_TARGET.
> Inheriting a default PKG_CONFIG_PATH for all targets does not make sense
> and is prone to confusion.
>
> DPDK_MESON_OPTIONS might take a global initial value from environment
> to customize a build test from the shell. Example:
> DPDK_MESON_OPTIONS="b_lto=true"
> Some target-specific options can be added in the configuration file:
> DPDK_MESON_OPTIONS="$DPDK_MESON_OPTIONS kernel_dir=$MYKERNEL"
>
> Fixes: 272236741258 ("devtools: load target-specific compilation environment")
> Cc: stable@dpdk.org
>
> Signed-off-by: Thomas Monjalon <thomas@monjalon.net>
> ---
> devtools/test-meson-builds.sh | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/devtools/test-meson-builds.sh b/devtools/test-meson-builds.sh
> index 0c95d1cc98..6d265f6ab3 100755
> --- a/devtools/test-meson-builds.sh
> +++ b/devtools/test-meson-builds.sh
> @@ -38,10 +38,10 @@ else
> fi
>
> default_path=$PATH
> -default_pkgpath=$PKG_CONFIG_PATH
> default_cppflags=$CPPFLAGS
> default_cflags=$CFLAGS
> default_ldflags=$LDFLAGS
> +default_meson_options=$DPDK_MESON_OPTIONS
>
> check_cc_flags () # <flag to check> <flag2> ...
> {
> @@ -53,11 +53,11 @@ load_env () # <target compiler>
> {
> targetcc=$1
> export PATH=$default_path
> - export PKG_CONFIG_PATH=$default_pkgpath
> + export PKG_CONFIG_PATH= # global default makes no sense
> export CPPFLAGS=$default_cppflags
> export CFLAGS=$default_cflags
> export LDFLAGS=$default_ldflags
> - unset DPDK_MESON_OPTIONS
> + export DPDK_MESON_OPTIONS=$default_meson_options
> if [ -n "$target_override" ] ; then
> DPDK_TARGET=$target_override
> elif command -v $targetcc >/dev/null 2>&1 ; then
>
In same run both 64bit and 32bit builds are done,
At least for my environment,
for 64bit, PKG_CONFIG_PATH should be '/usr/local/lib64/pkgconfig/'
for 32bit, PKG_CONFIG_PATH should be '/usr/lib/pkgconfig/'
What should I set in the config file to support both?