From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by dpdk.org (Postfix) with ESMTP id 1D019201 for ; Mon, 24 Sep 2018 12:03:35 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by fmsmga105.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 24 Sep 2018 03:03:35 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.54,297,1534834800"; d="scan'208";a="91381717" Received: from fyigit-mobl.ger.corp.intel.com (HELO [10.237.221.39]) ([10.237.221.39]) by fmsmga004.fm.intel.com with ESMTP; 24 Sep 2018 03:03:29 -0700 To: Andrzej Ostruszka , dev@dpdk.org Cc: mw@semihalf.com, zr@semihalf.com, tdu@semihalf.com, nadavh@marvell.com References: <1537369294-17099-1-git-send-email-amo@semihalf.com> <1537434339-22570-1-git-send-email-amo@semihalf.com> <1537434339-22570-2-git-send-email-amo@semihalf.com> From: Ferruh Yigit Openpgp: preference=signencrypt Message-ID: Date: Mon, 24 Sep 2018 11:03:29 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <1537434339-22570-2-git-send-email-amo@semihalf.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH v5 1/8] net/mvneta: add neta PMD skeleton X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 24 Sep 2018 10:03:36 -0000 On 9/20/2018 10:05 AM, Andrzej Ostruszka wrote: > +/** > + * DPDK callback to register the virtual device. > + * > + * @param vdev > + * Pointer to the virtual device. > + * > + * @return > + * 0 on success, negative error value otherwise. > + */ > +static int > +rte_pmd_mvneta_probe(struct rte_vdev_device *vdev) > +{ > + struct rte_kvargs *kvlist; > + struct mvneta_ifnames ifnames; > + int ret = -EINVAL; > + uint32_t i, ifnum; > + const char *params; > + > + params = rte_vdev_device_args(vdev); > + if (!params) > + return -EINVAL; > + > + kvlist = rte_kvargs_parse(params, valid_args); > + if (!kvlist) > + return -EINVAL; > + > + ifnum = rte_kvargs_count(kvlist, MVNETA_IFACE_NAME_ARG); > + if (ifnum > RTE_DIM(ifnames.names)) > + goto out_free_kvlist; > + > + ifnames.idx = 0; > + rte_kvargs_process(kvlist, MVNETA_IFACE_NAME_ARG, > + mvneta_ifnames_get, &ifnames); > + > + /* > + * The below system initialization should be done only once, > + * on the first provided configuration file > + */ > + if (mvneta_dev_num) > + goto init_devices; > + > + MVNETA_LOG(INFO, "Perform MUSDK initializations"); > + > + ret = rte_mvep_init(MVEP_MOD_T_NETA, kvlist); Giving build error for shared libraries [1], needs to link with rte_common_mvep, In makefile needed: LDLIBS += -lrte_common_mvep, please check "mvpp2/Makefile" [1] mvneta_ethdev.o: In function `rte_pmd_mvneta_probe': mvneta_ethdev.c:(.text+0xa58): undefined reference to `rte_mvep_init' mvneta_ethdev.c:(.text+0xc98): undefined reference to `rte_mvep_deinit' mvneta_ethdev.c:(.text+0xcb4): undefined reference to `rte_mvep_deinit' mvneta_ethdev.o: In function `rte_pmd_mvneta_remove': mvneta_ethdev.c:(.text+0xe58): undefined reference to `rte_mvep_deinit'