DPDK patches and discussions
 help / color / mirror / Atom feed
From: Ferruh Yigit <ferruh.yigit@xilinx.com>
To: Rahul Lakkireddy <rahul.lakkireddy@chelsio.com>
Cc: <daxuex.gao@intel.com>, <dev@dpdk.org>
Subject: Re: [PATCH] net/cxgbe: fix warnings when using optimization=1 flag
Date: Thu, 9 Jun 2022 15:02:35 +0100	[thread overview]
Message-ID: <ae2e52af-0c5a-e0c5-8c05-7ab19305c020@xilinx.com> (raw)
In-Reply-To: <155c777425bc32c4d287373cd711825f8de9bcf2.1654764457.git.rahul.lakkireddy@chelsio.com>

On 6/9/2022 9:49 AM, Rahul Lakkireddy wrote:
> Initialize maddr and mtype to fix following warnings when
> using optimization=1 compilation flag.
> 
> In file included from ../drivers/net/cxgbe/base/common.h:13,
>                   from ../drivers/net/cxgbe/cxgbe_main.c:37:
> ../drivers/net/cxgbe/cxgbe_main.c: In function ‘cxgbe_probe’:
> ../drivers/net/cxgbe/base/t4fw_interface.h:656:7: warning: ‘maddr’ may be used uninitialized in this function [-Wmaybe-uninitialized]
>    ((x) << S_FW_CAPS_CONFIG_CMD_MEMADDR64K_CF)
>         ^~
> ../drivers/net/cxgbe/cxgbe_main.c:1111:40: note: ‘maddr’ was declared here
>    u32 finiver, finicsum, cfcsum, mtype, maddr, param, val;
>                                          ^~~~~
> In file included from ../drivers/net/cxgbe/base/common.h:13,
>                   from ../drivers/net/cxgbe/cxgbe_main.c:37:
> ../drivers/net/cxgbe/base/t4fw_interface.h:648:7: warning: ‘mtype’ may be used uninitialized in this function [-Wmaybe-uninitialized]
>    ((x) << S_FW_CAPS_CONFIG_CMD_MEMTYPE_CF)
>         ^~
> ../drivers/net/cxgbe/cxgbe_main.c:1111:33: note: ‘mtype’ was declared here
>    u32 finiver, finicsum, cfcsum, mtype, maddr, param, val;
>                                   ^~~~~
> Bugzilla ID: 1029
> Fixes: 6d7d651bbc15 ("net/cxgbe: read firmware configuration file from filesystem")
> 
> Reported-by: Daxue Gao<daxuex.gao@intel.com>
> Signed-off-by: Rahul Lakkireddy<rahul.lakkireddy@chelsio.com>

Applied to dpdk-next-net/main, thanks.

      reply	other threads:[~2022-06-09 14:02 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-06-09  8:49 Rahul Lakkireddy
2022-06-09 14:02 ` Ferruh Yigit [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ae2e52af-0c5a-e0c5-8c05-7ab19305c020@xilinx.com \
    --to=ferruh.yigit@xilinx.com \
    --cc=daxuex.gao@intel.com \
    --cc=dev@dpdk.org \
    --cc=rahul.lakkireddy@chelsio.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).