[dpdk-dev] [PATCH] examples/vhost: remove unnecessary method and constant

[dpdk-dev] [PATCH] examples/vhost: remove unnecessary method and constant

[Rami Rosen]

This cleanup patch removes a method and a constant which are now
unnecessary in the VHOST sample applicaiopn,  namely the
validate_num_devices() method and the MAX_DEVICES constant.

Fixes: 56fe86f8dcaf ("examples/vhost: embed statistics into device structure")
Cc: stable@dpdk.org

Signed-off-by: Rami Rosen <ramirose@gmail.com>
---
 examples/vhost/main.c | 22 ----------------------
 1 file changed, 22 deletions(-)

diff --git a/examples/vhost/main.c b/examples/vhost/main.c
index dc9ea10..f722a13 100644
--- a/examples/vhost/main.c
+++ b/examples/vhost/main.c
@@ -55,9 +55,6 @@
 
 #define INVALID_PORT_ID 0xFF
 
-/* Max number of devices. Limited by vmdq. */
-#define MAX_DEVICES 64
-
 /* Maximum long option length for option parsing. */
 #define MAX_LONG_OPT_SZ 64
 
@@ -215,21 +212,6 @@ struct mbuf_table {
 }
 
 /*
- * Validate the device number according to the max pool number gotten form
- * dev_info. If the device number is invalid, give the error message and
- * return -1. Each device must have its own pool.
- */
-static inline int
-validate_num_devices(uint32_t max_nb_devices)
-{
-	if (num_devices > max_nb_devices) {
-		RTE_LOG(ERR, VHOST_PORT, "invalid number of devices\n");
-		return -1;
-	}
-	return 0;
-}
-
-/*
  * Initialises a given port using global settings and with the rx buffers
  * coming from the mbuf_pool passed as parameter
  */
@@ -270,10 +252,6 @@ struct mbuf_table {
 
 	tx_rings = (uint16_t)rte_lcore_count();
 
-	retval = validate_num_devices(MAX_DEVICES);
-	if (retval < 0)
-		return retval;
-
 	/* Get port configuration. */
 	retval = get_eth_conf(&port_conf, num_devices);
 	if (retval < 0)
-- 
1.8.3.1

Re: [dpdk-dev] [PATCH] examples/vhost: remove unnecessary method and constant

[Maxime Coquelin]

On 1/9/19 3:57 PM, Rami Rosen wrote:
> This cleanup patch removes a method and a constant which are now
> unnecessary in the VHOST sample applicaiopn,  namely the

s/applicaiopn/application/

> validate_num_devices() method and the MAX_DEVICES constant.
> 
> Fixes: 56fe86f8dcaf ("examples/vhost: embed statistics into device structure")
> Cc: stable@dpdk.org
> 
> Signed-off-by: Rami Rosen <ramirose@gmail.com>
> ---
>   examples/vhost/main.c | 22 ----------------------
>   1 file changed, 22 deletions(-)
> 

No need to resend, I'll fix while applying:

Reviewed-by: Maxime Coquelin <maxime.coquelin@redhat.com>

Thanks,
Maxime

Re: [dpdk-dev] [PATCH] examples/vhost: remove unnecessary method and constant

[Maxime Coquelin]

On 1/9/19 3:57 PM, Rami Rosen wrote:
> This cleanup patch removes a method and a constant which are now
> unnecessary in the VHOST sample applicaiopn,  namely the
> validate_num_devices() method and the MAX_DEVICES constant.
> 
> Fixes: 56fe86f8dcaf ("examples/vhost: embed statistics into device structure")
> Cc: stable@dpdk.org
> 
> Signed-off-by: Rami Rosen <ramirose@gmail.com>
> ---
>   examples/vhost/main.c | 22 ----------------------
>   1 file changed, 22 deletions(-)

Applied to dpdk-next-virtio with fixing commit message typo,
and also removing the Cc to stable, as IIUC it is more a cleanup
than fixing a real problem.

Thanks,
Maxime