From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 1ADE3A0093; Tue, 8 Nov 2022 14:41:32 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id B5CB1400D4; Tue, 8 Nov 2022 14:41:31 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mails.dpdk.org (Postfix) with ESMTP id BBC0B4003C for ; Tue, 8 Nov 2022 14:41:29 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1667914889; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=oq65Z8dheki7+hIAypgLHX5HCeiIg/rhQBd/7WcDH/I=; b=gA1Zc01lkxDKHXHKPU/tfM0jvuKlKtPZZbJg+hSeVdbGEQ0qRp9kx/UCY37HSADOYeNDj3 ScpVsa98CyA22LTTrWPxQn5FGcTZrDbC47Cz86UArvDxQ4yGTrfubqOAn8Sds0f+GmZf42 TldqwrV66Oz7C94HWbpdguIC736DCI0= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-121-HQ54HskUP8aWt4mYAgZtJw-1; Tue, 08 Nov 2022 08:41:28 -0500 X-MC-Unique: HQ54HskUP8aWt4mYAgZtJw-1 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.rdu2.redhat.com [10.11.54.6]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 9052F185A7A9; Tue, 8 Nov 2022 13:41:27 +0000 (UTC) Received: from [10.39.208.36] (unknown [10.39.208.36]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 9FF162166B29; Tue, 8 Nov 2022 13:41:26 +0000 (UTC) Message-ID: Date: Tue, 8 Nov 2022 14:41:25 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.4.1 Subject: Re: [PATCH v1 1/1] baseband/acc100: fix to input error related to padding To: Nicolas Chautru , dev@dpdk.org, gakhil@marvell.com, hernan.vargas@intel.com References: <20221107234532.20775-1-nicolas.chautru@intel.com> <20221107234532.20775-2-nicolas.chautru@intel.com> From: Maxime Coquelin In-Reply-To: <20221107234532.20775-2-nicolas.chautru@intel.com> X-Scanned-By: MIMEDefang 3.1 on 10.11.54.6 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 11/8/22 00:45, Nicolas Chautru wrote: > Previous commit includes some padding for some cases, > which may cause input warning from the HW > which should be safely ignored to avoid false alarm. > > Fixes: 6f3325bbfa ("baseband/acc100: add LDPC encoder padding function") > > Signed-off-by: Nicolas Chautru > --- > drivers/baseband/acc/rte_acc100_pmd.c | 3 --- > 1 file changed, 3 deletions(-) > > diff --git a/drivers/baseband/acc/rte_acc100_pmd.c b/drivers/baseband/acc/rte_acc100_pmd.c > index 96daef87bc..ba8247d47e 100644 > --- a/drivers/baseband/acc/rte_acc100_pmd.c > +++ b/drivers/baseband/acc/rte_acc100_pmd.c > @@ -3779,7 +3779,6 @@ dequeue_enc_one_op_cb(struct acc_queue *q, struct rte_bbdev_enc_op **ref_op, > /* Clearing status, it will be set based on response */ > op->status = 0; > > - op->status |= ((rsp.input_err) ? (1 << RTE_BBDEV_DATA_ERROR) : 0); > op->status |= ((rsp.dma_err) ? (1 << RTE_BBDEV_DRV_ERROR) : 0); > op->status |= ((rsp.fcw_err) ? (1 << RTE_BBDEV_DRV_ERROR) : 0); > > @@ -3853,8 +3852,6 @@ dequeue_enc_one_op_tb(struct acc_queue *q, struct rte_bbdev_enc_op **ref_op, > rte_bbdev_log_debug("Resp. desc %p: %x descs %d cbs %d\n", > desc, rsp.val, descs_in_tb, desc->req.numCBs); > > - op->status |= ((rsp.input_err) > - ? (1 << RTE_BBDEV_DATA_ERROR) : 0); > op->status |= ((rsp.dma_err) ? (1 << RTE_BBDEV_DRV_ERROR) : 0); > op->status |= ((rsp.fcw_err) ? (1 << RTE_BBDEV_DRV_ERROR) : 0); > Reviewed-by: Maxime Coquelin Thanks, Maxime