From: Ferruh Yigit <ferruh.yigit@intel.com>
To: Bruce Richardson <bruce.richardson@intel.com>,
John McNamara <john.mcnamara@intel.com>,
Marko Kovacevic <marko.kovacevic@intel.com>
Cc: dev@dpdk.org, Juhamatti Kuusisaari <Juhamatti.Kuusisaari@coriant.com>
Subject: Re: [dpdk-dev] [PATCH v8] net/pcap: physical interface MAC address support
Date: Mon, 8 Oct 2018 13:14:55 +0100 [thread overview]
Message-ID: <ae56ad93-2999-6dc4-d227-6a7f7fc196cc@intel.com> (raw)
In-Reply-To: <20181006004959.13097-1-ferruh.yigit@intel.com>
On 10/6/2018 1:49 AM, Ferruh Yigit wrote:
> From: Juhamatti Kuusisaari <Juhamatti.Kuusisaari@coriant.com>
>
> At the moment, PCAP interfaces use dummy MAC by default. This change
> adds support for selecting PCAP physical interface MAC with phy_mac=1
> devarg. This allows to setup packet flows using the physical interface
> MAC.
>
> Signed-off-by: Juhamatti Kuusisaari <juhamatti.kuusisaari@coriant.com>
> Signed-off-by: Ferruh Yigit <ferruh.yigit@intel.com>
> ---
> v7:
> * Add internal->phy_mac to be able to free data->mac_addrs
> * code review comments applied
> * doc format updates
> * NOTE: FreeBSD functionality not tested
Able to test on FreeBSD, works fine.
>
> v8:
> * don't access kvlist internals directly
> * store phy_mac in pmd_devargs instead of passing as arg to function
next prev parent reply other threads:[~2018-10-08 12:14 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-06 16:56 [dpdk-dev] [PATCH v5] " Juhamatti Kuusisaari
2018-09-10 12:03 ` Ferruh Yigit
2018-09-10 17:20 ` Kuusisaari, Juhamatti (Coriant - FI/Espoo)
2018-09-10 16:55 ` [dpdk-dev] [PATCH v6] " Juhamatti Kuusisaari
2018-09-11 15:35 ` Ferruh Yigit
2018-10-01 7:30 ` Kuusisaari, Juhamatti (Coriant - FI/Espoo)
2018-10-05 20:27 ` [dpdk-dev] [PATCH v7] " Ferruh Yigit
2018-10-06 0:49 ` [dpdk-dev] [PATCH v8] " Ferruh Yigit
2018-10-08 12:14 ` Ferruh Yigit [this message]
2018-10-09 4:30 ` Kuusisaari, Juhamatti (Infinera - FI/Espoo)
2018-10-09 12:04 ` Ferruh Yigit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ae56ad93-2999-6dc4-d227-6a7f7fc196cc@intel.com \
--to=ferruh.yigit@intel.com \
--cc=Juhamatti.Kuusisaari@coriant.com \
--cc=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
--cc=john.mcnamara@intel.com \
--cc=marko.kovacevic@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).