From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from dpdk.org (dpdk.org [92.243.14.124])
by inbox.dpdk.org (Postfix) with ESMTP id 9EAC1A0527;
Mon, 9 Nov 2020 19:16:47 +0100 (CET)
Received: from [92.243.14.124] (localhost [127.0.0.1])
by dpdk.org (Postfix) with ESMTP id 822C5697C;
Mon, 9 Nov 2020 19:16:45 +0100 (CET)
Received: from mga06.intel.com (mga06.intel.com [134.134.136.31])
by dpdk.org (Postfix) with ESMTP id DE2F16004
for <dev@dpdk.org>; Mon, 9 Nov 2020 19:16:42 +0100 (CET)
IronPort-SDR: NqCldQmh7FLWyMHE28PHZDDdiOP8Bub+CTTa7XOGsEikB3P09q61l3d7uHq72LbuONQKxbHADi
sdsUZxvf/QAg==
X-IronPort-AV: E=McAfee;i="6000,8403,9800"; a="231477654"
X-IronPort-AV: E=Sophos;i="5.77,464,1596524400"; d="scan'208";a="231477654"
X-Amp-Result: SKIPPED(no attachment in message)
X-Amp-File-Uploaded: False
Received: from fmsmga005.fm.intel.com ([10.253.24.32])
by orsmga104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;
09 Nov 2020 10:16:40 -0800
IronPort-SDR: De+OoIccU41idHqXOxRdifB9JRlir8qlLUTK+PSg8GZprdu+Pvr+hIoyhDGZzDLCUXCiDBgKCA
+OOU3CcejgtQ==
X-IronPort-AV: E=Sophos;i="5.77,464,1596524400"; d="scan'208";a="530855383"
Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.213.193.177])
([10.213.193.177])
by fmsmga005-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;
09 Nov 2020 10:16:39 -0800
To: Suanming Mou <suanmingm@nvidia.com>, viacheslavo@nvidia.com,
matan@nvidia.com
Cc: rasland@nvidia.com, dev@dpdk.org
References: <1604632107-146708-1-git-send-email-suanmingm@nvidia.com>
From: Ferruh Yigit <ferruh.yigit@intel.com>
Message-ID: <ae5fa422-7783-1a1b-abb6-157b58e76090@intel.com>
Date: Mon, 9 Nov 2020 18:16:35 +0000
MIME-Version: 1.0
In-Reply-To: <1604632107-146708-1-git-send-email-suanmingm@nvidia.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 8bit
Subject: Re: [dpdk-dev] [PATCH] net/mlx5: fix shared RSS action release
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
<mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
<mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>
On 11/6/2020 3:08 AM, Suanming Mou wrote:
> As shared RSS action is global standalone action, the shared action
> should be maintained only by the shared action management functions.
>
> Currently, the shared RSS action hrxq uses the same fate action type
> with existed general queues, and implicitly uses the deprecate refcnt
> increment to indicate the hrxq is in using which leads the hrxq be
> released when flow is destroyed.
>
Can you please re-word above paragraph to make it easier to understand?
Thanks,
ferruh
> This commit adds a new fate action type for shared RSS action to
> handle the shared RSS action release correctly.
>
> Fixes: e1592b6c4dea ("net/mlx5: make Rx queue thread safe")
>
> Signed-off-by: Suanming Mou <suanmingm@nvidia.com>
> Acked-by: Matan Azrad <matan@nvidia.com>
<...>