From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by dpdk.org (Postfix) with ESMTP id 40C994F93 for ; Tue, 18 Sep 2018 18:19:42 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga005.jf.intel.com ([10.7.209.41]) by orsmga106.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 18 Sep 2018 09:19:41 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.53,390,1531810800"; d="scan'208";a="258296528" Received: from fyigit-mobl.ger.corp.intel.com (HELO [10.237.221.39]) ([10.237.221.39]) by orsmga005.jf.intel.com with ESMTP; 18 Sep 2018 09:19:40 -0700 To: Dan Gora , dev@dpdk.org References: <20180913214652.20771-1-dg@adax.com> From: Ferruh Yigit Openpgp: preference=signencrypt Message-ID: Date: Tue, 18 Sep 2018 17:19:39 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <20180913214652.20771-1-dg@adax.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH] kni: return failure for all ioctls X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 18 Sep 2018 16:19:42 -0000 On 9/13/2018 10:46 PM, Dan Gora wrote: > Modify kni_net_ioctl() to return -EOPNOTSUPP for all ioctls instead > of 0. > > This is necessary because the Wicked (and possibly other) network > interface managers will perform the SIOCGIWNAME ioctl to check if > the interface is a wireless interface. If the KNI module returns > success, Wicked will incorrectly interpret the interface as a wireless > interface. > > Signed-off-by: Dan Gora Acked-by: Ferruh Yigit