From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.warmcat.com (mail.warmcat.com [163.172.24.82]) by dpdk.org (Postfix) with ESMTP id BA3D76A71 for ; Tue, 8 May 2018 11:00:41 +0200 (CEST) To: Bruce Richardson Cc: dev@dpdk.org References: <152575364588.56689.3300796065057551728.stgit@localhost.localdomain> <152575379320.56689.8382051384798098704.stgit@localhost.localdomain> <20180508085835.GB20636@bricha3-MOBL.ger.corp.intel.com> From: Andy Green Message-ID: Date: Tue, 8 May 2018 17:00:21 +0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.7.0 In-Reply-To: <20180508085835.GB20636@bricha3-MOBL.ger.corp.intel.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH 05/18] drivers: net: nfp: nfpcore: fix strncpy misuse X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 08 May 2018 09:00:41 -0000 On 05/08/2018 04:58 PM, Bruce Richardson wrote: > On Tue, May 08, 2018 at 12:29:53PM +0800, Andy Green wrote: >> >> --- >> drivers/net/nfp/nfpcore/nfp_cpp_pcie_ops.c | 3 ++- >> 1 file changed, 2 insertions(+), 1 deletion(-) >> >> diff --git a/drivers/net/nfp/nfpcore/nfp_cpp_pcie_ops.c b/drivers/net/nfp/nfpcore/nfp_cpp_pcie_ops.c >> index 4e6c66624..9f6704a7f 100644 >> --- a/drivers/net/nfp/nfpcore/nfp_cpp_pcie_ops.c >> +++ b/drivers/net/nfp/nfpcore/nfp_cpp_pcie_ops.c >> @@ -846,7 +846,8 @@ nfp6000_init(struct nfp_cpp *cpp, const char *devname) >> >> >> memset(desc->busdev, 0, BUSDEV_SZ); >> - strncpy(desc->busdev, devname, strlen(devname)); >> + strncpy(desc->busdev, devname, sizeof(desc->busdev) - 1); >> + desc->busdev[sizeof(desc->busdev) - 1] = '\0'; >> >> ret = nfp_acquire_process_lock(desc); >> if (ret) > As with previous patch, a better fix is to use strlcpy. This would apply to > just about all uses of strncpy in the code. OK. But the strncpy() was already there, it's not introduced by the patch. I agree just doing it in one hit with strlcpy() is nicer. -Andy > /Bruce >