From: Tom Rix <trix@redhat.com>
To: Nicolas Chautru <nicolas.chautru@intel.com>,
dev@dpdk.org, akhil.goyal@nxp.com
Cc: bruce.richardson@intel.com
Subject: Re: [dpdk-dev] [PATCH] baseband/acc100: remove logically dead code
Date: Wed, 21 Oct 2020 06:58:02 -0700 [thread overview]
Message-ID: <aea55c27-03dc-d7cd-6424-3a118a8c3cc9@redhat.com> (raw)
In-Reply-To: <1603141797-230055-2-git-send-email-nicolas.chautru@intel.com>
On 10/19/20 2:09 PM, Nicolas Chautru wrote:
> Coverity reported dead code for a few error
> checks which are indeed not reachable.
>
> Coverity issue: 363451, 363454, 363455
>
> Signed-off-by: Nicolas Chautru <nicolas.chautru@intel.com>
This change looks fine.
Should remove the 'Coverity issue: ... ' from the log.
Reviewed-by: Tom Rix <trix@redhat.com>
> ---
> drivers/baseband/acc100/rte_acc100_pmd.c | 9 ---------
> 1 file changed, 9 deletions(-)
>
> diff --git a/drivers/baseband/acc100/rte_acc100_pmd.c b/drivers/baseband/acc100/rte_acc100_pmd.c
> index 47ddbae..5e663a6 100644
> --- a/drivers/baseband/acc100/rte_acc100_pmd.c
> +++ b/drivers/baseband/acc100/rte_acc100_pmd.c
> @@ -2519,9 +2519,6 @@
> r++;
> }
>
> - if (unlikely(desc == NULL))
> - return current_enqueued_cbs;
> -
> #ifdef RTE_LIBRTE_BBDEV_DEBUG
> if (check_mbuf_total_left(mbuf_total_left) != 0)
> return -EINVAL;
> @@ -3076,9 +3073,6 @@
> r++;
> }
>
> - if (unlikely(desc == NULL))
> - return current_enqueued_cbs;
> -
> #ifdef RTE_LIBRTE_BBDEV_DEBUG
> if (check_mbuf_total_left(mbuf_total_left) != 0)
> return -EINVAL;
> @@ -3181,9 +3175,6 @@
> r++;
> }
>
> - if (unlikely(desc == NULL))
> - return current_enqueued_cbs;
> -
> #ifdef RTE_LIBRTE_BBDEV_DEBUG
> if (check_mbuf_total_left(mbuf_total_left) != 0)
> return -EINVAL;
next prev parent reply other threads:[~2020-10-21 13:58 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-19 21:09 Nicolas Chautru
2020-10-19 21:09 ` Nicolas Chautru
2020-10-21 13:58 ` Tom Rix [this message]
2020-10-26 12:03 ` Mcnamara, John
2020-10-28 11:32 ` Akhil Goyal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aea55c27-03dc-d7cd-6424-3a118a8c3cc9@redhat.com \
--to=trix@redhat.com \
--cc=akhil.goyal@nxp.com \
--cc=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
--cc=nicolas.chautru@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).