From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 8FC70A04DD; Wed, 21 Oct 2020 15:58:11 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 5E77DAA15; Wed, 21 Oct 2020 15:58:10 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [63.128.21.124]) by dpdk.org (Postfix) with ESMTP id 72D7BAA14 for ; Wed, 21 Oct 2020 15:58:08 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1603288687; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Jsprckxdw85IeXBkslb3dzHtO94FtUbRq7SbKHRU/N8=; b=Fze/oUjBal6rCy9Xz1MLQzUfxpBp2uDH62UJrnxGnytYEkbGOzHrtcOhG3rt86XJnfhOwt 6g4Au2fApGcM6Ox31EtFX8IiEeCO3GEXnaXbaQ2r7OQwe6uqfGkTfkyI+GkBGav9vVdrJQ E5mG0aKh3QH2RhFF4ERk0CFHtvjv3Fc= Received: from mail-qt1-f200.google.com (mail-qt1-f200.google.com [209.85.160.200]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-462-bdsX2Oa0M3-nNMZ4QnkCCQ-1; Wed, 21 Oct 2020 09:58:05 -0400 X-MC-Unique: bdsX2Oa0M3-nNMZ4QnkCCQ-1 Received: by mail-qt1-f200.google.com with SMTP id d1so1803108qtq.12 for ; Wed, 21 Oct 2020 06:58:05 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-transfer-encoding :content-language; bh=Jsprckxdw85IeXBkslb3dzHtO94FtUbRq7SbKHRU/N8=; b=kY9/pcOOwAVS9T9BgU70naQACnI3ATgSPZSK6+ugA8qqwJFzm/uz6NmNyv1pXi1bWZ SoQXIZpWZkFgbSCDYfANGqOnQEEeRCn6RubbhEKxKDeCxhWqBE089DlI2fbjdU5VKpGP TsK9lkZkyGkZxd1Y4awt7ZvmGFtJG2rv0Kx3UsmlKpb2p7VY7qzOudbusUFDy8MV2gsu 6BetKTvBAXOIrdx/ym9TrNQ7AMeiyxpPC/M/TK3Z9iLOB3Xg+iEolPGIlC5q4MUQr8E4 NNnq5jAfdYZtrx7ZTl7+m/ams+mfEZZLT5QMBequcqvEAANmoSXYydx9kCEXJcp5xLHt B97Q== X-Gm-Message-State: AOAM53320lbwW8zm8zD7cciLrFVtqWxdqGdNw6dlwZVBNiycz8dyz4Q/ abqt/mu10xlzUPsWYX9iolh8oRS4+/P3eUWdjLFCfAuZrGM9ppQNM1X7k1J4xX7vJnj5ZP3nRfW MbcQ= X-Received: by 2002:ae9:ee1a:: with SMTP id i26mr3192109qkg.217.1603288684875; Wed, 21 Oct 2020 06:58:04 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwnFeWS+qsU9pYZEhOo6UVazqU/kbyXvNN9RgXTmCY10EE6Qp5i02BQ5CDH4TR3p2aD17K2Vg== X-Received: by 2002:ae9:ee1a:: with SMTP id i26mr3192093qkg.217.1603288684632; Wed, 21 Oct 2020 06:58:04 -0700 (PDT) Received: from trix.remote.csb (075-142-250-213.res.spectrum.com. [75.142.250.213]) by smtp.gmail.com with ESMTPSA id e1sm501078qkm.35.2020.10.21.06.58.03 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 21 Oct 2020 06:58:04 -0700 (PDT) To: Nicolas Chautru , dev@dpdk.org, akhil.goyal@nxp.com Cc: bruce.richardson@intel.com References: <1603141797-230055-1-git-send-email-nicolas.chautru@intel.com> <1603141797-230055-2-git-send-email-nicolas.chautru@intel.com> From: Tom Rix Message-ID: Date: Wed, 21 Oct 2020 06:58:02 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.6.0 MIME-Version: 1.0 In-Reply-To: <1603141797-230055-2-git-send-email-nicolas.chautru@intel.com> Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=trix@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Content-Language: en-US Subject: Re: [dpdk-dev] [PATCH] baseband/acc100: remove logically dead code X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 10/19/20 2:09 PM, Nicolas Chautru wrote: > Coverity reported dead code for a few error > checks which are indeed not reachable. > > Coverity issue: 363451, 363454, 363455 > > Signed-off-by: Nicolas Chautru This change looks fine. Should remove the 'Coverity issue: ... ' from the log. Reviewed-by: Tom Rix > --- > drivers/baseband/acc100/rte_acc100_pmd.c | 9 --------- > 1 file changed, 9 deletions(-) > > diff --git a/drivers/baseband/acc100/rte_acc100_pmd.c b/drivers/baseband/acc100/rte_acc100_pmd.c > index 47ddbae..5e663a6 100644 > --- a/drivers/baseband/acc100/rte_acc100_pmd.c > +++ b/drivers/baseband/acc100/rte_acc100_pmd.c > @@ -2519,9 +2519,6 @@ > r++; > } > > - if (unlikely(desc == NULL)) > - return current_enqueued_cbs; > - > #ifdef RTE_LIBRTE_BBDEV_DEBUG > if (check_mbuf_total_left(mbuf_total_left) != 0) > return -EINVAL; > @@ -3076,9 +3073,6 @@ > r++; > } > > - if (unlikely(desc == NULL)) > - return current_enqueued_cbs; > - > #ifdef RTE_LIBRTE_BBDEV_DEBUG > if (check_mbuf_total_left(mbuf_total_left) != 0) > return -EINVAL; > @@ -3181,9 +3175,6 @@ > r++; > } > > - if (unlikely(desc == NULL)) > - return current_enqueued_cbs; > - > #ifdef RTE_LIBRTE_BBDEV_DEBUG > if (check_mbuf_total_left(mbuf_total_left) != 0) > return -EINVAL;