From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 502EDA04B6; Thu, 17 Sep 2020 13:08:22 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id CA45A1D5FA; Thu, 17 Sep 2020 13:08:21 +0200 (CEST) Received: from mailgw02.pantheon.sk (mailgw01.pantheon.sk [46.229.239.26]) by dpdk.org (Postfix) with ESMTP id 121E01D5F1 for ; Thu, 17 Sep 2020 13:08:20 +0200 (CEST) Received: from mailgw02.pantheon.sk (localhost.localdomain [127.0.0.1]) by mailgw02.pantheon.sk (Proxmox) with ESMTP id AC612182D9D; Thu, 17 Sep 2020 13:08:19 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=pantheon.tech; h=cc:cc:content-transfer-encoding:content-type:content-type :date:from:from:in-reply-to:message-id:mime-version:references :reply-to:subject:subject:to:to; s=dkim; bh=AOWkqrYH0S4XrQsT+eYS m8zWJootRQTtZoDM5VbBe/I=; b=nqGMbolJTtXx9Kl/lN2Ca6fP4AYn+4li2XWu Ef5YLTSEY4drYcTzrE345n7f3RklHRLts5or8gaOnkMOAEkiO/84vHietJg+pnNp Xtobh9KKHtCmgO06SF4R2/Pfr9i5EzlL+nmE+r7wQluBtaaBjFkL3tWUIDCTrjg1 5/w6jLJi9OILDUBx0MUkehgOOPPTOuwyk96+0YTHWKHvnef+1n/AfxAjcBDag4pL EcwM6uSP6wJfl6zmvJS/goTp7127zhdykREM8UOjHjrqkGSj3VStUNzHQYDSnBjP NnEcXyHsoGATH/Q4/AQ0FSD7WQvOatB1RlRxgyd0qyMbUVchAw== From: =?iso-8859-2?Q?Juraj_Linke=B9?= To: Phil Yang , "david.marchand@redhat.com" , "dev@dpdk.org" CC: "Honnappa.Nagarahalli@arm.com" , "Ruifeng.Wang@arm.com" , "nd@arm.com" Thread-Topic: [dpdk-dev] [PATCH] devtools: fix ninja break under default DESTDIR path Thread-Index: AQHWVb2kRcH6C/VVVkqEID1E/cG8sqltF+1Q Date: Thu, 17 Sep 2020 11:08:19 +0000 Message-ID: References: <1594277585-15281-1-git-send-email-phil.yang@arm.com> In-Reply-To: <1594277585-15281-1-git-send-email-phil.yang@arm.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.101.4.10] Content-Type: text/plain; charset="iso-8859-2" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH] devtools: fix ninja break under default DESTDIR path X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > -----Original Message----- > From: dev On Behalf Of Phil Yang > Sent: Thursday, July 9, 2020 8:53 AM > To: david.marchand@redhat.com; dev@dpdk.org > Cc: Honnappa.Nagarahalli@arm.com; Ruifeng.Wang@arm.com; nd@arm.com > Subject: [dpdk-dev] [PATCH] devtools: fix ninja break under default DESTD= IR > path >=20 > If DPDK_ABI_REF_DIR is not set, the default DESTDIR is a relative path. > This will break ninja in the ABI check test. >=20 The commit message is not very clear. The problem is we're specifying ninja= 's destination dir in variable DESTDIR when invoking ninja install. If the = DESTDIR is not an absolute path, ninja complains (when invoking install). T= his isn't directly related to DPDK_ABI_REF_DIR, it's more a problem with ho= w we call install_target. > Fixes: 777014e56d07 ("devtools: add ABI checks") >=20 > Signed-off-by: Phil Yang > --- > devtools/test-meson-builds.sh | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) >=20 > diff --git a/devtools/test-meson-builds.sh b/devtools/test-meson-builds.s= h index > a87de63..2bfcaca 100755 > --- a/devtools/test-meson-builds.sh > +++ b/devtools/test-meson-builds.sh > @@ -143,7 +143,7 @@ build () # > > config $srcdir $builds_dir/$targetdir $cross --werror $* > compile $builds_dir/$targetdir > if [ -n "$DPDK_ABI_REF_VERSION" ]; then > - abirefdir=3D${DPDK_ABI_REF_DIR:- > reference}/$DPDK_ABI_REF_VERSION > + abirefdir=3D${DPDK_ABI_REF_DIR:- > $(pwd)/reference}/$DPDK_ABI_REF_VERSION > if [ ! -d $abirefdir/$targetdir ]; then > # clone current sources > if [ ! -d $abirefdir/src ]; then > -- > 2.7.4 >=20 install_target on line 160 is called improperly. Let's fix it so that it ma= tches line 169: install_target $abirefdir/build $(readlink -f $abirefdir/$targetdir) This way we don't need to add $(pwd).